Re: [PATCH] for YMF PCI sound cards
> > {0x414B4D01, "Asahi Kasei AK4540 rev 1", NULL},
> > + {0x41445303, "Yamaha YMF" , NULL},
>
> Are you sure it's correct? I am almost certain that no YMFxxx
Its definitely wrong
> has on-chip AC97. I'd like to see a document that allows you
> the change quoted above.
4144 is Analog Devices vendor ID.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
> Loading the module would cause a very loud monotone > squeal, like some kind of theft detection device. The computer Thats actually a generic bug in both ALSA and the kernel AC97 driver (fixed in 2.2 and by Linus in 2.4test). It is feedback between the microphone and speakers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
Hello, Pete!
> The idea of the patch looks good but there is a small problem.
> I have an open/close fix queued with Alan for post-2.2.18,
> which changes the enumeration scheme for ymfcpi to make it
> more friendly to other sound cards (Bug from Abhijit Menon-Sen).
> This is a conflict because you use instance number to find
> what card goes in first. In fact I plan to send the same
> thing to Linus for 2.4 (if he have not fixed that already).
Ok, I'm not a good kernel hacker. I simply did what I believed would be
the behaviour that minimizes the number of gotchas for the end user. If
the instance number isn't reliable then drop it and initialize OPL for all
cards.
The users of multiple cards will have to supply synth_io, but I wouldn't
fight to save few keystrokes for the insane people with more than one YMF
soundcard :-)
> Would you please to hold on to your patch for couple of weeks
> and then resync and redo it? Alternatively, I'll keep your
> patch and will reapply it in the way I see sane, but you will
> have to retest it before I issue it.
The later is better. I never know whether I'll have a free minute in a
couple of weeks.
> > + {0x41445303, "Yamaha YMF" , NULL},
>
> Are you sure it's correct? I am almost certain that no YMFxxx
> has on-chip AC97. I'd like to see a document that allows you
> the change quoted above.
I have no documents, only the log from the patched module:
Dec 8 13:29:35 fonzie kernel: ymfpci0: YMF740C at 0xf000 IRQ 10
Dec 8 13:29:35 fonzie kernel: ymfpci0: set OPL3 I/O at 0x388
Dec 8 13:29:36 fonzie kernel: ac97_codec: AC97 Audio codec, id:
0x4144:0x5303 (Yamaha YMF)
Drop it if it's not convincing.
Regards,
Pavel Roskin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
On Fri, 8 Dec 2000, Pete Zaitcev wrote:
> > +++ ./drivers/sound/ac97_codec.cThu Dec 7 11:00:44 2000
> > @@ -61,6 +61,7 @@
> > } ac97_codec_ids[] = {
> > {0x414B4D00, "Asahi Kasei AK4540 rev 0", NULL},
> > {0x414B4D01, "Asahi Kasei AK4540 rev 1", NULL},
> > + {0x41445303, "Yamaha YMF" , NULL},
>
> Are you sure it's correct? I am almost certain that no YMFxxx
> has on-chip AC97. I'd like to see a document that allows you
> the change quoted above.
It's Analog Device's AD1819 chip.
Jaroslav
-
Jaroslav Kysela <[EMAIL PROTECTED]>
SuSE Linuxhttp://www.suse.com
ALSA project http://www.alsa-project.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
> Date: Fri, 8 Dec 2000 11:41:07 -0500 (EST)
> From: Pavel Roskin <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> cc: <[EMAIL PROTECTED]>, Pete Zaitcev <[EMAIL PROTECTED]>,
> Jaroslav Kysela <[EMAIL PROTECTED]>
> --- ./drivers/sound/Config.in Thu Dec 7 10:59:06 2000
> +++ ./drivers/sound/Config.in Fri Dec 8 11:25:08 2000
No problem here.
> --- ./drivers/sound/ymfpci.c Thu Dec 7 10:59:06 2000
> +++ ./drivers/sound/ymfpci.c Fri Dec 8 11:33:51 2000
The idea of the patch looks good but there is a small problem.
I have an open/close fix queued with Alan for post-2.2.18,
which changes the enumeration scheme for ymfcpi to make it
more friendly to other sound cards (Bug from Abhijit Menon-Sen).
This is a conflict because you use instance number to find
what card goes in first. In fact I plan to send the same
thing to Linus for 2.4 (if he have not fixed that already).
Would you please to hold on to your patch for couple of weeks
and then resync and redo it? Alternatively, I'll keep your
patch and will reapply it in the way I see sane, but you will
have to retest it before I issue it.
> --- ./drivers/sound/ac97_codec.c Thu Dec 7 10:59:06 2000
> +++ ./drivers/sound/ac97_codec.c Thu Dec 7 11:00:44 2000
> @@ -61,6 +61,7 @@
> } ac97_codec_ids[] = {
> {0x414B4D00, "Asahi Kasei AK4540 rev 0", NULL},
> {0x414B4D01, "Asahi Kasei AK4540 rev 1", NULL},
> + {0x41445303, "Yamaha YMF" , NULL},
Are you sure it's correct? I am almost certain that no YMFxxx
has on-chip AC97. I'd like to see a document that allows you
the change quoted above.
--Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
Date: Fri, 8 Dec 2000 11:41:07 -0500 (EST)
From: Pavel Roskin [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
cc: [EMAIL PROTECTED], Pete Zaitcev [EMAIL PROTECTED],
Jaroslav Kysela [EMAIL PROTECTED]
--- ./drivers/sound/Config.in Thu Dec 7 10:59:06 2000
+++ ./drivers/sound/Config.in Fri Dec 8 11:25:08 2000
No problem here.
--- ./drivers/sound/ymfpci.c Thu Dec 7 10:59:06 2000
+++ ./drivers/sound/ymfpci.c Fri Dec 8 11:33:51 2000
The idea of the patch looks good but there is a small problem.
I have an open/close fix queued with Alan for post-2.2.18,
which changes the enumeration scheme for ymfcpi to make it
more friendly to other sound cards (Bug from Abhijit Menon-Sen).
This is a conflict because you use instance number to find
what card goes in first. In fact I plan to send the same
thing to Linus for 2.4 (if he have not fixed that already).
Would you please to hold on to your patch for couple of weeks
and then resync and redo it? Alternatively, I'll keep your
patch and will reapply it in the way I see sane, but you will
have to retest it before I issue it.
--- ./drivers/sound/ac97_codec.c Thu Dec 7 10:59:06 2000
+++ ./drivers/sound/ac97_codec.c Thu Dec 7 11:00:44 2000
@@ -61,6 +61,7 @@
} ac97_codec_ids[] = {
{0x414B4D00, "Asahi Kasei AK4540 rev 0", NULL},
{0x414B4D01, "Asahi Kasei AK4540 rev 1", NULL},
+ {0x41445303, "Yamaha YMF" , NULL},
Are you sure it's correct? I am almost certain that no YMFxxx
has on-chip AC97. I'd like to see a document that allows you
the change quoted above.
--Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
On Fri, 8 Dec 2000, Pete Zaitcev wrote:
+++ ./drivers/sound/ac97_codec.cThu Dec 7 11:00:44 2000
@@ -61,6 +61,7 @@
} ac97_codec_ids[] = {
{0x414B4D00, "Asahi Kasei AK4540 rev 0", NULL},
{0x414B4D01, "Asahi Kasei AK4540 rev 1", NULL},
+ {0x41445303, "Yamaha YMF" , NULL},
Are you sure it's correct? I am almost certain that no YMFxxx
has on-chip AC97. I'd like to see a document that allows you
the change quoted above.
It's Analog Device's AD1819 chip.
Jaroslav
-
Jaroslav Kysela [EMAIL PROTECTED]
SuSE Linuxhttp://www.suse.com
ALSA project http://www.alsa-project.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
Loading the module would cause a very loud monotone squeal, like some kind of theft detection device. The computer Thats actually a generic bug in both ALSA and the kernel AC97 driver (fixed in 2.2 and by Linus in 2.4test). It is feedback between the microphone and speakers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] for YMF PCI sound cards
{0x414B4D01, "Asahi Kasei AK4540 rev 1", NULL},
+ {0x41445303, "Yamaha YMF" , NULL},
Are you sure it's correct? I am almost certain that no YMFxxx
Its definitely wrong
has on-chip AC97. I'd like to see a document that allows you
the change quoted above.
4144 is Analog Devices vendor ID.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
