Re: [PATCH] hwrng: ingenic - Fix a resource leak in an error handling path

[Herbert Xu]

On Sat, Dec 19, 2020 at 08:52:07AM +0100, Christophe JAILLET wrote:
> In case of error, we should call 'clk_disable_unprepare()' to undo a
> previous 'clk_prepare_enable()' call, as already done in the remove
> function.
> 
> Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830")
> Signed-off-by: Christophe JAILLET 
> ---
>  drivers/char/hw_random/ingenic-trng.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: ingenic - Fix a resource leak in an error handling path

[Zhou Yanjie]

Hi Christophe,

On 2020/12/19 下午3:52, Christophe JAILLET wrote:

In case of error, we should call 'clk_disable_unprepare()' to undo a
previous 'clk_prepare_enable()' call, as already done in the remove
function.

Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830")
Signed-off-by: Christophe JAILLET 
---
  drivers/char/hw_random/ingenic-trng.c | 6 +-
  1 file changed, 5 insertions(+), 1 deletion(-)



Thanks for fixing it, and apologize for my carelessness.

Tested-by: 周琰杰 (Zhou Yanjie) 



diff --git a/drivers/char/hw_random/ingenic-trng.c 
b/drivers/char/hw_random/ingenic-trng.c
index 954a8411d67d..0eb80f786f4d 100644
--- a/drivers/char/hw_random/ingenic-trng.c
+++ b/drivers/char/hw_random/ingenic-trng.c
@@ -113,13 +113,17 @@ static int ingenic_trng_probe(struct platform_device 
*pdev)
ret = hwrng_register(>rng);
if (ret) {
dev_err(>dev, "Failed to register hwrng\n");
-   return ret;
+   goto err_unprepare_clk;
}
  
  	platform_set_drvdata(pdev, trng);
  
  	dev_info(>dev, "Ingenic DTRNG driver registered\n");

return 0;
+
+err_unprepare_clk:
+   clk_disable_unprepare(trng->clk);
+   return ret;
  }
  
  static int ingenic_trng_remove(struct platform_device *pdev)