Re: [PATCH] isdn_v110 warning fix
On 8/30/05, Karsten Keil <[EMAIL PROTECTED]> wrote: > On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote: > > > > This is OK. Even if the codepath is never executed in a way that ret might > be used uninitialized it does not harm to set ret = 0. > > > Warning fix : > drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized > in this function > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Karsten Keil <[EMAIL PROTECTED]> > Thank you for your feedback and for signing off on the patch. I'll forward it to Andrew for inclusion in -mm. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On 8/30/05, Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
> > drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used
> > uninitialized in this function
>
> > --- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
> > +++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
> > @@ -516,11 +516,11 @@
>
> > -isdn_v110_stat_callback(int idx, isdn_ctrl * c)
> > +isdn_v110_stat_callback(int idx, isdn_ctrl *c)
> > {
> > isdn_v110_stream *v = NULL;
> > int i;
> > - int ret;
> > + int ret = 0;
>
> ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
> It's possible for it to be unused only if passed c->parm.length is 0.
> Do you see codepaths that can do it?
>
No, I don't see any codepaths that could lead to it being used uninitialized.
I made the patch for two reasons; 1) To silence the warning, and I
guess it's simply the right thing to do. 2) To make sure the code
behaves in a resonably sane way in case the situation
c->parm.length==0 should somehow happen in the future.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
>
This is OK. Even if the codepath is never executed in a way that ret might
be used uninitialized it does not harm to set ret = 0.
Warning fix :
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized
in this function
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/i4l/isdn_v110.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c 2005-08-29
01:41:01.0 +0200
+++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c 2005-08-30 00:59:34.0
+0200
@@ -516,11 +516,11 @@
}
int
-isdn_v110_stat_callback(int idx, isdn_ctrl * c)
+isdn_v110_stat_callback(int idx, isdn_ctrl *c)
{
isdn_v110_stream *v = NULL;
int i;
- int ret;
+ int ret = 0;
if (idx < 0)
return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
> On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
> > drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used
> > uninitialized in this function
>
> > --- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
> > +++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
> > @@ -516,11 +516,11 @@
>
> > -isdn_v110_stat_callback(int idx, isdn_ctrl * c)
> > +isdn_v110_stat_callback(int idx, isdn_ctrl *c)
> > {
> > isdn_v110_stream *v = NULL;
> > int i;
> > - int ret;
> > + int ret = 0;
>
> ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
> It's possible for it to be unused only if passed c->parm.length is 0.
> Do you see codepaths that can do it?
>
initializing ret with the value zero is correct and should be
done.
---
Thomas Pfeiffer, PDS - Programm + Datenservice GmbH
email: [EMAIL PROTECTED], http://www.pds.de/QFS-BILD
Tel: (49) 4261 855 614, Fax: (49) 4261 855 675
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
> drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized
> in this function
> --- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
> +++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
> @@ -516,11 +516,11 @@
> -isdn_v110_stat_callback(int idx, isdn_ctrl * c)
> +isdn_v110_stat_callback(int idx, isdn_ctrl *c)
> {
> isdn_v110_stream *v = NULL;
> int i;
> - int ret;
> + int ret = 0;
ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
It's possible for it to be unused only if passed c->parm.length is 0.
Do you see codepaths that can do it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized
in this function
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
+++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
@@ -516,11 +516,11 @@
-isdn_v110_stat_callback(int idx, isdn_ctrl * c)
+isdn_v110_stat_callback(int idx, isdn_ctrl *c)
{
isdn_v110_stream *v = NULL;
int i;
- int ret;
+ int ret = 0;
ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
It's possible for it to be unused only if passed c-parm.length is 0.
Do you see codepaths that can do it?
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used
uninitialized in this function
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
+++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
@@ -516,11 +516,11 @@
-isdn_v110_stat_callback(int idx, isdn_ctrl * c)
+isdn_v110_stat_callback(int idx, isdn_ctrl *c)
{
isdn_v110_stream *v = NULL;
int i;
- int ret;
+ int ret = 0;
ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
It's possible for it to be unused only if passed c-parm.length is 0.
Do you see codepaths that can do it?
initializing ret with the value zero is correct and should be
done.
---
Thomas Pfeiffer, PDS - Programm + Datenservice GmbH
email: [EMAIL PROTECTED], http://www.pds.de/QFS-BILD
Tel: (49) 4261 855 614, Fax: (49) 4261 855 675
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
This is OK. Even if the codepath is never executed in a way that ret might
be used uninitialized it does not harm to set ret = 0.
Warning fix :
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized
in this function
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
Signed-off-by: Karsten Keil [EMAIL PROTECTED]
---
drivers/isdn/i4l/isdn_v110.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c 2005-08-29
01:41:01.0 +0200
+++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c 2005-08-30 00:59:34.0
+0200
@@ -516,11 +516,11 @@
}
int
-isdn_v110_stat_callback(int idx, isdn_ctrl * c)
+isdn_v110_stat_callback(int idx, isdn_ctrl *c)
{
isdn_v110_stream *v = NULL;
int i;
- int ret;
+ int ret = 0;
if (idx 0)
return 0;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On 8/30/05, Alexey Dobriyan [EMAIL PROTECTED] wrote:
On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used
uninitialized in this function
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
+++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
@@ -516,11 +516,11 @@
-isdn_v110_stat_callback(int idx, isdn_ctrl * c)
+isdn_v110_stat_callback(int idx, isdn_ctrl *c)
{
isdn_v110_stream *v = NULL;
int i;
- int ret;
+ int ret = 0;
ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
It's possible for it to be unused only if passed c-parm.length is 0.
Do you see codepaths that can do it?
No, I don't see any codepaths that could lead to it being used uninitialized.
I made the patch for two reasons; 1) To silence the warning, and I
guess it's simply the right thing to do. 2) To make sure the code
behaves in a resonably sane way in case the situation
c-parm.length==0 should somehow happen in the future.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] isdn_v110 warning fix
On 8/30/05, Karsten Keil [EMAIL PROTECTED] wrote: On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote: This is OK. Even if the codepath is never executed in a way that ret might be used uninitialized it does not harm to set ret = 0. Warning fix : drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized in this function Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Karsten Keil [EMAIL PROTECTED] Thank you for your feedback and for signing off on the patch. I'll forward it to Andrew for inclusion in -mm. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
