Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On 08/30/2017 08:04 AM, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. Added for 4.14, with the ack from Tejun and Greg. -- Jens Axboe
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On 08/30/2017 08:04 AM, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. Added for 4.14, with the ack from Tejun and Greg. -- Jens Axboe
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On Thu, Aug 31, 2017 at 01:56:40PM -0600, Jens Axboe wrote:
> On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote:
> > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> >> The kernfs_get_inode() returns NULL on error, it never returns error
> >> pointers.
> >>
> >> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> >> Signed-off-by: Dan Carpenter
> >> Acked-by: Tejun Heo
> >
> > Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
> > can't take this patch :(
>
> It's in my tree, I'll take it. Can I add your
> acked/reviewed/whatever-by?
Yes:
Acked-by: Greg Kroah-Hartman
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On Thu, Aug 31, 2017 at 01:56:40PM -0600, Jens Axboe wrote:
> On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote:
> > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> >> The kernfs_get_inode() returns NULL on error, it never returns error
> >> pointers.
> >>
> >> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> >> Signed-off-by: Dan Carpenter
> >> Acked-by: Tejun Heo
> >
> > Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
> > can't take this patch :(
>
> It's in my tree, I'll take it. Can I add your
> acked/reviewed/whatever-by?
Yes:
Acked-by: Greg Kroah-Hartman
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote:
> On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
>> The kernfs_get_inode() returns NULL on error, it never returns error
>> pointers.
>>
>> Fixes: aa8188253474 ("kernfs: add exportfs operations")
>> Signed-off-by: Dan Carpenter
>> Acked-by: Tejun Heo
>
> Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
> can't take this patch :(
It's in my tree, I'll take it. Can I add your
acked/reviewed/whatever-by?
--
Jens Axboe
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote:
> On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
>> The kernfs_get_inode() returns NULL on error, it never returns error
>> pointers.
>>
>> Fixes: aa8188253474 ("kernfs: add exportfs operations")
>> Signed-off-by: Dan Carpenter
>> Acked-by: Tejun Heo
>
> Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
> can't take this patch :(
It's in my tree, I'll take it. Can I add your
acked/reviewed/whatever-by?
--
Jens Axboe
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> The kernfs_get_inode() returns NULL on error, it never returns error
> pointers.
>
> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> Signed-off-by: Dan Carpenter
> Acked-by: Tejun Heo
Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
can't take this patch :(
thanks,
greg k-h
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> The kernfs_get_inode() returns NULL on error, it never returns error
> pointers.
>
> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> Signed-off-by: Dan Carpenter
> Acked-by: Tejun Heo
Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
can't take this patch :(
thanks,
greg k-h
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> The kernfs_get_inode() returns NULL on error, it never returns error
> pointers.
>
> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> Signed-off-by: Dan Carpenter
Acked-by: Tejun Heo
Greg, can you please route this patch?
Thanks.
--
tejun
Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> The kernfs_get_inode() returns NULL on error, it never returns error
> pointers.
>
> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> Signed-off-by: Dan Carpenter
Acked-by: Tejun Heo
Greg, can you please route this patch?
Thanks.
--
tejun
