Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-15 Thread Tang Bin 

Hi Saeed：

On 2020/5/16 6:28, Saeed Mahameed wrote:

On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote:

Hi David:

On 2020/5/8 4:18, David Miller wrote:

From: Tang Bin 
Date: Thu,  7 May 2020 19:50:10 +0800


Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()

 ^^^ typo

Sorry for this mistake, sorry.

to simplify code, avoid redundant judgements.

Signed-off-by: Zhang Shengju 
Signed-off-by: Tang Bin 

Saeed, please pick this up.

Does this mean the patch has been received and I just have to wait?


no, mlx5 patches normally go to net-next-mlx5 branch and usually
pulled into net-next once a week when i send my pull requests.

i will reply with "applied" when i apply this patch,
but for now please fix the typo.


Got it, I will send v2 for you.

Thanks,

Tang Bin

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-15 Thread Saeed Mahameed 
On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote:
> Hi David:
> 
> On 2020/5/8 4:18, David Miller wrote:
> > From: Tang Bin 
> > Date: Thu,  7 May 2020 19:50:10 +0800
> > 
> > > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
^^^ typo
> > > to simplify code, avoid redundant judgements.
> > > 
> > > Signed-off-by: Zhang Shengju 
> > > Signed-off-by: Tang Bin 
> > Saeed, please pick this up.
> 
> Does this mean the patch has been received and I just have to wait?
> 

no, mlx5 patches normally go to net-next-mlx5 branch and usually
pulled into net-next once a week when i send my pull requests.

i will reply with "applied" when i apply this patch,
but for now please fix the typo.

Thanks,
Saeed

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-13 Thread Tang Bin 

Hi David:

On 2020/5/8 4:18, David Miller wrote:

From: Tang Bin 
Date: Thu,  7 May 2020 19:50:10 +0800


Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
to simplify code, avoid redundant judgements.

Signed-off-by: Zhang Shengju 
Signed-off-by: Tang Bin 

Saeed, please pick this up.


Does this mean the patch has been received and I just have to wait?

Thanks,

Tang Bin

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-07 Thread David Miller 
From: Tang Bin 
Date: Thu,  7 May 2020 19:50:10 +0800

> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
> to simplify code, avoid redundant judgements.
> 
> Signed-off-by: Zhang Shengju 
> Signed-off-by: Tang Bin 

Saeed, please pick this up.

Thank you.

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-07 Thread Leon Romanovsky 
On Thu, May 07, 2020 at 07:50:10PM +0800, Tang Bin wrote:
> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO()
> to simplify code, avoid redundant judgements.
>
> Signed-off-by: Zhang Shengju 
> Signed-off-by: Tang Bin 
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky