Re: [PATCH] newport_con: vc_color is now in state
On 24. 07. 20, 11:30, Sergei Shtylyov wrote: > On 24.07.2020 9:27, Jiri Slaby wrote: > >> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as > > Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). That's because it's not in Linus' repo yet. -- js suse labs
Re: [PATCH] newport_con: vc_color is now in state
On Fri, Jul 24, 2020 at 12:30:59PM +0300, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
> > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
>Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
> enclose the commit summary in (""), not just ()...
I've added the proper "Fixes:" tag when committing this, no worries.
greg k-h
Re: [PATCH] newport_con: vc_color is now in state
On 24.07.2020 9:27, Jiri Slaby wrote:
Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
enclose the commit summary in (""), not just ()...
vc->state.color. Somehow both me and 0-day bot missed this driver during
the conversion.
So fix the driver now.
Signed-off-by: Jiri Slaby
Cc: Bartlomiej Zolnierkiewicz
Cc: dri-de...@lists.freedesktop.org
Cc: linux-fb...@vger.kernel.org
Cc: linux-m...@vger.kernel.org
[...]
MBR, Sergei
Re: [PATCH] newport_con: vc_color is now in state
On 24. 07. 20, 9:58, Greg KH wrote: > On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote: >> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as >> vc->state.color. Somehow both me and 0-day bot missed this driver during >> the conversion. >> >> So fix the driver now. >> >> Signed-off-by: Jiri Slaby >> Cc: Bartlomiej Zolnierkiewicz >> Cc: dri-de...@lists.freedesktop.org >> Cc: linux-fb...@vger.kernel.org >> Cc: linux-m...@vger.kernel.org >> --- >> drivers/video/console/newport_con.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) > > You forgot the "Reported-by:" line :( Ah, I didn't know/notice. Will do next time. Thanks. -- js suse labs
Re: [PATCH] newport_con: vc_color is now in state
On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote: > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as > vc->state.color. Somehow both me and 0-day bot missed this driver during > the conversion. > > So fix the driver now. > > Signed-off-by: Jiri Slaby > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-de...@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Cc: linux-m...@vger.kernel.org > --- > drivers/video/console/newport_con.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) You forgot the "Reported-by:" line :( I'll go add it, thanks for the fix. greg k-h
