Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

[Jon Mason]

On Fri, Oct 05, 2018 at 01:03:01PM -0400, Allen Hubbe wrote:
> On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva
>  wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Addresses-Coverity-ID: 1373888 ("Missing break in switch")
> > Addresses-Coverity-ID: 1373889 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva 
> 
> Acked-by: Allen Hubbe 

Applied

Thanks,
Jon

> 
> > ---
> >  drivers/ntb/ntb_transport.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> > index 9398959..c643b9c 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -1278,6 +1278,7 @@ static void ntb_rx_copy_callback(void *data,
> > case DMA_TRANS_READ_FAILED:
> > case DMA_TRANS_WRITE_FAILED:
> > entry->errors++;
> > +   /* fall through */
> > case DMA_TRANS_ABORTED:
> > {
> > struct ntb_transport_qp *qp = entry->qp;
> > @@ -1533,6 +1534,7 @@ static void ntb_tx_copy_callback(void *data,
> > case DMA_TRANS_READ_FAILED:
> > case DMA_TRANS_WRITE_FAILED:
> > entry->errors++;
> > +   /* fall through */
> > case DMA_TRANS_ABORTED:
> > {
> > void __iomem *offset =
> > --
> > 2.7.4

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

[Jon Mason]

On Fri, Oct 05, 2018 at 01:03:01PM -0400, Allen Hubbe wrote:
> On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva
>  wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Addresses-Coverity-ID: 1373888 ("Missing break in switch")
> > Addresses-Coverity-ID: 1373889 ("Missing break in switch")
> > Signed-off-by: Gustavo A. R. Silva 
> 
> Acked-by: Allen Hubbe 

Applied

Thanks,
Jon

> 
> > ---
> >  drivers/ntb/ntb_transport.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> > index 9398959..c643b9c 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -1278,6 +1278,7 @@ static void ntb_rx_copy_callback(void *data,
> > case DMA_TRANS_READ_FAILED:
> > case DMA_TRANS_WRITE_FAILED:
> > entry->errors++;
> > +   /* fall through */
> > case DMA_TRANS_ABORTED:
> > {
> > struct ntb_transport_qp *qp = entry->qp;
> > @@ -1533,6 +1534,7 @@ static void ntb_tx_copy_callback(void *data,
> > case DMA_TRANS_READ_FAILED:
> > case DMA_TRANS_WRITE_FAILED:
> > entry->errors++;
> > +   /* fall through */
> > case DMA_TRANS_ABORTED:
> > {
> > void __iomem *offset =
> > --
> > 2.7.4

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

[Allen Hubbe]

On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva
 wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1373888 ("Missing break in switch")
> Addresses-Coverity-ID: 1373889 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva 

Acked-by: Allen Hubbe 

> ---
>  drivers/ntb/ntb_transport.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 9398959..c643b9c 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -1278,6 +1278,7 @@ static void ntb_rx_copy_callback(void *data,
> case DMA_TRANS_READ_FAILED:
> case DMA_TRANS_WRITE_FAILED:
> entry->errors++;
> +   /* fall through */
> case DMA_TRANS_ABORTED:
> {
> struct ntb_transport_qp *qp = entry->qp;
> @@ -1533,6 +1534,7 @@ static void ntb_tx_copy_callback(void *data,
> case DMA_TRANS_READ_FAILED:
> case DMA_TRANS_WRITE_FAILED:
> entry->errors++;
> +   /* fall through */
> case DMA_TRANS_ABORTED:
> {
> void __iomem *offset =
> --
> 2.7.4

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

[Allen Hubbe]

On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva
 wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1373888 ("Missing break in switch")
> Addresses-Coverity-ID: 1373889 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva 

Acked-by: Allen Hubbe 

> ---
>  drivers/ntb/ntb_transport.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 9398959..c643b9c 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -1278,6 +1278,7 @@ static void ntb_rx_copy_callback(void *data,
> case DMA_TRANS_READ_FAILED:
> case DMA_TRANS_WRITE_FAILED:
> entry->errors++;
> +   /* fall through */
> case DMA_TRANS_ABORTED:
> {
> struct ntb_transport_qp *qp = entry->qp;
> @@ -1533,6 +1534,7 @@ static void ntb_tx_copy_callback(void *data,
> case DMA_TRANS_READ_FAILED:
> case DMA_TRANS_WRITE_FAILED:
> entry->errors++;
> +   /* fall through */
> case DMA_TRANS_ABORTED:
> {
> void __iomem *offset =
> --
> 2.7.4