Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)

2015-12-08 Thread Masahiro Yamada
Hi Rob,

2015-12-07 5:40 GMT+09:00 Rob Herring :
> On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada
>  wrote:
>> A trivial change suggested by checkpatch.pl.
>
> You might as well all levels while you are at it. Looks like that is
> only one more:
>
> drivers/of/address.c:   printk(KERN_DEBUG "%s", s);
>

OK, I have just posted v2.





-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)

2015-12-06 Thread Rob Herring
On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada
 wrote:
> A trivial change suggested by checkpatch.pl.

You might as well all levels while you are at it. Looks like that is
only one more:

drivers/of/address.c:   printk(KERN_DEBUG "%s", s);

Rob

>
> Signed-off-by: Masahiro Yamada 
> ---
>
>  drivers/of/address.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index cd53fe4..5289c80 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev,
> pbus = of_match_bus(parent);
> pbus->count_cells(dev, &pna, &pns);
> if (!OF_CHECK_COUNTS(pna, pns)) {
> -   printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
> +   pr_err("prom_parse: Bad cell count for %s\n",
>of_node_full_name(dev));
> break;
> }
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/