Re: [PATCH] pci: xgene: Add ECAM fixups
On Friday 15 April 2016 14:30:56 Duc Dang wrote: > On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmannwrote: > > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote: > >> X-Gene PCIe controller does not fully support ECAM. > >> This patch adds required ECAM fixup to allow X-Gene > >> PCIe controller to be functional in ACPI boot mode. > >> > >> This patch is based on the original work of > >> Mark Salter and depends on > >> Tomasz's PCIe ACPI series: > >> https://lkml.org/lkml/2016/2/4/646 > >> > >> Signed-off-by: Duc Dang > >> --- > > > > This really has nothing to do with the PCI host device driver, please > > keep it in a separate file in drivers/acpi/. > > Hi Arnd, > > With Tomasz latest PCIe ACPI series > (https://lkml.org/lkml/2016/4/15/594), do you think it still better to > keep the ACPI ECAM fixup code in a separate file in drivers/acpi > directory? Yes, I made the same comment for the cavium PCI workaround in that series. Arnd
Re: [PATCH] pci: xgene: Add ECAM fixups
On Friday 15 April 2016 14:30:56 Duc Dang wrote: > On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann wrote: > > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote: > >> X-Gene PCIe controller does not fully support ECAM. > >> This patch adds required ECAM fixup to allow X-Gene > >> PCIe controller to be functional in ACPI boot mode. > >> > >> This patch is based on the original work of > >> Mark Salter and depends on > >> Tomasz's PCIe ACPI series: > >> https://lkml.org/lkml/2016/2/4/646 > >> > >> Signed-off-by: Duc Dang > >> --- > > > > This really has nothing to do with the PCI host device driver, please > > keep it in a separate file in drivers/acpi/. > > Hi Arnd, > > With Tomasz latest PCIe ACPI series > (https://lkml.org/lkml/2016/4/15/594), do you think it still better to > keep the ACPI ECAM fixup code in a separate file in drivers/acpi > directory? Yes, I made the same comment for the cavium PCI workaround in that series. Arnd
Re: [PATCH] pci: xgene: Add ECAM fixups
On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmannwrote: > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote: >> X-Gene PCIe controller does not fully support ECAM. >> This patch adds required ECAM fixup to allow X-Gene >> PCIe controller to be functional in ACPI boot mode. >> >> This patch is based on the original work of >> Mark Salter and depends on >> Tomasz's PCIe ACPI series: >> https://lkml.org/lkml/2016/2/4/646 >> >> Signed-off-by: Duc Dang >> --- > > This really has nothing to do with the PCI host device driver, please > keep it in a separate file in drivers/acpi/. Hi Arnd, With Tomasz latest PCIe ACPI series (https://lkml.org/lkml/2016/4/15/594), do you think it still better to keep the ACPI ECAM fixup code in a separate file in drivers/acpi directory? Regards, Duc Dang. > > Arnd
Re: [PATCH] pci: xgene: Add ECAM fixups
On Wed, Feb 10, 2016 at 6:28 AM, Arnd Bergmann wrote: > On Tuesday 09 February 2016 17:49:44 Duc Dang wrote: >> X-Gene PCIe controller does not fully support ECAM. >> This patch adds required ECAM fixup to allow X-Gene >> PCIe controller to be functional in ACPI boot mode. >> >> This patch is based on the original work of >> Mark Salter and depends on >> Tomasz's PCIe ACPI series: >> https://lkml.org/lkml/2016/2/4/646 >> >> Signed-off-by: Duc Dang >> --- > > This really has nothing to do with the PCI host device driver, please > keep it in a separate file in drivers/acpi/. Hi Arnd, With Tomasz latest PCIe ACPI series (https://lkml.org/lkml/2016/4/15/594), do you think it still better to keep the ACPI ECAM fixup code in a separate file in drivers/acpi directory? Regards, Duc Dang. > > Arnd
Re: [PATCH] pci: xgene: Add ECAM fixups
On Tuesday 09 February 2016 17:49:44 Duc Dang wrote: > X-Gene PCIe controller does not fully support ECAM. > This patch adds required ECAM fixup to allow X-Gene > PCIe controller to be functional in ACPI boot mode. > > This patch is based on the original work of > Mark Salter and depends on > Tomasz's PCIe ACPI series: > https://lkml.org/lkml/2016/2/4/646 > > Signed-off-by: Duc Dang > --- This really has nothing to do with the PCI host device driver, please keep it in a separate file in drivers/acpi/. Arnd
Re: [PATCH] pci: xgene: Add ECAM fixups
On Tuesday 09 February 2016 17:49:44 Duc Dang wrote: > X-Gene PCIe controller does not fully support ECAM. > This patch adds required ECAM fixup to allow X-Gene > PCIe controller to be functional in ACPI boot mode. > > This patch is based on the original work of > Mark Salterand depends on > Tomasz's PCIe ACPI series: > https://lkml.org/lkml/2016/2/4/646 > > Signed-off-by: Duc Dang > --- This really has nothing to do with the PCI host device driver, please keep it in a separate file in drivers/acpi/. Arnd
Re: [PATCH] pci: xgene: Add ECAM fixups
Hi Duc, [auto build test ERROR on pci/next] [also build test ERROR on v4.5-rc3 next-20160209] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Duc-Dang/pci-xgene-Add-ECAM-fixups/20160210-095702 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm64-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64 All errors (new ones prefixed by >>): >> drivers/pci/host/pci-xgene.c:34:24: fatal error: linux/ecam.h: No such file >> or directory #include ^ compilation terminated. vim +34 drivers/pci/host/pci-xgene.c 28 #include 29 #include 30 #include 31 #include 32 #ifdef CONFIG_ACPI 33 #include > 34 #include 35 #include 36 #endif 37 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH] pci: xgene: Add ECAM fixups
Hi Duc, [auto build test ERROR on pci/next] [also build test ERROR on v4.5-rc3 next-20160209] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Duc-Dang/pci-xgene-Add-ECAM-fixups/20160210-095702 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm64-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64 All errors (new ones prefixed by >>): >> drivers/pci/host/pci-xgene.c:34:24: fatal error: linux/ecam.h: No such file >> or directory #include ^ compilation terminated. vim +34 drivers/pci/host/pci-xgene.c 28 #include 29 #include 30 #include 31 #include 32 #ifdef CONFIG_ACPI 33 #include > 34 #include 35 #include 36 #endif 37 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data