Re: [PATCH] perf, tools, record: Support recording running/enabled time

2015-02-25 Thread David Ahern 

On 2/24/15 4:13 PM, Andi Kleen wrote:

--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -241,6 +241,9 @@ Capture machine state (registers) at interrupt, i.e., on 
counter overflows for
  each sample. List of captured registers depends on the architecture. This 
option
  is off by default.

+--running::
+Record running and enabled time for read events (:S)
+
  SEE ALSO
  
  linkperf:perf-stat[1], linkperf:perf-list[1]
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index d0d02a8..4fdad06 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -839,6 +839,8 @@ struct option __record_options[] = {
"use per-thread mmaps"),
OPT_BOOLEAN('I', "intr-regs", &record.opts.sample_intr_regs,
"Sample machine registers on interrupt"),
+   OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
+   "Record running/enabled time of read (:S) events"),
OPT_END()


Documentation differs from option in the record command.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] perf, tools, record: Support recording running/enabled time

2015-02-25 Thread Arnaldo Carvalho de Melo 
Em Wed, Feb 25, 2015 at 04:13:06PM +0100, Jiri Olsa escreveu:
> On Tue, Feb 24, 2015 at 03:13:40PM -0800, Andi Kleen wrote:
> > From: Andi Kleen 
> > 
> > Add an option to perf record to record running/enabled time
> > for read events, similar to what stat does.
> > 
> > This is useful to understand multiplexing problems.
> > 
> > Right now the report support is not great, but at least
> > report -D already supports it.
> 
> yep, report -D displays it nicely
> 
> Acked-by: Jiri Olsa 

Thanks, applied.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] perf, tools, record: Support recording running/enabled time

2015-02-25 Thread Jiri Olsa 
On Tue, Feb 24, 2015 at 03:13:40PM -0800, Andi Kleen wrote:
> From: Andi Kleen 
> 
> Add an option to perf record to record running/enabled time
> for read events, similar to what stat does.
> 
> This is useful to understand multiplexing problems.
> 
> Right now the report support is not great, but at least
> report -D already supports it.

yep, report -D displays it nicely

Acked-by: Jiri Olsa 

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/