Re: [PATCH] perf: fix perf-lock report coredump
On 7/10/12 11:14 PM, Jovi Zhang wrote: Does this fix it for you: http://lkml.org/lkml/2012/7/6/405 Yeah, same problem. But the question is if there have some sample event with raw data in perf.data, are we still just exit(1)? or let perf-lock only report those sample events with raw data? perf-lock uses 4 tracepoints. tracepoints add -R (raw data) to events. So, if the perf.data does not have tracepoints, there is no need for perf-lock info or report subcommands to proceed. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: fix perf-lock report coredump
On 7/10/12 11:14 PM, Jovi Zhang wrote: Does this fix it for you: http://lkml.org/lkml/2012/7/6/405 Yeah, same problem. But the question is if there have some sample event with raw data in perf.data, are we still just exit(1)? or let perf-lock only report those sample events with raw data? perf-lock uses 4 tracepoints. tracepoints add -R (raw data) to events. So, if the perf.data does not have tracepoints, there is no need for perf-lock info or report subcommands to proceed. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: fix perf-lock report coredump
On Wed, Jul 11, 2012 at 10:20 AM, David Ahern wrote: > On 7/10/12 7:06 PM, Jovi Zhang wrote: >> >> From 4b363bf16c12b76788fbace1475123b7214ae58d Mon Sep 17 00:00:00 2001 >> From: Jovi Zhang >> Date: Wed, 11 Jul 2012 16:53:57 +0800 >> Subject: [PATCH] perf: fix perf-lock report coredump >> >> Check sample type event raw_data is existed in perf.data firstly, >> then invoke process_raw_event, otherwise it will coredump. > > > Does this fix it for you: > http://lkml.org/lkml/2012/7/6/405 > Yeah, same problem. But the question is if there have some sample event with raw data in perf.data, are we still just exit(1)? or let perf-lock only report those sample events with raw data? > Also does 'perf lock record' work for you? If so can you send me your kernel > config file? Not working. I assume LOCKDEP is not configured in my test machine. > > Thanks, > > David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: fix perf-lock report coredump
On 7/10/12 7:06 PM, Jovi Zhang wrote: From 4b363bf16c12b76788fbace1475123b7214ae58d Mon Sep 17 00:00:00 2001 From: Jovi Zhang Date: Wed, 11 Jul 2012 16:53:57 +0800 Subject: [PATCH] perf: fix perf-lock report coredump Check sample type event raw_data is existed in perf.data firstly, then invoke process_raw_event, otherwise it will coredump. Does this fix it for you: http://lkml.org/lkml/2012/7/6/405 Also does 'perf lock record' work for you? If so can you send me your kernel config file? Thanks, David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: fix perf-lock report coredump
On 7/10/12 7:06 PM, Jovi Zhang wrote: From 4b363bf16c12b76788fbace1475123b7214ae58d Mon Sep 17 00:00:00 2001 From: Jovi Zhang bookj...@gmail.com Date: Wed, 11 Jul 2012 16:53:57 +0800 Subject: [PATCH] perf: fix perf-lock report coredump Check sample type event raw_data is existed in perf.data firstly, then invoke process_raw_event, otherwise it will coredump. Does this fix it for you: http://lkml.org/lkml/2012/7/6/405 Also does 'perf lock record' work for you? If so can you send me your kernel config file? Thanks, David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: fix perf-lock report coredump
On Wed, Jul 11, 2012 at 10:20 AM, David Ahern dsah...@gmail.com wrote: On 7/10/12 7:06 PM, Jovi Zhang wrote: From 4b363bf16c12b76788fbace1475123b7214ae58d Mon Sep 17 00:00:00 2001 From: Jovi Zhang bookj...@gmail.com Date: Wed, 11 Jul 2012 16:53:57 +0800 Subject: [PATCH] perf: fix perf-lock report coredump Check sample type event raw_data is existed in perf.data firstly, then invoke process_raw_event, otherwise it will coredump. Does this fix it for you: http://lkml.org/lkml/2012/7/6/405 Yeah, same problem. But the question is if there have some sample event with raw data in perf.data, are we still just exit(1)? or let perf-lock only report those sample events with raw data? Also does 'perf lock record' work for you? If so can you send me your kernel config file? Not working. I assume LOCKDEP is not configured in my test machine. Thanks, David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
