Re: [PATCH] perf tools: Use %zd for size_t printf formats on 32b

2020-08-26 Thread Jiri Olsa
On Fri, Aug 21, 2020 at 09:13:10AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 20, 2020 at 10:25:01PM +0100, Chris Wilson escreveu:
> > A couple of trivial fixes for using %zd for size_t.
> 
> Added Jiri and Namhyung, that are perf tooling reviewers, and Alexey
> Budankov, that added the ZSTD code.
> 
> Applied,
> 
> - Arnaldo
>  
> > Signed-off-by: Chris Wilson 
> > Cc: Peter Zijlstra 
> > Cc: Ingo Molnar 
> > cc: Arnaldo Carvalho de Melo 

LGTM

Acked-by: Jiri Olsa 

thanks,
jirka

> > ---
> >  tools/perf/util/session.c | 2 +-
> >  tools/perf/util/zstd.c| 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index ffbc9d35a383..7a5f03764702 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -87,7 +87,7 @@ static int perf_session__process_compressed_event(struct 
> > perf_session *session,
> > session->decomp_last = decomp;
> > }
> >  
> > -   pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
> > +   pr_debug("decomp (B): %zd to %zd\n", src_size, decomp_size);
> >  
> > return 0;
> >  }
> > diff --git a/tools/perf/util/zstd.c b/tools/perf/util/zstd.c
> > index d2202392ffdb..48dd2b018c47 100644
> > --- a/tools/perf/util/zstd.c
> > +++ b/tools/perf/util/zstd.c
> > @@ -99,7 +99,7 @@ size_t zstd_decompress_stream(struct zstd_data *data, 
> > void *src, size_t src_size
> > while (input.pos < input.size) {
> > ret = ZSTD_decompressStream(data->dstream, , );
> > if (ZSTD_isError(ret)) {
> > -   pr_err("failed to decompress (B): %ld -> %ld, dst_size 
> > %ld : %s\n",
> > +   pr_err("failed to decompress (B): %zd -> %zd, dst_size 
> > %zd : %s\n",
> >src_size, output.size, dst_size, 
> > ZSTD_getErrorName(ret));
> > break;
> > }
> > -- 
> > 2.20.1
> > 
> 
> -- 
> 
> - Arnaldo
> 



Re: [PATCH] perf tools: Use %zd for size_t printf formats on 32b

2020-08-21 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 20, 2020 at 10:25:01PM +0100, Chris Wilson escreveu:
> A couple of trivial fixes for using %zd for size_t.

Added Jiri and Namhyung, that are perf tooling reviewers, and Alexey
Budankov, that added the ZSTD code.

Applied,

- Arnaldo
 
> Signed-off-by: Chris Wilson 
> Cc: Peter Zijlstra 
> Cc: Ingo Molnar 
> cc: Arnaldo Carvalho de Melo 
> ---
>  tools/perf/util/session.c | 2 +-
>  tools/perf/util/zstd.c| 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index ffbc9d35a383..7a5f03764702 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -87,7 +87,7 @@ static int perf_session__process_compressed_event(struct 
> perf_session *session,
>   session->decomp_last = decomp;
>   }
>  
> - pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
> + pr_debug("decomp (B): %zd to %zd\n", src_size, decomp_size);
>  
>   return 0;
>  }
> diff --git a/tools/perf/util/zstd.c b/tools/perf/util/zstd.c
> index d2202392ffdb..48dd2b018c47 100644
> --- a/tools/perf/util/zstd.c
> +++ b/tools/perf/util/zstd.c
> @@ -99,7 +99,7 @@ size_t zstd_decompress_stream(struct zstd_data *data, void 
> *src, size_t src_size
>   while (input.pos < input.size) {
>   ret = ZSTD_decompressStream(data->dstream, , );
>   if (ZSTD_isError(ret)) {
> - pr_err("failed to decompress (B): %ld -> %ld, dst_size 
> %ld : %s\n",
> + pr_err("failed to decompress (B): %zd -> %zd, dst_size 
> %zd : %s\n",
>  src_size, output.size, dst_size, 
> ZSTD_getErrorName(ret));
>   break;
>   }
> -- 
> 2.20.1
> 

-- 

- Arnaldo