Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

2021-02-02 Thread Benson Leung
On Tue, Feb 02, 2021 at 05:37:36PM +0100, Greg KH wrote:
> On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote:
> > typec_partner_set_pd_revision returns void now.
> > 
> > Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision 
> > from status
> 
> Can you please use the documented format for the Fixes: tag (and for the
> use of any git id in the kernel changelog)?


D'oh. Thanks. I set up my pretty=fuller now.

Benson
> 
> If anyone were to commit this change, you would get a nasty-gram email
> from linux-next :)
> 
> thanks,
> 
> greg k-h

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org


signature.asc
Description: PGP signature


Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

2021-02-02 Thread Benson Leung
Hi Greg,

On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote:
> typec_partner_set_pd_revision returns void now.
> 
> Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision 
> from status
> Signed-off-by: Benson Leung 

This one needs to be taken too after Kyle's fix earlier this morning.

Thanks,
Benson

> ---
>  drivers/platform/chrome/cros_ec_typec.c | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_typec.c 
> b/drivers/platform/chrome/cros_ec_typec.c
> index a7778258d0a0..7b93dfd02999 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -842,11 +842,7 @@ static int cros_typec_handle_sop_disc(struct 
> cros_typec_data *typec, int port_nu
>   goto disc_exit;
>   }
>  
> - ret = typec_partner_set_pd_revision(port->partner, pd_revision);
> - if (ret < 0) {
> - dev_err(typec->dev, "Failed to update partner PD revision, 
> port: %d\n", port_num);
> - goto disc_exit;
> - }
> + typec_partner_set_pd_revision(port->partner, pd_revision);
>  
>   memset(sop_disc, 0, EC_PROTO2_MAX_RESPONSE_SIZE);
>   ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_DISCOVERY, , 
> sizeof(req),
> -- 
> 2.30.0.365.g02bc693789-goog
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org


signature.asc
Description: PGP signature


Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote:
> typec_partner_set_pd_revision returns void now.
> 
> Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision 
> from status

Can you please use the documented format for the Fixes: tag (and for the
use of any git id in the kernel changelog)?

If anyone were to commit this change, you would get a nasty-gram email
from linux-next :)

thanks,

greg k-h