Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
On 25.07.19 20:57, Andy Shevchenko wrote: On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult wrote: On 25.07.19 19:17, Andy Shevchenko wrote: On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult wrote: From: Enrico Weigelt The keycode KEY_RESTART is more appropriate for the front button, as most people use it for things like restart or factory reset. Should it go as Fixes? I think so. Technically, the feature already worked, but the keycode wasn't semantically fine. Can you provide a Fixes tag? Okay, sent a v2. -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287
Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult wrote: > > On 25.07.19 19:17, Andy Shevchenko wrote: > > On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult > > wrote: > >> > >> From: Enrico Weigelt > >> > >> The keycode KEY_RESTART is more appropriate for the front button, > >> as most people use it for things like restart or factory reset. > >> > > > > Should it go as Fixes? > > I think so. Technically, the feature already worked, but the keycode > wasn't semantically fine. Can you provide a Fixes tag? -- With Best Regards, Andy Shevchenko
Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
On 25.07.19 19:17, Andy Shevchenko wrote: On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult wrote: From: Enrico Weigelt The keycode KEY_RESTART is more appropriate for the front button, as most people use it for things like restart or factory reset. Should it go as Fixes? I think so. Technically, the feature already worked, but the keycode wasn't semantically fine. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287
Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult wrote: > > From: Enrico Weigelt > > The keycode KEY_RESTART is more appropriate for the front button, > as most people use it for things like restart or factory reset. > Should it go as Fixes? > Signed-off-by: Enrico Weigelt > --- > drivers/platform/x86/pcengines-apuv2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/pcengines-apuv2.c > b/drivers/platform/x86/pcengines-apuv2.c > index b0d3110..4138007c 100644 > --- a/drivers/platform/x86/pcengines-apuv2.c > +++ b/drivers/platform/x86/pcengines-apuv2.c > @@ -93,7 +93,7 @@ > > static struct gpio_keys_button apu2_keys_buttons[] = { > { > - .code = KEY_SETUP, > + .code = KEY_RESTART, > .active_low = 1, > .desc = "front button", > .type = EV_KEY, > -- > 1.9.1 > -- With Best Regards, Andy Shevchenko