Re: [PATCH] properly detect ActionTec modem of PCI_CLASS_COMMUNICATION_OTHER

2001-04-24 Thread Steven Walter

On Tue, Apr 24, 2001 at 05:18:36PM -0400, Brian Gerst wrote:
> Steven Walter wrote:
> > 
> > This patch allows the serial driver to properly detect and set up the
> > ActionTec PCI modem.  This modem has a PCI class of COMMUNICATION_OTHER,
> > which is why this modem is not otherwise detected.
> > 
> > Any suggestions on the patch are welcome.  Thanks
> 
> A small suggestion:  Vendor/device id are sufficient to identify the
> device.  You can change PCI_CLASS_COMMUNICATION_OTHER << 8 to 0.

Excellent suggestion.  Follows is the amended patch.  Compiled and
tested to work.  BTW: patch is against 2.4.3.
-- 
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell

--- clean-2.4.3/drivers/char/serial.c   Fri Mar 30 23:15:33 2001
+++ linux/drivers/char/serial.c Tue Apr 24 16:32:02 2001
@@ -4706,6 +4728,8 @@
 
 
 static struct pci_device_id serial_pci_tbl[] __devinitdata = {
+   { PCI_VENDOR_ID_ATT, PCI_DEVICE_ID_ATT_VENUS_MODEM,
+ PCI_ANY_ID, PCI_ANY_ID, },
{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
 PCI_CLASS_COMMUNICATION_SERIAL << 8, 0x00, },
{ 0, }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



Re: [PATCH] properly detect ActionTec modem of PCI_CLASS_COMMUNICATION_OTHER

2001-04-24 Thread Brian Gerst

Steven Walter wrote:
> 
> This patch allows the serial driver to properly detect and set up the
> ActionTec PCI modem.  This modem has a PCI class of COMMUNICATION_OTHER,
> which is why this modem is not otherwise detected.
> 
> Any suggestions on the patch are welcome.  Thanks

A small suggestion:  Vendor/device id are sufficient to identify the
device.  You can change PCI_CLASS_COMMUNICATION_OTHER << 8 to 0.

--

Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/