Re: [PATCH] re-export genapic on i386
Christoph Hellwig <[EMAIL PROTECTED]> writes: > On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote: > > (Note: Patch also attached because the inline version is certain to get > > line wrapped.) > > > > A change not too long ago made i386's genapic symbol no longer be > > exported, > > and thus certain low-level functions no longer be usable. Since > > close-to- > > the-hardware code may still be modular, this rectifies the situation. > > Again, what code would use it, why and why can't it use a proper accessor. > And a shitty thousands of lines out ot tree debugger ported from Novell's > legacy OS is not the answer, btw. Why not? Most debuggers will always be out of tree for political reasons, and because of that the normal "every hook must have an in tree user" rule cannot be strictly applied to them. It's also not reasonable to ask these people to always carry big patchkits around - after all they just want to debug core kernel code, and it is very ugly to apply a big patchkit just for that. So as long as the hooks for external modular debuggers are reasonable and _GPL I think they should be merged. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] re-export genapic on i386
On Thu, 8 Sep 2005, Jan Beulich wrote: > (Note: Patch also attached because the inline version is certain to get > line wrapped.) > > A change not too long ago made i386's genapic symbol no longer be > exported, > and thus certain low-level functions no longer be usable. Since > close-to- > the-hardware code may still be modular, this rectifies the situation. > > Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> Since there are no in-kernel tree users of this, i suggest that you keep it as a seperate patch, and generally for all exports that you may require for your external work. Then when/if your work gets merged you can submit it. Thanks, Zwane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] re-export genapic on i386
On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote: > (Note: Patch also attached because the inline version is certain to get > line wrapped.) > > A change not too long ago made i386's genapic symbol no longer be > exported, > and thus certain low-level functions no longer be usable. Since > close-to- > the-hardware code may still be modular, this rectifies the situation. Again, what code would use it, why and why can't it use a proper accessor. And a shitty thousands of lines out ot tree debugger ported from Novell's legacy OS is not the answer, btw. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] re-export genapic on i386
On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote: (Note: Patch also attached because the inline version is certain to get line wrapped.) A change not too long ago made i386's genapic symbol no longer be exported, and thus certain low-level functions no longer be usable. Since close-to- the-hardware code may still be modular, this rectifies the situation. Again, what code would use it, why and why can't it use a proper accessor. And a shitty thousands of lines out ot tree debugger ported from Novell's legacy OS is not the answer, btw. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] re-export genapic on i386
On Thu, 8 Sep 2005, Jan Beulich wrote: (Note: Patch also attached because the inline version is certain to get line wrapped.) A change not too long ago made i386's genapic symbol no longer be exported, and thus certain low-level functions no longer be usable. Since close-to- the-hardware code may still be modular, this rectifies the situation. Signed-off-by: Jan Beulich [EMAIL PROTECTED] Since there are no in-kernel tree users of this, i suggest that you keep it as a seperate patch, and generally for all exports that you may require for your external work. Then when/if your work gets merged you can submit it. Thanks, Zwane - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] re-export genapic on i386
Christoph Hellwig [EMAIL PROTECTED] writes: On Thu, Sep 08, 2005 at 05:47:34PM +0200, Jan Beulich wrote: (Note: Patch also attached because the inline version is certain to get line wrapped.) A change not too long ago made i386's genapic symbol no longer be exported, and thus certain low-level functions no longer be usable. Since close-to- the-hardware code may still be modular, this rectifies the situation. Again, what code would use it, why and why can't it use a proper accessor. And a shitty thousands of lines out ot tree debugger ported from Novell's legacy OS is not the answer, btw. Why not? Most debuggers will always be out of tree for political reasons, and because of that the normal every hook must have an in tree user rule cannot be strictly applied to them. It's also not reasonable to ask these people to always carry big patchkits around - after all they just want to debug core kernel code, and it is very ugly to apply a big patchkit just for that. So as long as the hooks for external modular debuggers are reasonable and _GPL I think they should be merged. -Andi - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
