Re: [PATCH] remove i386 dynamic ticks ifdefs
On Tue, 1 Jan 2002 21:33, Pavel Machek wrote: > Hi! > > > I assume you're maintaining the dyn tick patches for i386 posted on the > > muru website as your email is listed there. I thought you might be > > interested in this patch for dyn-ticks which removes most of the #ifdefs > > out of common code paths as per linux kernel style and moves more code > > into dyn-tick.c. Most of it is straight forward code reorganisation, but > > to keep do_timer_interrupt inlined I'd have to move it's code around > > somewhat. That may be a better option but I've tried to fiddle with the > > mainline code as little as possible. > > > > Patch applies to 2.6.12 with patch-dynamic-tick-2.6.12-rc6-050610-1 > > applied > > > > cc'ed lkml just for public record of the patch. > > Please inline patches... Not everyone uses console email clients :| It was an inlined attachment rather than an ordinary attachment but clearly that doesn't suit those with console clients. I'm sorry. > > You broke indentation in one of first hunks, and you probably > want empty functions to be static inline, so that we do not eat > function call overhead. Will examine. Thanks very much for your code comments! Cheers, Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] remove i386 dynamic ticks ifdefs
Hi! > I assume you're maintaining the dyn tick patches for i386 posted on the muru > website as your email is listed there. I thought you might be interested in > this patch for dyn-ticks which removes most of the #ifdefs out of common code > paths as per linux kernel style and moves more code into dyn-tick.c. Most of > it is straight forward code reorganisation, but to keep do_timer_interrupt > inlined I'd have to move it's code around somewhat. That may be a better > option but I've tried to fiddle with the mainline code as little as possible. > > Patch applies to 2.6.12 with patch-dynamic-tick-2.6.12-rc6-050610-1 applied > > cc'ed lkml just for public record of the patch. Please inline patches... You broke indentation in one of first hunks, and you probably want empty functions to be static inline, so that we do not eat function call overhead. Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] remove i386 dynamic ticks ifdefs
Hi! I assume you're maintaining the dyn tick patches for i386 posted on the muru website as your email is listed there. I thought you might be interested in this patch for dyn-ticks which removes most of the #ifdefs out of common code paths as per linux kernel style and moves more code into dyn-tick.c. Most of it is straight forward code reorganisation, but to keep do_timer_interrupt inlined I'd have to move it's code around somewhat. That may be a better option but I've tried to fiddle with the mainline code as little as possible. Patch applies to 2.6.12 with patch-dynamic-tick-2.6.12-rc6-050610-1 applied cc'ed lkml just for public record of the patch. Please inline patches... You broke indentation in one of first hunks, and you probably want empty functions to be static inline, so that we do not eat function call overhead. Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] remove i386 dynamic ticks ifdefs
On Tue, 1 Jan 2002 21:33, Pavel Machek wrote: Hi! I assume you're maintaining the dyn tick patches for i386 posted on the muru website as your email is listed there. I thought you might be interested in this patch for dyn-ticks which removes most of the #ifdefs out of common code paths as per linux kernel style and moves more code into dyn-tick.c. Most of it is straight forward code reorganisation, but to keep do_timer_interrupt inlined I'd have to move it's code around somewhat. That may be a better option but I've tried to fiddle with the mainline code as little as possible. Patch applies to 2.6.12 with patch-dynamic-tick-2.6.12-rc6-050610-1 applied cc'ed lkml just for public record of the patch. Please inline patches... Not everyone uses console email clients :| It was an inlined attachment rather than an ordinary attachment but clearly that doesn't suit those with console clients. I'm sorry. You broke indentation in one of first hunks, and you probably want empty functions to be static inline, so that we do not eat function call overhead. Will examine. Thanks very much for your code comments! Cheers, Con - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
