Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc

2019-08-07 Thread Martin K. Petersen


Colin,

> There are several occasions where variable rc is being initialized
> with a value that is never read and error is being re-assigned a
> little later on.  Clean up the code by removing rc entirely and
> just returning the return value from the call to pm8001_issue_ssp_tmf

Applied to 5.4/scsi-queue. Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering


Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc

2019-08-01 Thread Jinpu Wang
On Thu, Aug 1, 2019 at 12:22 AM Colin King  wrote:
>
> From: Colin Ian King 
>
> There are several occasions where variable rc is being initialized
> with a value that is never read and error is being re-assigned a
> little later on.  Clean up the code by removing rc entirely and
> just returning the return value from the call to pm8001_issue_ssp_tmf
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King 
Acked-by: Jack Wang 

Thanks, Colin.