Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Wed, Dec 19, 2012 at 05:00:09PM +, Grant Likely wrote: > On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding > wrote: > > On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: > > > On 11/09/2012 10:10 AM, Mark Brown wrote: > > > > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: > > > > > > > >> However just FYI, it should not be necessary for correctness; The > > > >> DT matching order is supposed to be driven purely by the order of > > > >> the compatible values in the DT now, and not affected by the > > > >> order of values in the table. (This wasn't always the case, but > > > >> was a bug that was fixed IIRC by Thierry Reding). > > > > > > > > I guess the driver is being used backported in older kernels which > > > > don't have that fix? > > > > > > That sounds likely. Laxman, it'd be a good idea to track down the fix > > > to the DT matching code and backport it, so that hard-to debug issues > > > aren't caused by the lack of that patch! > > > > Unfortunately the patch that was supposed to fixed this caused a > > regression and was therefore reverted. Rob (Cc'ed) said there was a > > patch to fix it properly and was supposed to go into 3.6 but it seems > > that never happened. Rob, what's the status on this? > > > > The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478 > > Rob, ping on this. I think we talked about it on IRC, but I cannot > remember what was said I must be getting old. Any news on this one? Thierry pgp7Q58srmxfA.pgp Description: PGP signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Wed, Dec 19, 2012 at 05:00:09PM +, Grant Likely wrote: On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding thierry.red...@avionic-design.de wrote: On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: On 11/09/2012 10:10 AM, Mark Brown wrote: On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). I guess the driver is being used backported in older kernels which don't have that fix? That sounds likely. Laxman, it'd be a good idea to track down the fix to the DT matching code and backport it, so that hard-to debug issues aren't caused by the lack of that patch! Unfortunately the patch that was supposed to fixed this caused a regression and was therefore reverted. Rob (Cc'ed) said there was a patch to fix it properly and was supposed to go into 3.6 but it seems that never happened. Rob, what's the status on this? The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478 Rob, ping on this. I think we talked about it on IRC, but I cannot remember what was said I must be getting old. Any news on this one? Thierry pgp7Q58srmxfA.pgp Description: PGP signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding wrote: > On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: > > On 11/09/2012 10:10 AM, Mark Brown wrote: > > > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: > > > > > >> However just FYI, it should not be necessary for correctness; The > > >> DT matching order is supposed to be driven purely by the order of > > >> the compatible values in the DT now, and not affected by the > > >> order of values in the table. (This wasn't always the case, but > > >> was a bug that was fixed IIRC by Thierry Reding). > > > > > > I guess the driver is being used backported in older kernels which > > > don't have that fix? > > > > That sounds likely. Laxman, it'd be a good idea to track down the fix > > to the DT matching code and backport it, so that hard-to debug issues > > aren't caused by the lack of that patch! > > Unfortunately the patch that was supposed to fixed this caused a > regression and was therefore reverted. Rob (Cc'ed) said there was a > patch to fix it properly and was supposed to go into 3.6 but it seems > that never happened. Rob, what's the status on this? > > The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478 Rob, ping on this. I think we talked about it on IRC, but I cannot remember what was said I must be getting old. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Sat, 10 Nov 2012 18:07:42 +0100, Thierry Reding thierry.red...@avionic-design.de wrote: On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: On 11/09/2012 10:10 AM, Mark Brown wrote: On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). I guess the driver is being used backported in older kernels which don't have that fix? That sounds likely. Laxman, it'd be a good idea to track down the fix to the DT matching code and backport it, so that hard-to debug issues aren't caused by the lack of that patch! Unfortunately the patch that was supposed to fixed this caused a regression and was therefore reverted. Rob (Cc'ed) said there was a patch to fix it properly and was supposed to go into 3.6 but it seems that never happened. Rob, what's the status on this? The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478 Rob, ping on this. I think we talked about it on IRC, but I cannot remember what was said I must be getting old. g. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: > On 11/09/2012 10:10 AM, Mark Brown wrote: > > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: > > > >> However just FYI, it should not be necessary for correctness; The > >> DT matching order is supposed to be driven purely by the order of > >> the compatible values in the DT now, and not affected by the > >> order of values in the table. (This wasn't always the case, but > >> was a bug that was fixed IIRC by Thierry Reding). > > > > I guess the driver is being used backported in older kernels which > > don't have that fix? > > That sounds likely. Laxman, it'd be a good idea to track down the fix > to the DT matching code and backport it, so that hard-to debug issues > aren't caused by the lack of that patch! Unfortunately the patch that was supposed to fixed this caused a regression and was therefore reverted. Rob (Cc'ed) said there was a patch to fix it properly and was supposed to go into 3.6 but it seems that never happened. Rob, what's the status on this? The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478 Thierry pgpksoHuxEsub.pgp Description: PGP signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote: On 11/09/2012 10:10 AM, Mark Brown wrote: On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). I guess the driver is being used backported in older kernels which don't have that fix? That sounds likely. Laxman, it'd be a good idea to track down the fix to the DT matching code and backport it, so that hard-to debug issues aren't caused by the lack of that patch! Unfortunately the patch that was supposed to fixed this caused a regression and was therefore reverted. Rob (Cc'ed) said there was a patch to fix it properly and was supposed to go into 3.6 but it seems that never happened. Rob, what's the status on this? The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478 Thierry pgpksoHuxEsub.pgp Description: PGP signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On 11/09/2012 10:10 AM, Mark Brown wrote: > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: > >> However just FYI, it should not be necessary for correctness; The >> DT matching order is supposed to be driven purely by the order of >> the compatible values in the DT now, and not affected by the >> order of values in the table. (This wasn't always the case, but >> was a bug that was fixed IIRC by Thierry Reding). > > I guess the driver is being used backported in older kernels which > don't have that fix? That sounds likely. Laxman, it'd be a good idea to track down the fix to the DT matching code and backport it, so that hard-to debug issues aren't caused by the lack of that patch! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: > However just FYI, it should not be necessary for correctness; The DT > matching order is supposed to be driven purely by the order of the > compatible values in the DT now, and not affected by the order of values > in the table. (This wasn't always the case, but was a bug that was fixed > IIRC by Thierry Reding). I guess the driver is being used backported in older kernels which don't have that fix? signature.asc Description: Digital signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On 11/09/2012 02:07 AM, Laxman Dewangan wrote: > Sequence compatible list for tegra20-slink driver to first > look for Tegra30 and then Tegra20. Tegra30 have additional > feature in HW which need to be utilize if it is provided from DT. I don't object to this patch. However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Fri, Nov 09, 2012 at 02:37:32PM +0530, Laxman Dewangan wrote: > Sequence compatible list for tegra20-slink driver to first > look for Tegra30 and then Tegra20. Tegra30 have additional > feature in HW which need to be utilize if it is provided from DT. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Fri, Nov 09, 2012 at 02:37:32PM +0530, Laxman Dewangan wrote: Sequence compatible list for tegra20-slink driver to first look for Tegra30 and then Tegra20. Tegra30 have additional feature in HW which need to be utilize if it is provided from DT. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On 11/09/2012 02:07 AM, Laxman Dewangan wrote: Sequence compatible list for tegra20-slink driver to first look for Tegra30 and then Tegra20. Tegra30 have additional feature in HW which need to be utilize if it is provided from DT. I don't object to this patch. However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). I guess the driver is being used backported in older kernels which don't have that fix? signature.asc Description: Digital signature
Re: [PATCH] spi: tegra: sequence compatible strings as per preference
On 11/09/2012 10:10 AM, Mark Brown wrote: On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote: However just FYI, it should not be necessary for correctness; The DT matching order is supposed to be driven purely by the order of the compatible values in the DT now, and not affected by the order of values in the table. (This wasn't always the case, but was a bug that was fixed IIRC by Thierry Reding). I guess the driver is being used backported in older kernels which don't have that fix? That sounds likely. Laxman, it'd be a good idea to track down the fix to the DT matching code and backport it, so that hard-to debug issues aren't caused by the lack of that patch! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
