Re: [PATCH] staging: greybus: control.c: fixed some coding style issues
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote: > fixed some "Alignment should match open parenthesis" checks. > Signing up for the kernel clean up crew while I learn C > > Signed-off-by: Aaron Williams > --- > drivers/staging/greybus/control.c | 39 +++ > 1 file changed, 19 insertions(+), 20 deletions(-) > > diff --git a/drivers/staging/greybus/control.c > b/drivers/staging/greybus/control.c > index 35f945a12b11..f8f0aee224c8 100644 > --- a/drivers/staging/greybus/control.c > +++ b/drivers/staging/greybus/control.c > @@ -15,7 +15,6 @@ > #define GB_CONTROL_VERSION_MAJOR 0 > #define GB_CONTROL_VERSION_MINOR 1 > > - This change does not match your changelog text :(
Re: [PATCH] staging: greybus: control.c: fixed some coding style issues
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote: > fixed some "Alignment should match open parenthesis" checks. > Signing up for the kernel clean up crew while I learn C > > Signed-off-by: Aaron Williams > --- > drivers/staging/greybus/control.c | 39 +++ > 1 file changed, 19 insertions(+), 20 deletions(-) > > diff --git a/drivers/staging/greybus/control.c > b/drivers/staging/greybus/control.c > index 35f945a12b11..f8f0aee224c8 100644 > --- a/drivers/staging/greybus/control.c > +++ b/drivers/staging/greybus/control.c > @@ -15,7 +15,6 @@ > #define GB_CONTROL_VERSION_MAJOR 0 > #define GB_CONTROL_VERSION_MINOR 1 > > - This change does not match your changelog text :(
Re: [PATCH] staging: greybus: control.c: fixed some coding style issues
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote: > fixed some "Alignment should match open parenthesis" checks. Note that this is not something that is mandated by the kernel coding style, but rather a preference of the authors of checkpatch (and the check is only enabled when the --strict option is given or when checkpatch is run on net and staging code). As the author and maintainer of this particular code, I do not think this patch should be applied, but Greg may have a different opinion on this as the overall staging maintainer. > Signing up for the kernel clean up crew while I learn C I would strongly suggest learning C *before* moving on to do kernel work. Thanks, Johan
Re: [PATCH] staging: greybus: control.c: fixed some coding style issues
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote: > fixed some "Alignment should match open parenthesis" checks. Note that this is not something that is mandated by the kernel coding style, but rather a preference of the authors of checkpatch (and the check is only enabled when the --strict option is given or when checkpatch is run on net and staging code). As the author and maintainer of this particular code, I do not think this patch should be applied, but Greg may have a different opinion on this as the overall staging maintainer. > Signing up for the kernel clean up crew while I learn C I would strongly suggest learning C *before* moving on to do kernel work. Thanks, Johan
