Re: [PATCH] staging: media: imx: drop dependency on ipuv3

2020-12-02 Thread Hans Verkuil
On 09/11/2020 10:13, Martin Kepplinger wrote:
> As described in NXPs' linux tree, the imx8m SoC includes the same
> CSI bridge hardware that is part of imx7d. We should be able to
> use the "fsl,imx7-csi" driver for imx8m directly.
> 
> Since ipuv3 is not relevant for imx8m, drop the build dependency
> for it.
> 
> Signed-off-by: Martin Kepplinger 
> ---
>  drivers/staging/media/imx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/imx/Kconfig 
> b/drivers/staging/media/imx/Kconfig
> index f555aac8a9d5..98272fd92fe4 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -2,7 +2,7 @@
>  config VIDEO_IMX_MEDIA
>   tristate "i.MX5/6 V4L2 media core driver"

Isn't this text rather out of date if imx7 & 8 are also supported?

Something to fix for the next version...

Regards,

Hans

>   depends on ARCH_MXC || COMPILE_TEST
> - depends on VIDEO_V4L2 && IMX_IPUV3_CORE
> + depends on VIDEO_V4L2
>   select MEDIA_CONTROLLER
>   select VIDEO_V4L2_SUBDEV_API
>   depends on HAS_DMA
> 



Re: [PATCH] staging: media: imx: drop dependency on ipuv3

2020-11-09 Thread Philipp Zabel
Hi Martin,

On Mon, 2020-11-09 at 10:13 +0100, Martin Kepplinger wrote:
> As described in NXPs' linux tree, the imx8m SoC includes the same
> CSI bridge hardware that is part of imx7d. We should be able to
> use the "fsl,imx7-csi" driver for imx8m directly.
> 
> Since ipuv3 is not relevant for imx8m, drop the build dependency
> for it.
> 
> Signed-off-by: Martin Kepplinger 
> ---
>  drivers/staging/media/imx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/imx/Kconfig 
> b/drivers/staging/media/imx/Kconfig
> index f555aac8a9d5..98272fd92fe4 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -2,7 +2,7 @@
>  config VIDEO_IMX_MEDIA
>   tristate "i.MX5/6 V4L2 media core driver"

VIDEO_IMX_MEDIA builds imx6-media, which does depend on IMX_IPUV3_CORE.
You only want imx-media-common. I think we have to split the
configuration option in two.

>   depends on ARCH_MXC || COMPILE_TEST
> - depends on VIDEO_V4L2 && IMX_IPUV3_CORE
> + depends on VIDEO_V4L2
>   select MEDIA_CONTROLLER
>   select VIDEO_V4L2_SUBDEV_API
>   depends on HAS_DMA

regards
Philipp