Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

2021-04-14 Thread Hans Verkuil 
On 13/04/2021 20:21, ascordeiro wrote:
> Em ter, 2021-04-13 às 17:06 +0200, Hans Verkuil escreveu:
>> On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
>>> Remove unused macro functions "to_iss_device()", "to_device()",
>>> and "v4l2_dev_to_iss_device(dev)".
>>
>> 'git grep to_iss_device drivers/staging/omap4iss' gives me lots of
>> hits!
>> Same for to_device. Only v4l2_dev_to_iss_device appears to be unused.
>>
>> Regards,
>>
>> Hans
>>
> This command is really helpful, I didin't know. 
> Thank you for the tip.
> 
> May I send a v2 removing just v4l2_dev_to_iss_device?

Sure, that's fine.

Regards,

Hans

> 
> Thank you in advance,
> Aline
> 
>>>
>>> Signed-off-by: Aline Santana Cordeiro <
>>> alinesantanacorde...@gmail.com>
>>> ---
>>>  drivers/staging/media/omap4iss/iss.h | 8 
>>>  1 file changed, 8 deletions(-)
>>>
>>> diff --git a/drivers/staging/media/omap4iss/iss.h
>>> b/drivers/staging/media/omap4iss/iss.h
>>> index b88f952..a354d5f 100644
>>> --- a/drivers/staging/media/omap4iss/iss.h
>>> +++ b/drivers/staging/media/omap4iss/iss.h
>>> @@ -29,11 +29,6 @@
>>>  
>>>  struct regmap;
>>>  
>>> -#define to_iss_device(ptr_module)  \
>>> -   container_of(ptr_module, struct iss_device, ptr_module)
>>> -#define
>>> to_device(ptr_module)  \
>>> -   (to_iss_device(ptr_module)->dev)
>>> -
>>>  enum iss_mem_resources {
>>> OMAP4_ISS_MEM_TOP,
>>> OMAP4_ISS_MEM_CSI2_A_REGS1,
>>> @@ -119,9 +114,6 @@ struct iss_device {
>>> unsigned int isp_subclk_resources;
>>>  };
>>>  
>>> -#define v4l2_dev_to_iss_device(dev) \
>>> -   container_of(dev, struct iss_device, v4l2_dev)
>>> -
>>>  int omap4iss_get_external_info(struct iss_pipeline *pipe,
>>>    struct media_link *link);
>>>  
>>>
>>
> 
>

Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

2021-04-13 Thread ascordeiro 
Em ter, 2021-04-13 às 17:06 +0200, Hans Verkuil escreveu:
> On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
> > Remove unused macro functions "to_iss_device()", "to_device()",
> > and "v4l2_dev_to_iss_device(dev)".
> 
> 'git grep to_iss_device drivers/staging/omap4iss' gives me lots of
> hits!
> Same for to_device. Only v4l2_dev_to_iss_device appears to be unused.
> 
> Regards,
> 
> Hans
> 
This command is really helpful, I didin't know. 
Thank you for the tip.

May I send a v2 removing just v4l2_dev_to_iss_device?

Thank you in advance,
Aline

> > 
> > Signed-off-by: Aline Santana Cordeiro <
> > alinesantanacorde...@gmail.com>
> > ---
> >  drivers/staging/media/omap4iss/iss.h | 8 
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/staging/media/omap4iss/iss.h
> > b/drivers/staging/media/omap4iss/iss.h
> > index b88f952..a354d5f 100644
> > --- a/drivers/staging/media/omap4iss/iss.h
> > +++ b/drivers/staging/media/omap4iss/iss.h
> > @@ -29,11 +29,6 @@
> >  
> >  struct regmap;
> >  
> > -#define to_iss_device(ptr_module)  \
> > -   container_of(ptr_module, struct iss_device, ptr_module)
> > -#define
> > to_device(ptr_module)  \
> > -   (to_iss_device(ptr_module)->dev)
> > -
> >  enum iss_mem_resources {
> > OMAP4_ISS_MEM_TOP,
> > OMAP4_ISS_MEM_CSI2_A_REGS1,
> > @@ -119,9 +114,6 @@ struct iss_device {
> > unsigned int isp_subclk_resources;
> >  };
> >  
> > -#define v4l2_dev_to_iss_device(dev) \
> > -   container_of(dev, struct iss_device, v4l2_dev)
> > -
> >  int omap4iss_get_external_info(struct iss_pipeline *pipe,
> >    struct media_link *link);
> >  
> > 
>

Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

2021-04-13 Thread Hans Verkuil 
On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
> Remove unused macro functions "to_iss_device()", "to_device()",
> and "v4l2_dev_to_iss_device(dev)".

'git grep to_iss_device drivers/staging/omap4iss' gives me lots of hits!
Same for to_device. Only v4l2_dev_to_iss_device appears to be unused.

Regards,

Hans

> 
> Signed-off-by: Aline Santana Cordeiro 
> ---
>  drivers/staging/media/omap4iss/iss.h | 8 
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss.h 
> b/drivers/staging/media/omap4iss/iss.h
> index b88f952..a354d5f 100644
> --- a/drivers/staging/media/omap4iss/iss.h
> +++ b/drivers/staging/media/omap4iss/iss.h
> @@ -29,11 +29,6 @@
>  
>  struct regmap;
>  
> -#define to_iss_device(ptr_module)\
> - container_of(ptr_module, struct iss_device, ptr_module)
> -#define to_device(ptr_module)
> \
> - (to_iss_device(ptr_module)->dev)
> -
>  enum iss_mem_resources {
>   OMAP4_ISS_MEM_TOP,
>   OMAP4_ISS_MEM_CSI2_A_REGS1,
> @@ -119,9 +114,6 @@ struct iss_device {
>   unsigned int isp_subclk_resources;
>  };
>  
> -#define v4l2_dev_to_iss_device(dev) \
> - container_of(dev, struct iss_device, v4l2_dev)
> -
>  int omap4iss_get_external_info(struct iss_pipeline *pipe,
>  struct media_link *link);
>  
>

Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

2021-04-12 Thread kernel test robot 
Hi Aline,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:
https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/staging-media-omap4iss-Remove-unused-macro-functions/20210412-214331
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 
f2f560e1bdc055a6a306e6b7823ba589794e6564
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# 
https://github.com/0day-ci/linux/commit/6cadf4b043c1d68e2afb77278b7d0deaee3a5222
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
Aline-Santana-Cordeiro/staging-media-omap4iss-Remove-unused-macro-functions/20210412-214331
git checkout 6cadf4b043c1d68e2afb77278b7d0deaee3a5222
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot 

All error/warnings (new ones prefixed by >>):

   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_print_status':
>> drivers/staging/media/omap4iss/iss_ipipeif.c:51:27: error: implicit 
>> declaration of function 'to_iss_device'; did you mean 'to_spi_device'? 
>> [-Werror=implicit-function-declaration]
  51 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
 |   to_spi_device
>> drivers/staging/media/omap4iss/iss_ipipeif.c:51:27: warning: initialization 
>> of 'struct iss_device *' from 'int' makes pointer from integer without a 
>> cast [-Wint-conversion]
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_write_enable':
   drivers/staging/media/omap4iss/iss_ipipeif.c:80:27: warning: initialization 
of 'struct iss_device *' from 'int' makes pointer from integer without a cast 
[-Wint-conversion]
  80 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 'ipipeif_enable':
   drivers/staging/media/omap4iss/iss_ipipeif.c:93:27: warning: initialization 
of 'struct iss_device *' from 'int' makes pointer from integer without a cast 
[-Wint-conversion]
  93 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_set_outaddr':
   drivers/staging/media/omap4iss/iss_ipipeif.c:112:27: warning: initialization 
of 'struct iss_device *' from 'int' makes pointer from integer without a cast 
[-Wint-conversion]
 112 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_configure':
   drivers/staging/media/omap4iss/iss_ipipeif.c:123:27: warning: initialization 
of 'struct iss_device *' from 'int' makes pointer from integer without a cast 
[-Wint-conversion]
 123 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_set_stream':
   drivers/staging/media/omap4iss/iss_ipipeif.c:305:27: warning: initialization 
of 'struct iss_device *' from 'int' makes pointer from integer without a cast 
[-Wint-conversion]
 305 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_link_setup':
   drivers/staging/media/omap4iss/iss_ipipeif.c:660:27: warning: initialization 
of 'struct iss_device *' from 'int' makes pointer from integer without a cast 
[-Wint-conversion]
 660 |  struct iss_device *iss = to_iss_device(ipipeif);
 |   ^
   drivers/staging/media/omap4iss/iss_ipipeif.c: In function 
'ipipeif_init_entities':
>> drivers/staging/media/omap4iss/iss_ipipeif.c:755:25: warning: assignment to 
>> 'struct iss_device *' from 'int' makes pointer from integer without a cast 
>> [-Wint-conversion]
 755 |  ipipeif->video_out.iss = to_iss_device(ipipeif);
 | ^
   cc1: some warnings being treated as errors
--
   drivers/staging/media/omap4iss/iss_ipipe.c: In function 'ipipe_print_status':
>> drivers/staging/media/omap4iss/iss_ipipe.c:47:27: error: implicit 
>> declaration of function 'to_iss_device'; did you mean 'to_spi_device'? 
>> [-Werror=implicit-function-declaration]
  47 |  struct iss_device *iss = to_iss_device(ipipe);
 |   ^
 |   to_spi_device
>>