Re: [PATCH] tty: not call tty close in fallback
On Mon, Jan 14, 2019 at 02:56:01PM +0800, yes wrote: > From: Li RongQing > > when fail to open tty, tty is not in open status and not need > to call close > > Signed-off-by: Li RongQing > --- > drivers/tty/serdev/serdev-ttyport.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/serdev/serdev-ttyport.c > b/drivers/tty/serdev/serdev-ttyport.c > index fa1672993b4c..bcc1e27d00de 100644 > --- a/drivers/tty/serdev/serdev-ttyport.c > +++ b/drivers/tty/serdev/serdev-ttyport.c > @@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl) > > ret = tty->ops->open(serport->tty, NULL); > if (ret) > - goto err_close; > + goto err_unlock; > > tty_unlock(serport->tty); > > @@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl) > > return 0; > > -err_close: > - tty->ops->close(tty, NULL); No, close is always called after open, even if open fails. thanks, greg k-h
Re: [PATCH] tty: not call tty close in fallback
y...@hpe.com: 550 5.1.1 User Unknown You are sending e-mails/patches from a non-existant address? On 14. 01. 19, 7:56, y...@hpe.com wrote: > From: Li RongQing > > when fail to open tty, tty is not in open status and not need > to call close But tty drivers are special and expect close even on failed open, right? See tty_open. > Signed-off-by: Li RongQing > --- > drivers/tty/serdev/serdev-ttyport.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/serdev/serdev-ttyport.c > b/drivers/tty/serdev/serdev-ttyport.c > index fa1672993b4c..bcc1e27d00de 100644 > --- a/drivers/tty/serdev/serdev-ttyport.c > +++ b/drivers/tty/serdev/serdev-ttyport.c > @@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl) > > ret = tty->ops->open(serport->tty, NULL); > if (ret) > - goto err_close; > + goto err_unlock; > > tty_unlock(serport->tty); > > @@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl) > > return 0; > > -err_close: > - tty->ops->close(tty, NULL); > err_unlock: > tty_unlock(tty); > tty_release_struct(tty, serport->tty_idx); > thanks, -- js suse labs
Re: [PATCH] tty: not call tty close in fallback
On 14. 01. 19, 7:56, y...@hpe.com wrote: > From: Li RongQing > > when fail to open tty, tty is not in open status and not need > to call close But tty drivers are special and expect close even on failed open, right? See tty_open. > Signed-off-by: Li RongQing > --- > drivers/tty/serdev/serdev-ttyport.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/serdev/serdev-ttyport.c > b/drivers/tty/serdev/serdev-ttyport.c > index fa1672993b4c..bcc1e27d00de 100644 > --- a/drivers/tty/serdev/serdev-ttyport.c > +++ b/drivers/tty/serdev/serdev-ttyport.c > @@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl) > > ret = tty->ops->open(serport->tty, NULL); > if (ret) > - goto err_close; > + goto err_unlock; > > tty_unlock(serport->tty); > > @@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl) > > return 0; > > -err_close: > - tty->ops->close(tty, NULL); > err_unlock: > tty_unlock(tty); > tty_release_struct(tty, serport->tty_idx); > thanks, -- js suse labs
