Re: [PATCH] usb: musb: Fix format specifier warning
On Sat, Jun 1, 2013 at 8:11 PM, Emil Goode wrote: > Thank's for your pointers. > I will send a patch that applies on top of Felipe's patch. I guess there is not much sense to do that since Felipe applied your patch already. Just keep in mind the hint for future changes. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
Hello, Thank's for your pointers. I will send a patch that applies on top of Felipe's patch. Best regards, Emil Goode On Sat, Jun 01, 2013 at 04:15:03PM +0300, Andy Shevchenko wrote: > On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > > On 05/31/13 15:34, Andy Shevchenko wrote: > >> On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: > >>> This patch fixes a format specifier warning. dma_addr_t can be either > >>> u32 or u64 so we should cast to the largest type and change the format > >>> specifier to %llx. > >> > >> dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier > >> which is available from v3.8(?). > >> > >> Something like this: > >> dma_addr_t src_addr; > >> dev_dbg(dev, "DMA addr: %pa\n", src_addr); > > > > Isn't that: > > > > deb_dbg(dev, "DMA addr: %pa\n", _addr); > > It's. > You are right. > > -- > With Best Regards, > Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > On 05/31/13 15:34, Andy Shevchenko wrote: >> On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >>> This patch fixes a format specifier warning. dma_addr_t can be either >>> u32 or u64 so we should cast to the largest type and change the format >>> specifier to %llx. >> >> dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier >> which is available from v3.8(?). >> >> Something like this: >> dma_addr_t src_addr; >> dev_dbg(dev, "DMA addr: %pa\n", src_addr); > > Isn't that: > > deb_dbg(dev, "DMA addr: %pa\n", _addr); It's. You are right. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap rdun...@infradead.org wrote: On 05/31/13 15:34, Andy Shevchenko wrote: On Fri, May 31, 2013 at 11:22 PM, Emil Goode emilgo...@gmail.com wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is available from v3.8(?). Something like this: dma_addr_t src_addr; dev_dbg(dev, DMA addr: %pa\n, src_addr); Isn't that: deb_dbg(dev, DMA addr: %pa\n, src_addr); It's. You are right. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
Hello, Thank's for your pointers. I will send a patch that applies on top of Felipe's patch. Best regards, Emil Goode On Sat, Jun 01, 2013 at 04:15:03PM +0300, Andy Shevchenko wrote: On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap rdun...@infradead.org wrote: On 05/31/13 15:34, Andy Shevchenko wrote: On Fri, May 31, 2013 at 11:22 PM, Emil Goode emilgo...@gmail.com wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is available from v3.8(?). Something like this: dma_addr_t src_addr; dev_dbg(dev, DMA addr: %pa\n, src_addr); Isn't that: deb_dbg(dev, DMA addr: %pa\n, src_addr); It's. You are right. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On Sat, Jun 1, 2013 at 8:11 PM, Emil Goode emilgo...@gmail.com wrote: Thank's for your pointers. I will send a patch that applies on top of Felipe's patch. I guess there is not much sense to do that since Felipe applied your patch already. Just keep in mind the hint for future changes. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On 05/31/13 15:34, Andy Shevchenko wrote: > On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >> This patch fixes a format specifier warning. dma_addr_t can be either >> u32 or u64 so we should cast to the largest type and change the format >> specifier to %llx. > > dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier > which is available from v3.8(?). > > Something like this: > dma_addr_t src_addr; > dev_dbg(dev, "DMA addr: %pa\n", src_addr); Isn't that: deb_dbg(dev, "DMA addr: %pa\n", _addr); -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: > This patch fixes a format specifier warning. dma_addr_t can be either > u32 or u64 so we should cast to the largest type and change the format > specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is available from v3.8(?). Something like this: dma_addr_t src_addr; dev_dbg(dev, "DMA addr: %pa\n", src_addr); -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
Hello.
On 06/01/2013 12:22 AM, Emil Goode wrote:
This patch fixes a format specifier warning. dma_addr_t can be either
u32 or u64 so we should cast to the largest type and change the format
specifier to %llx.
The addition of urb->transfer_dma and urb->actual_length is also done a
few lines below. I have moved this code up and pass the variable buf to
dev_dbg.
Sparse output:
drivers/usb/musb/musb_host.c:1761:4: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 6 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode
---
drivers/usb/musb/musb_host.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 094cf80..d647ccb 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
[...]
@@ -1789,11 +1789,8 @@ void musb_host_rx(struct musb *musb, u8 epnum)
length = rx_count;
d->status = d_status;
buf = urb->transfer_dma + d->offset;
- } else {
+ } else
You should keep {} on the *else* branch since *if* branch has {},
according to Documentation/CodingStyle.
length = rx_count;
- buf = urb->transfer_dma +
- urb->actual_length;
- }
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
Hello.
On 06/01/2013 12:22 AM, Emil Goode wrote:
This patch fixes a format specifier warning. dma_addr_t can be either
u32 or u64 so we should cast to the largest type and change the format
specifier to %llx.
The addition of urb-transfer_dma and urb-actual_length is also done a
few lines below. I have moved this code up and pass the variable buf to
dev_dbg.
Sparse output:
drivers/usb/musb/musb_host.c:1761:4: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 6 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/usb/musb/musb_host.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 094cf80..d647ccb 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
[...]
@@ -1789,11 +1789,8 @@ void musb_host_rx(struct musb *musb, u8 epnum)
length = rx_count;
d-status = d_status;
buf = urb-transfer_dma + d-offset;
- } else {
+ } else
You should keep {} on the *else* branch since *if* branch has {},
according to Documentation/CodingStyle.
length = rx_count;
- buf = urb-transfer_dma +
- urb-actual_length;
- }
WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On Fri, May 31, 2013 at 11:22 PM, Emil Goode emilgo...@gmail.com wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is available from v3.8(?). Something like this: dma_addr_t src_addr; dev_dbg(dev, DMA addr: %pa\n, src_addr); -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] usb: musb: Fix format specifier warning
On 05/31/13 15:34, Andy Shevchenko wrote: On Fri, May 31, 2013 at 11:22 PM, Emil Goode emilgo...@gmail.com wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is available from v3.8(?). Something like this: dma_addr_t src_addr; dev_dbg(dev, DMA addr: %pa\n, src_addr); Isn't that: deb_dbg(dev, DMA addr: %pa\n, src_addr); -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
