Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected
On Thu, Sep 13, 2007 at 05:07:16PM +0200, Luca Risolia wrote: > On Thursday 13 September 2007 14:36:27 [EMAIL PROTECTED] wrote: > > With current git tree I get an build error > > for et61x251, if V4L1_COMPAT is not selected: > > > > drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_: > > drivers/media/video/et61x251/et61x251_core.c:718: error: implicit > > declaration of to_video_device > > > > Fix: add VIDEO_V4L1_COMPAT as a dependency for this driver. > > No, wait. The driver really is V4L2 only. If you can, please fix it by > replacing to_video_device() with container_of() instead: > > cam = video_get_drvdata(container_of(cd, struct video_device, class_dev)); Ah just some v4l1 remainders. I'll do that. Regards, Andreas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected
On Thursday 13 September 2007 14:36:27 [EMAIL PROTECTED] wrote: > With current git tree I get an build error > for et61x251, if V4L1_COMPAT is not selected: > > drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_: > drivers/media/video/et61x251/et61x251_core.c:718: error: implicit > declaration of to_video_device > > Fix: add VIDEO_V4L1_COMPAT as a dependency for this driver. No, wait. The driver really is V4L2 only. If you can, please fix it by replacing to_video_device() with container_of() instead: cam = video_get_drvdata(container_of(cd, struct video_device, class_dev)); Best regards Luca Risolia > > Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> > --- > drivers/media/video/et61x251/Kconfig |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/et61x251/Kconfig > b/drivers/media/video/et61x251/Kconfig index dcc1a03..9143424 100644 > --- a/drivers/media/video/et61x251/Kconfig > +++ b/drivers/media/video/et61x251/Kconfig > @@ -1,6 +1,6 @@ > config USB_ET61X251 > tristate "USB ET61X[12]51 PC Camera Controller support" > - depends on VIDEO_V4L2 > + depends on VIDEO_V4L2 && VIDEO_V4L1_COMPAT > ---help--- > Say Y here if you want support for cameras based on Etoms ET61X151 > or ET61X251 PC Camera Controllers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
