Re: [PATCH] video: use getter/setter functions
On Tue, 09 Feb 2021, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > spi_device structure. > > Signed-off-by: Julia Lawall > > --- > drivers/video/backlight/qcom-wled.c |2 > +- > drivers/video/fbdev/amifb.c |4 > ++-- > drivers/video/fbdev/da8xx-fb.c |4 > ++-- > drivers/video/fbdev/imxfb.c |2 > +- > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |6 > +++--- > drivers/video/fbdev/omap2/omapfb/dss/dpi.c |4 > ++-- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c |4 > ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c |2 > +- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |2 > +- > drivers/video/fbdev/xilinxfb.c |2 > +- > 10 files changed, 16 insertions(+), 16 deletions(-) I fixed-up the subject line and commit message a bit and applied. Thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] video: use getter/setter functions
On Wed, Feb 10, 2021 at 04:12:58PM +, Lee Jones wrote:
> On Wed, 10 Feb 2021, Daniel Vetter wrote:
>
> > On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote:
> > > On Tue, 09 Feb 2021, Julia Lawall wrote:
> > >
> > > > Use getter and setter functions, for platform_device structures and a
> > > > spi_device structure.
> > > >
> > > > Signed-off-by: Julia Lawall
> > > >
> > > > ---
> > > > drivers/video/backlight/qcom-wled.c |
> > > >2 +-
> > >
> > > This patch is fine.
> > >
> > > Could you please split it out and submit it separately though please.
> >
> > Or just apply the entire patch through backlight tree, there's nothing
> > going on in fbdev anyway I think.
> >
> > Acked-by: Daniel Vetter
>
> I can do that. Is that an fbdev Ack?
Yeah defacto I'm somehow stuck with that as maintainer of last resort :-)
Iirc we've got an S: orphaned entry pointing at drm.git trees.
-Daniel
>
> > > > drivers/video/fbdev/amifb.c |
> > > >4 ++--
> > > > drivers/video/fbdev/da8xx-fb.c |
> > > >4 ++--
> > > > drivers/video/fbdev/imxfb.c |
> > > >2 +-
> > > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |
> > > >6 +++---
> > > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c |
> > > >4 ++--
> > > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c |
> > > >4 ++--
> > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c |
> > > >2 +-
> > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |
> > > >2 +-
> > > > drivers/video/fbdev/xilinxfb.c |
> > > >2 +-
> > > > 10 files changed, 16 insertions(+), 16 deletions(-)
> > >
> > > ...]
> > >
> > > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > > b/drivers/video/backlight/qcom-wled.c
> > > > index 3bc7800eb0a9..091f07e7c145 100644
> > > > --- a/drivers/video/backlight/qcom-wled.c
> > > > +++ b/drivers/video/backlight/qcom-wled.c
> > > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device
> > > > *pdev)
> > > >
> > > > static int wled_remove(struct platform_device *pdev)
> > > > {
> > > > - struct wled *wled = dev_get_drvdata(>dev);
> > > > + struct wled *wled = platform_get_drvdata(pdev);
> > > >
> > > > mutex_destroy(>lock);
> > > > cancel_delayed_work_sync(>ovp_work);
> > >
> > > For my own reference (apply this as-is to your sign-off block):
> > >
> > > Acked-for-Backlight-by: Lee Jones
> > >
> >
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Re: [PATCH] video: use getter/setter functions
On Wed, 10 Feb 2021, Daniel Vetter wrote:
> On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote:
> > On Tue, 09 Feb 2021, Julia Lawall wrote:
> >
> > > Use getter and setter functions, for platform_device structures and a
> > > spi_device structure.
> > >
> > > Signed-off-by: Julia Lawall
> > >
> > > ---
> > > drivers/video/backlight/qcom-wled.c |
> > > 2 +-
> >
> > This patch is fine.
> >
> > Could you please split it out and submit it separately though please.
>
> Or just apply the entire patch through backlight tree, there's nothing
> going on in fbdev anyway I think.
>
> Acked-by: Daniel Vetter
I can do that. Is that an fbdev Ack?
> > > drivers/video/fbdev/amifb.c |
> > > 4 ++--
> > > drivers/video/fbdev/da8xx-fb.c |
> > > 4 ++--
> > > drivers/video/fbdev/imxfb.c |
> > > 2 +-
> > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |
> > > 6 +++---
> > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c |
> > > 4 ++--
> > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c |
> > > 4 ++--
> > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c |
> > > 2 +-
> > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |
> > > 2 +-
> > > drivers/video/fbdev/xilinxfb.c |
> > > 2 +-
> > > 10 files changed, 16 insertions(+), 16 deletions(-)
> >
> > ...]
> >
> > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > b/drivers/video/backlight/qcom-wled.c
> > > index 3bc7800eb0a9..091f07e7c145 100644
> > > --- a/drivers/video/backlight/qcom-wled.c
> > > +++ b/drivers/video/backlight/qcom-wled.c
> > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev)
> > >
> > > static int wled_remove(struct platform_device *pdev)
> > > {
> > > - struct wled *wled = dev_get_drvdata(>dev);
> > > + struct wled *wled = platform_get_drvdata(pdev);
> > >
> > > mutex_destroy(>lock);
> > > cancel_delayed_work_sync(>ovp_work);
> >
> > For my own reference (apply this as-is to your sign-off block):
> >
> > Acked-for-Backlight-by: Lee Jones
> >
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH] video: use getter/setter functions
On Wed, 10 Feb 2021, Daniel Vetter wrote:
> On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote:
> > On Tue, 09 Feb 2021, Julia Lawall wrote:
> >
> > > Use getter and setter functions, for platform_device structures and a
> > > spi_device structure.
> > >
> > > Signed-off-by: Julia Lawall
> > >
> > > ---
> > > drivers/video/backlight/qcom-wled.c |
> > > 2 +-
> >
> > This patch is fine.
> >
> > Could you please split it out and submit it separately though please.
>
> Or just apply the entire patch through backlight tree, there's nothing
> going on in fbdev anyway I think.
I was indeed not sure how much to split this up. If it is desired to
split it more, I can do that.
julia
>
> Acked-by: Daniel Vetter
>
> >
> > > drivers/video/fbdev/amifb.c |
> > > 4 ++--
> > > drivers/video/fbdev/da8xx-fb.c |
> > > 4 ++--
> > > drivers/video/fbdev/imxfb.c |
> > > 2 +-
> > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |
> > > 6 +++---
> > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c |
> > > 4 ++--
> > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c |
> > > 4 ++--
> > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c |
> > > 2 +-
> > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |
> > > 2 +-
> > > drivers/video/fbdev/xilinxfb.c |
> > > 2 +-
> > > 10 files changed, 16 insertions(+), 16 deletions(-)
> >
> > ...]
> >
> > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > b/drivers/video/backlight/qcom-wled.c
> > > index 3bc7800eb0a9..091f07e7c145 100644
> > > --- a/drivers/video/backlight/qcom-wled.c
> > > +++ b/drivers/video/backlight/qcom-wled.c
> > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev)
> > >
> > > static int wled_remove(struct platform_device *pdev)
> > > {
> > > - struct wled *wled = dev_get_drvdata(>dev);
> > > + struct wled *wled = platform_get_drvdata(pdev);
> > >
> > > mutex_destroy(>lock);
> > > cancel_delayed_work_sync(>ovp_work);
> >
> > For my own reference (apply this as-is to your sign-off block):
> >
> > Acked-for-Backlight-by: Lee Jones
> >
> > --
> > Lee Jones [李琼斯]
> > Senior Technical Lead - Developer Services
> > Linaro.org │ Open source software for Arm SoCs
> > Follow Linaro: Facebook | Twitter | Blog
> > ___
> > dri-devel mailing list
> > dri-de...@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>
Re: [PATCH] video: use getter/setter functions
On Wed, Feb 10, 2021 at 08:23:41AM +, Lee Jones wrote:
> On Tue, 09 Feb 2021, Julia Lawall wrote:
>
> > Use getter and setter functions, for platform_device structures and a
> > spi_device structure.
> >
> > Signed-off-by: Julia Lawall
> >
> > ---
> > drivers/video/backlight/qcom-wled.c |
> > 2 +-
>
> This patch is fine.
>
> Could you please split it out and submit it separately though please.
Or just apply the entire patch through backlight tree, there's nothing
going on in fbdev anyway I think.
Acked-by: Daniel Vetter
>
> > drivers/video/fbdev/amifb.c |
> > 4 ++--
> > drivers/video/fbdev/da8xx-fb.c |
> > 4 ++--
> > drivers/video/fbdev/imxfb.c |
> > 2 +-
> > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |
> > 6 +++---
> > drivers/video/fbdev/omap2/omapfb/dss/dpi.c |
> > 4 ++--
> > drivers/video/fbdev/omap2/omapfb/dss/dsi.c |
> > 4 ++--
> > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c |
> > 2 +-
> > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |
> > 2 +-
> > drivers/video/fbdev/xilinxfb.c |
> > 2 +-
> > 10 files changed, 16 insertions(+), 16 deletions(-)
>
> ...]
>
> > diff --git a/drivers/video/backlight/qcom-wled.c
> > b/drivers/video/backlight/qcom-wled.c
> > index 3bc7800eb0a9..091f07e7c145 100644
> > --- a/drivers/video/backlight/qcom-wled.c
> > +++ b/drivers/video/backlight/qcom-wled.c
> > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev)
> >
> > static int wled_remove(struct platform_device *pdev)
> > {
> > - struct wled *wled = dev_get_drvdata(>dev);
> > + struct wled *wled = platform_get_drvdata(pdev);
> >
> > mutex_destroy(>lock);
> > cancel_delayed_work_sync(>ovp_work);
>
> For my own reference (apply this as-is to your sign-off block):
>
> Acked-for-Backlight-by: Lee Jones
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Re: [PATCH] video: use getter/setter functions
On Tue, 09 Feb 2021, Julia Lawall wrote:
> Use getter and setter functions, for platform_device structures and a
> spi_device structure.
>
> Signed-off-by: Julia Lawall
>
> ---
> drivers/video/backlight/qcom-wled.c |2
> +-
This patch is fine.
Could you please split it out and submit it separately though please.
> drivers/video/fbdev/amifb.c |4
> ++--
> drivers/video/fbdev/da8xx-fb.c |4
> ++--
> drivers/video/fbdev/imxfb.c |2
> +-
> drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |6
> +++---
> drivers/video/fbdev/omap2/omapfb/dss/dpi.c |4
> ++--
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c |4
> ++--
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c |2
> +-
> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |2
> +-
> drivers/video/fbdev/xilinxfb.c |2
> +-
> 10 files changed, 16 insertions(+), 16 deletions(-)
...]
> diff --git a/drivers/video/backlight/qcom-wled.c
> b/drivers/video/backlight/qcom-wled.c
> index 3bc7800eb0a9..091f07e7c145 100644
> --- a/drivers/video/backlight/qcom-wled.c
> +++ b/drivers/video/backlight/qcom-wled.c
> @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev)
>
> static int wled_remove(struct platform_device *pdev)
> {
> - struct wled *wled = dev_get_drvdata(>dev);
> + struct wled *wled = platform_get_drvdata(pdev);
>
> mutex_destroy(>lock);
> cancel_delayed_work_sync(>ovp_work);
For my own reference (apply this as-is to your sign-off block):
Acked-for-Backlight-by: Lee Jones
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
