Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"
On 2016/7/27 2:50, Max Filippov wrote:
> On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
>> This partially reverts commit 69d99e6c0d62 keeping only the main
>> purpose of the original commit which is the removal of
>> of_platform_populate() call. The moving of of_clk_init() caused changes
>> in the initialization order breaking booting.
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with
>> default match table")
>> Cc: Kefeng Wang
>> Cc: Guenter Roeck
>> Cc: Max Filippov
>> Signed-off-by: Rob Herring
>> ---
>> This is on top of Guenter's build fix. Please test and I'll apply. I
Hi all,
Sorry about the issue introduced by me, will be more careful,
and thanks Rob and Guenter to fix them.
BRs,
Kefeng
>
> Tested-by: Max Filippov
>
>> tried briefly running under QEMU, but didn't have success. If anyone has
>> up to date instructions that would be helpful as using these[1] didn't
>> seem to work.
>
> I think they're up to date. Another thing that need to be done right is
> the toolchain: it must match the configured CPU core. Please refer to
> http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
> for more details.
>
>>
>> [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU
>>
>> arch/xtensa/kernel/setup.c | 9 +
>> arch/xtensa/kernel/time.c | 2 --
>> 2 files changed, 9 insertions(+), 2 deletions(-)
>
Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"
On Tue, Jul 26, 2016 at 02:13:52PM -0500, Rob Herring wrote: > >> I tried briefly running under QEMU, but didn't have success. If anyone has > >> up to date instructions that would be helpful as using these[1] didn't > >> seem to work. > > > > I think they're up to date. Another thing that need to be done right is > > the toolchain: it must match the configured CPU core. Please refer to > > http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File > > for more details. > > I don't build toolchains... The toolchain for xtensa built with unmodified binutils does not produce working code. The one at https://www.kernel.org/pub/tools/crosstool/files/bin/ and the one shipped with Fedora are broken. Here's a few working prebuilt toolchains capable of building linux: http://jcmvbkbc.spb.ru/~jcmvbkbc/tmp/201604261801/ -- Thanks. -- Max
Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"
On Tue, Jul 26, 2016 at 1:50 PM, Max Filippov wrote:
> On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
>> This partially reverts commit 69d99e6c0d62 keeping only the main
>> purpose of the original commit which is the removal of
>> of_platform_populate() call. The moving of of_clk_init() caused changes
>> in the initialization order breaking booting.
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with
>> default match table")
>> Cc: Kefeng Wang
>> Cc: Guenter Roeck
>> Cc: Max Filippov
>> Signed-off-by: Rob Herring
>> ---
>> This is on top of Guenter's build fix. Please test and I'll apply. I
>
> Tested-by: Max Filippov
Thanks.
>> tried briefly running under QEMU, but didn't have success. If anyone has
>> up to date instructions that would be helpful as using these[1] didn't
>> seem to work.
>
> I think they're up to date. Another thing that need to be done right is
> the toolchain: it must match the configured CPU core. Please refer to
> http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
> for more details.
I don't build toolchains...
Rob
Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"
On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
> This partially reverts commit 69d99e6c0d62 keeping only the main
> purpose of the original commit which is the removal of
> of_platform_populate() call. The moving of of_clk_init() caused changes
> in the initialization order breaking booting.
>
> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with
> default match table")
> Cc: Kefeng Wang
> Cc: Guenter Roeck
> Cc: Max Filippov
> Signed-off-by: Rob Herring
> ---
> This is on top of Guenter's build fix. Please test and I'll apply. I
Tested-by: Max Filippov
> tried briefly running under QEMU, but didn't have success. If anyone has
> up to date instructions that would be helpful as using these[1] didn't
> seem to work.
I think they're up to date. Another thing that need to be done right is
the toolchain: it must match the configured CPU core. Please refer to
http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
for more details.
>
> [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU
>
> arch/xtensa/kernel/setup.c | 9 +
> arch/xtensa/kernel/time.c | 2 --
> 2 files changed, 9 insertions(+), 2 deletions(-)
--
Thanks.
-- Max
