Re: [PATCH] zram: fix missing zero pages for memory tracking
On (09/22/18 12:11), Minchan Kim wrote: > On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote: > > On (09/19/18 14:18), Minchan Kim wrote: > > > We need to count zero filled pages as well as other pages in zram. > > > > A nit, > > > > 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only > > zero filled pages. > > I was brainfart. No, never :) And I totally didn't mean it. -ss
Re: [PATCH] zram: fix missing zero pages for memory tracking
On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote: > On (09/19/18 14:18), Minchan Kim wrote: > > We need to count zero filled pages as well as other pages in zram. > > A nit, > > 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only > zero filled pages. Ah, now I got your point. I was brainfart. I will drop this patch and find other reason I have missed. Thanks, Sergey.
Re: [PATCH] zram: fix missing zero pages for memory tracking
Hi Sergey, On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote: > On (09/19/18 14:18), Minchan Kim wrote: > > We need to count zero filled pages as well as other pages in zram. > > A nit, > > 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only > zero filled pages. Yub, that's what I want. Currently, it covers only non-zero filled same page, which is inconsistent and user easily miss zero-filled same page.
Re: [PATCH] zram: fix missing zero pages for memory tracking
On (09/19/18 14:18), Minchan Kim wrote: > We need to count zero filled pages as well as other pages in zram. A nit, 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only zero filled pages. -ss
