Re: [PATCH] zram: reduce load operation in page_same_filled

[Sergey Senozhatsky]

On (03/02/17 16:02), Minchan Kim wrote:
> Acked-by: Minchan Kim 

Reviewed-by: Sergey Senozhatsky 

thanks.

-ss

Re: [PATCH] zram: reduce load operation in page_same_filled

[Sergey Senozhatsky]

On (03/02/17 16:02), Minchan Kim wrote:
> Acked-by: Minchan Kim 

Reviewed-by: Sergey Senozhatsky 

thanks.

-ss

Re: [PATCH] zram: reduce load operation in page_same_filled

[Minchan Kim]

Hi Sangwoo,

On Thu, Mar 02, 2017 at 01:15:04PM +0900, Sangwoo wrote:
> In page_same_filled function, all elements in the page is compared
> with next index value. The current comparison routine compares
> the (i)th and (i+1)th values of the page.
> In this case, two load operaions occur for each comparison.
> But if we store first value of the page stores at 'val' variable
> and using it to compare with others, the load opearation is reduced.
> It reduce load operation per page by up to 64times.
> 
> Signed-off-by: Sangwoo 

The rule is that you should use your full name Sangwoo Park for SOB. :)
Anyway, Good spot!

FYI,
Ccing Andrew because he merges zram patches to mmotm tree.

Acked-by: Minchan Kim 

Thanks.

Re: [PATCH] zram: reduce load operation in page_same_filled

[Minchan Kim]

Hi Sangwoo,

On Thu, Mar 02, 2017 at 01:15:04PM +0900, Sangwoo wrote:
> In page_same_filled function, all elements in the page is compared
> with next index value. The current comparison routine compares
> the (i)th and (i+1)th values of the page.
> In this case, two load operaions occur for each comparison.
> But if we store first value of the page stores at 'val' variable
> and using it to compare with others, the load opearation is reduced.
> It reduce load operation per page by up to 64times.
> 
> Signed-off-by: Sangwoo 

The rule is that you should use your full name Sangwoo Park for SOB. :)
Anyway, Good spot!

FYI,
Ccing Andrew because he merges zram patches to mmotm tree.

Acked-by: Minchan Kim 

Thanks.