Re: [PATCH (v2)] crypto: Remove pointless padlock module
On 20/05/07 04:15, Herbert Xu wrote: On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: It should be a bool that doesn't select anything, the AES and SHA modules will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 instead of X86_32. Having it as a tristate means that we don't have to duplicate the dependencies and selects that each padlock algorithm would otherwise do. So is there actually a problem with it being a tristate? It has nothing to compile as a module, so M makes no sense. Each algorithm already selects CRYPTO_ALGAPI indirectly. -- Simon Arlott - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH (v2)] crypto: Remove pointless padlock module
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote:
>
> It should be a bool that doesn't select anything, the AES and SHA modules
> will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7
> instead of X86_32.
Having it as a tristate means that we don't have to duplicate the
dependencies and selects that each padlock algorithm would otherwise
do. So is there actually a problem with it being a tristate?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH (v2)] crypto: Remove pointless padlock module
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote: > > BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m > > since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a > > tristate again. > > It should be a bool that doesn't select anything, the AES and SHA modules > will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 > instead of X86_32. Don't forget it's possible to build 'generic' x86 kernels, which would also want this module. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH (v2)] crypto: Remove pointless padlock module
On 18/05/07 07:45, Herbert Xu wrote: On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote: When this is compiled in it is run too early to do anything useful: [6.052000] padlock: No VIA PadLock drivers have been loaded. [6.052000] padlock: Using VIA PadLock ACE for AES algorithm. [6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms. When it's a module it isn't doing anything special, the same functionality can be provided in userspace by "probeall padlock padlock-aes padlock-sha" in modules.conf if it is required. BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a tristate again. It should be a bool that doesn't select anything, the AES and SHA modules will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 instead of X86_32. -- Simon Arlott - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH (v2)] crypto: Remove pointless padlock module
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote:
> When this is compiled in it is run too early to do anything useful:
> [6.052000] padlock: No VIA PadLock drivers have been loaded.
> [6.052000] padlock: Using VIA PadLock ACE for AES algorithm.
> [6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms.
>
> When it's a module it isn't doing anything special, the same functionality
> can be provided in userspace by "probeall padlock padlock-aes padlock-sha"
> in modules.conf if it is required.
BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m
since it was selected by CRYPTO_DEV_PADLOCK. So I'm turning it into a
tristate again.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
d158325e407864793c5b0fbc85c7470275b9
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e678a33..bb90cbd 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -1,10 +1,10 @@
menu "Hardware crypto devices"
config CRYPTO_DEV_PADLOCK
- bool "Support for VIA PadLock ACE"
+ tristate "Support for VIA PadLock ACE"
depends on X86_32
select CRYPTO_ALGAPI
- default y
+ default m
help
Some VIA processors come with an integrated crypto engine
(so called VIA PadLock ACE, Advanced Cryptography Engine)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH (v2)] crypto: Remove pointless padlock module
On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote:
>
> Well that's mostly the point - it shouldn't get compiled in - ever,
> but it also has other modules depending on it in Kconfig that
> shouldn't need to be modules.
Patch applied. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
