Re: [PATCH 0/2] Two fixes for loop devices
On 06/17/2017 10:33 PM, NeilBrown wrote: > On Fri, Jun 16 2017, Jens Axboe wrote: > >> On 06/15/2017 11:02 PM, NeilBrown wrote: >>> Hi Jens, >>> one of these is a resend of a patch I sent a while back. >>> The other is new - loop closes files differently from close() >>> and in a way that can confuse NFS. >> >> Are you wanting to get these into 4.12, or defer to 4.13? > > I'm happy either way. I just want them to land eventually, so I can > tick them off my list. > > The conversation with Al might result in a different fix for the > flip_close() problem, but I think that it is still more correct to call > filp_close(), because what loop is doing is a lot like closing a file > that it has been writing to. I'll toss 2/2 in for now for 4.13, please resend the other once the issues have been ironed out. -- Jens Axboe
Re: [PATCH 0/2] Two fixes for loop devices
On 06/17/2017 10:33 PM, NeilBrown wrote: > On Fri, Jun 16 2017, Jens Axboe wrote: > >> On 06/15/2017 11:02 PM, NeilBrown wrote: >>> Hi Jens, >>> one of these is a resend of a patch I sent a while back. >>> The other is new - loop closes files differently from close() >>> and in a way that can confuse NFS. >> >> Are you wanting to get these into 4.12, or defer to 4.13? > > I'm happy either way. I just want them to land eventually, so I can > tick them off my list. > > The conversation with Al might result in a different fix for the > flip_close() problem, but I think that it is still more correct to call > filp_close(), because what loop is doing is a lot like closing a file > that it has been writing to. I'll toss 2/2 in for now for 4.13, please resend the other once the issues have been ironed out. -- Jens Axboe
Re: [PATCH 0/2] Two fixes for loop devices
On Fri, Jun 16 2017, Jens Axboe wrote: > On 06/15/2017 11:02 PM, NeilBrown wrote: >> Hi Jens, >> one of these is a resend of a patch I sent a while back. >> The other is new - loop closes files differently from close() >> and in a way that can confuse NFS. > > Are you wanting to get these into 4.12, or defer to 4.13? I'm happy either way. I just want them to land eventually, so I can tick them off my list. The conversation with Al might result in a different fix for the flip_close() problem, but I think that it is still more correct to call filp_close(), because what loop is doing is a lot like closing a file that it has been writing to. Thanks, NeilBrown signature.asc Description: PGP signature
Re: [PATCH 0/2] Two fixes for loop devices
On Fri, Jun 16 2017, Jens Axboe wrote: > On 06/15/2017 11:02 PM, NeilBrown wrote: >> Hi Jens, >> one of these is a resend of a patch I sent a while back. >> The other is new - loop closes files differently from close() >> and in a way that can confuse NFS. > > Are you wanting to get these into 4.12, or defer to 4.13? I'm happy either way. I just want them to land eventually, so I can tick them off my list. The conversation with Al might result in a different fix for the flip_close() problem, but I think that it is still more correct to call filp_close(), because what loop is doing is a lot like closing a file that it has been writing to. Thanks, NeilBrown signature.asc Description: PGP signature
Re: [PATCH 0/2] Two fixes for loop devices
On 06/15/2017 11:02 PM, NeilBrown wrote: > Hi Jens, > one of these is a resend of a patch I sent a while back. > The other is new - loop closes files differently from close() > and in a way that can confuse NFS. Are you wanting to get these into 4.12, or defer to 4.13? -- Jens Axboe
Re: [PATCH 0/2] Two fixes for loop devices
On 06/15/2017 11:02 PM, NeilBrown wrote: > Hi Jens, > one of these is a resend of a patch I sent a while back. > The other is new - loop closes files differently from close() > and in a way that can confuse NFS. Are you wanting to get these into 4.12, or defer to 4.13? -- Jens Axboe
