Re: [PATCH 0/2] coresight: Add barrier packet when moving offset forward

2019-08-26 Thread Yabin Cui
> Can I add your Tested-by ?

Yes. I just sent a tested-by reply, but not sure if it works. I am not very 
familar
with linux kernel review system.


Re: [PATCH 0/2] coresight: Add barrier packet when moving offset forward

2019-08-26 Thread Mathieu Poirier
Hi Yabin,

On Fri, 23 Aug 2019 at 18:30, Yabin Cui  wrote:
>
> Thanks for fixing this problem. I didn't realize it because I usually use a
> buffer size >= the default ETR buffer size, which is harder to reproduce the
> problem.
> The patches LGTM, maybe you also want to fix the problem commented by Leo Yan.

I will look into the issue reported by Leo later today.

> I tested the patches by recording etm data with a buffer size smaller than the
> default ETR buffer size. Then I saw barrier packets when decoding with 
> OpenCSD.
> And I could decode successfully without error message.

Can I add your Tested-by ?


Re: [PATCH 0/2] coresight: Add barrier packet when moving offset forward

2019-08-23 Thread Yabin Cui
Thanks for fixing this problem. I didn't realize it because I usually use a
buffer size >= the default ETR buffer size, which is harder to reproduce the
problem.
The patches LGTM, maybe you also want to fix the problem commented by Leo Yan.
I tested the patches by recording etm data with a buffer size smaller than the
default ETR buffer size. Then I saw barrier packets when decoding with OpenCSD.
And I could decode successfully without error message.