Re: [PATCH 0/3] check regulator_enable() return value
Hi, On Wed, Apr 03, 2013 at 07:22:38AM -0700, Greg KH wrote: > On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > > > While testing your 'next' branch merged with today's next I got some new > > > warnings, caused by a recently introduced __must_check in: > > > > > > c8801a8 regulator: core: Mark all get and enable calls as __must_check > > > > > > These patches introduces a check for regulator_enable() return value in > > > all three affected USB phy drivers, and issue a dev_err() in case it > > > fails. > > > > > > TWL4030 and TWL6030 patches has been build-tested only. > > > > Sorry but I can't change my tree anymore, we can send these during > > v3.10-rc. > > Really? You are going to send me a tree that adds build warnings? > > Please don't. alright, I'll merge these in. -- balbi signature.asc Description: Digital signature
Re: [PATCH 0/3] check regulator_enable() return value
On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > > While testing your 'next' branch merged with today's next I got some new > > warnings, caused by a recently introduced __must_check in: > > > > c8801a8 regulator: core: Mark all get and enable calls as __must_check > > > > These patches introduces a check for regulator_enable() return value in > > all three affected USB phy drivers, and issue a dev_err() in case it > > fails. > > > > TWL4030 and TWL6030 patches has been build-tested only. > > Sorry but I can't change my tree anymore, we can send these during > v3.10-rc. Really? You are going to send me a tree that adds build warnings? Please don't. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] check regulator_enable() return value
Hi Felipe, On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > > While testing your 'next' branch merged with today's next I got some new > > warnings, caused by a recently introduced __must_check in: > > > > c8801a8 regulator: core: Mark all get and enable calls as __must_check > > > > These patches introduces a check for regulator_enable() return value in > > all three affected USB phy drivers, and issue a dev_err() in case it > > fails. > > > > TWL4030 and TWL6030 patches has been build-tested only. > > Sorry but I can't change my tree anymore, we can send these during > v3.10-rc. Sure, I've no problem with that! Thanks, Fabio -- Fabio Baltieri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] check regulator_enable() return value
Hi, On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > While testing your 'next' branch merged with today's next I got some new > warnings, caused by a recently introduced __must_check in: > > c8801a8 regulator: core: Mark all get and enable calls as __must_check > > These patches introduces a check for regulator_enable() return value in > all three affected USB phy drivers, and issue a dev_err() in case it > fails. > > TWL4030 and TWL6030 patches has been build-tested only. Sorry but I can't change my tree anymore, we can send these during v3.10-rc. -- balbi signature.asc Description: Digital signature
