Re: [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs
On Fri, 2019-01-25 at 01:03 +0900, Masahiro Yamada wrote: > On Tue, Jan 22, 2019 at 1:17 AM Leonard Crestez > wrote: > > > > On 1/7/2019 9:31 PM, Leonard Crestez wrote: > > > The dts makefiles go through a lot of pointless churn when boards are > > > added. Many SOCs (such as imx) have very simple naming conventions for > > > all boards using a certain chip and board listings can be easily > > > collapsed using wildcards. > > > > > > Add a "wilddt" function and use it for imx6/7/8 and layerscape. This can > > > be applied to many other soc families later. > > > > Any feedback? This should be reviewed by kbuild and arm-soc > > Personally, I prefer explicit listing > because I can browse the Makefile to get a quick idea > of which boards are compiled. Or you can just ls soc-*.dts? > I like this to be consistent. > - Exploit wildcard for all platforms > - Do not do this at all > > But, I am pessimistic about the former > when I look at AT91 platform. I can try to resend in a form that uses a wildcard for most platforms but skips those with very few SOCs or confusing conventions (like at91). -- Regards, Leonard
Re: [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs
On Tue, Jan 22, 2019 at 1:17 AM Leonard Crestez wrote: > > On 1/7/2019 9:31 PM, Leonard Crestez wrote: > > The dts makefiles go through a lot of pointless churn when boards are > > added. Many SOCs (such as imx) have very simple naming conventions for > > all boards using a certain chip and board listings can be easily > > collapsed using wildcards. > > > > Add a "wilddt" function and use it for imx6/7/8 and layerscape. This can > > be applied to many other soc families later. > > > > Previously sent as RFC: https://lore.kernel.org/patchwork/patch/1022737/ > > Any feedback? This should be reviewed by kbuild and arm-soc > > I think this is a worthwhile cleanup, are there any corner cases or more > exotic setup I should try in order to validate this series? Personally, I prefer explicit listing because I can browse the Makefile to get a quick idea of which boards are compiled. I like this to be consistent. - Exploit wildcard for all platforms or - Do not do this at all But, I am pessimistic about the former when I look at AT91 platform. -- Best Regards Masahiro Yamada
Re: [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs
On 1/7/2019 9:31 PM, Leonard Crestez wrote: > The dts makefiles go through a lot of pointless churn when boards are > added. Many SOCs (such as imx) have very simple naming conventions for > all boards using a certain chip and board listings can be easily > collapsed using wildcards. > > Add a "wilddt" function and use it for imx6/7/8 and layerscape. This can > be applied to many other soc families later. > > Previously sent as RFC: https://lore.kernel.org/patchwork/patch/1022737/ Any feedback? This should be reviewed by kbuild and arm-soc I think this is a worthwhile cleanup, are there any corner cases or more exotic setup I should try in order to validate this series? -- Regards, Leonard
