Re: [PATCH 0/6] VSOCK for Linux upstreaming
From: Greg KH Date: Tue, 8 Jan 2013 16:21:10 -0800 > On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: >> >> * * * >> >> This series of VSOCK linux upstreaming patches include latest udpate from >> VMware to address Greg's and all other's code review comments. > > Dave, you acked these patches a while ago, Really? I'd like to see where I did that. Instead, what I remember doing was deferring to the feedback these folks received, stating that ideas that the virtio people had mentioned should be considered instead. http://marc.info/?l=linux-netdev=135301515818462=2 So definitely NACK this code and any infrastructure you've merged which essentialy depends upon it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: > > * * * > > This series of VSOCK linux upstreaming patches include latest udpate from > VMware to address Greg's and all other's code review comments. Dave, you acked these patches a while ago, and now that I've taken the VMCI patches that these depend on through my char-misc tree, can I take these as well? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Dave, you acked these patches a while ago, and now that I've taken the VMCI patches that these depend on through my char-misc tree, can I take these as well? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
From: Greg KH gre...@linuxfoundation.org Date: Tue, 8 Jan 2013 16:21:10 -0800 On Tue, Jan 08, 2013 at 03:59:08PM -0800, George Zhang wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from VMware to address Greg's and all other's code review comments. Dave, you acked these patches a while ago, Really? I'd like to see where I did that. Instead, what I remember doing was deferring to the feedback these folks received, stating that ideas that the virtio people had mentioned should be considered instead. http://marc.info/?l=linux-netdevm=135301515818462w=2 So definitely NACK this code and any infrastructure you've merged which essentialy depends upon it. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
On 11/05/2012 01:32 PM, George Zhang wrote: > Sasha, > There is a 'brief' implementation notes aboutVSOCK protocol family > in af_vsock.c. More about user space layer socket programming is from > VMCI Socket Programming Guide. (remove crosst...@vmware.com for email > bouncing). > thanks, > George So all the documentation I see in the VMCI Socket Programming Guide is about userspace programming, and the documentation in af_vsock.c is all around implementation considerations. Is there anything that documents the actual protocol? Just for example, whats the deal with REQUEST/REQUEST2? it appears like something to deal with legacy code, but I'd really like to have it documented somewhere instead of trying to figure how everything works by looking at the code. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
On 11/05/2012 01:32 PM, George Zhang wrote: Sasha, There is a 'brief' implementation notes aboutVSOCK protocol family in af_vsock.c. More about user space layer socket programming is from VMCI Socket Programming Guide. (remove crosst...@vmware.com for email bouncing). thanks, George So all the documentation I see in the VMCI Socket Programming Guide is about userspace programming, and the documentation in af_vsock.c is all around implementation considerations. Is there anything that documents the actual protocol? Just for example, whats the deal with REQUEST/REQUEST2? it appears like something to deal with legacy code, but I'd really like to have it documented somewhere instead of trying to figure how everything works by looking at the code. Thanks, Sasha -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
Never mind, mail server seemed to be overloaded today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
On Mon, 05 Nov 2012 10:00:38 -0800 George Zhang wrote: > * * * > This series of VSOCK linux upstreaming patches include latest udpate from > VMware. > > Summary of changes: > - Add include/linux/socket.h for AF_VSOCK. > - Cleanup some comments. > - Cleanup makefiles. > > > > * * * > > In an effort to improve the out-of-the-box experience with Linux > kernels for VMware users, VMware is working on readying the Virtual > Machine Communication Interface (vmw_vmci) and VMCI Sockets (VSOCK) > (vmw_vsock) kernel modules for inclusion in the Linux kernel. The > purpose of this post is to acquire feedback on the vmw_vsock kernel > module. The vmw_vmci kernel module has been presented in an early post. > > > * * * > > VMCI Sockets allows virtual machines to communicate with host kernel > modules and the VMware hypervisors. VMCI Sockets kernel module has > dependency on VMCI kernel module. User level applications both in > a virtual machine and on the host can use vmw_vmci through VMCI > Sockets API which facilitates fast and efficient communication > between guest virtual machines and their host. A socket > address family designed to be compatible with UDP and TCP at the > interface level. Today, VMCI and VMCI Sockets are used by the VMware > shared folders (HGFS) and various VMware Tools components inside the > guest for zero-config, network-less access to VMware host services. In > addition to this, VMware's users are using VMCI Sockets for various > applications, where network access of the virtual machine is > restricted or non-existent. Examples of this are VMs communicating > with device proxies for proprietary hardware running as host > applications and automated testing of applications running within > virtual machines. > > The VMware VMCI Sockets are similar to other socket types, like > Berkeley UNIX socket interface. The VMCI sockets module supports > both connection-oriented stream sockets like TCP, and connectionless > datagram sockets like UDP. The VSOCK protocol family is defined as > "AF_VSOCK" and the socket operations split for SOCK_DGRAM and > SOCK_STREAM. > > For additional information about the use of VMCI and in particular > VMCI Sockets, please refer to the VMCI Socket Programming Guide > available at https://www.vmware.com/support/developer/vmci-sdk/. > This should go to netdev as well since it is a new address family. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
On Mon, 05 Nov 2012 10:00:38 -0800 George Zhang georgezh...@vmware.com wrote: * * * This series of VSOCK linux upstreaming patches include latest udpate from VMware. Summary of changes: - Add include/linux/socket.h for AF_VSOCK. - Cleanup some comments. - Cleanup makefiles. * * * In an effort to improve the out-of-the-box experience with Linux kernels for VMware users, VMware is working on readying the Virtual Machine Communication Interface (vmw_vmci) and VMCI Sockets (VSOCK) (vmw_vsock) kernel modules for inclusion in the Linux kernel. The purpose of this post is to acquire feedback on the vmw_vsock kernel module. The vmw_vmci kernel module has been presented in an early post. * * * VMCI Sockets allows virtual machines to communicate with host kernel modules and the VMware hypervisors. VMCI Sockets kernel module has dependency on VMCI kernel module. User level applications both in a virtual machine and on the host can use vmw_vmci through VMCI Sockets API which facilitates fast and efficient communication between guest virtual machines and their host. A socket address family designed to be compatible with UDP and TCP at the interface level. Today, VMCI and VMCI Sockets are used by the VMware shared folders (HGFS) and various VMware Tools components inside the guest for zero-config, network-less access to VMware host services. In addition to this, VMware's users are using VMCI Sockets for various applications, where network access of the virtual machine is restricted or non-existent. Examples of this are VMs communicating with device proxies for proprietary hardware running as host applications and automated testing of applications running within virtual machines. The VMware VMCI Sockets are similar to other socket types, like Berkeley UNIX socket interface. The VMCI sockets module supports both connection-oriented stream sockets like TCP, and connectionless datagram sockets like UDP. The VSOCK protocol family is defined as AF_VSOCK and the socket operations split for SOCK_DGRAM and SOCK_STREAM. For additional information about the use of VMCI and in particular VMCI Sockets, please refer to the VMCI Socket Programming Guide available at https://www.vmware.com/support/developer/vmci-sdk/. This should go to netdev as well since it is a new address family. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
Never mind, mail server seemed to be overloaded today. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
Sasha, There is a 'brief' implementation notes aboutVSOCK protocol family in af_vsock.c. More about user space layer socket programming is from VMCI Socket Programming Guide. (remove crosst...@vmware.com for email bouncing). thanks, George - Original Message - From: "Sasha Levin" To: "George Zhang" Cc: net...@vger.kernel.org, linux-kernel@vger.kernel.org, virtualizat...@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, da...@davemloft.net, gre...@linuxfoundation.org Sent: Monday, November 5, 2012 10:23:02 AM Subject: Re: [PATCH 0/6] VSOCK for Linux upstreaming Hi George, On Mon, Nov 5, 2012 at 1:00 PM, George Zhang wrote: > For additional information about the use of VMCI and in particular > VMCI Sockets, please refer to the VMCI Socket Programming Guide > available at https://www.vmware.com/support/developer/vmci-sdk/. Is there documentation about the protocol itself? I couldn't find it on the link above. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
David, We will fix this bounces and remove the email: crosst...@vmware.com. Thanks, george zhang - Original Message - From: "David Miller" To: georgezh...@vmware.com Cc: net...@vger.kernel.org, linux-kernel@vger.kernel.org, virtualizat...@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, gre...@linuxfoundation.org Sent: Monday, November 5, 2012 10:10:37 AM Subject: Re: [PATCH 0/6] VSOCK for Linux upstreaming From: David Miller Date: Mon, 05 Nov 2012 13:09:17 -0500 (EST) > The big and only question is whether anyone can actually use any of > this stuff without your proprietary bits? And BTW vm-crosst...@vmware.com bounces, take it out of the CC: list on all future emails. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
Hi George, On Mon, Nov 5, 2012 at 1:00 PM, George Zhang wrote: > For additional information about the use of VMCI and in particular > VMCI Sockets, please refer to the VMCI Socket Programming Guide > available at https://www.vmware.com/support/developer/vmci-sdk/. Is there documentation about the protocol itself? I couldn't find it on the link above. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
From: David Miller Date: Mon, 05 Nov 2012 13:09:17 -0500 (EST) > The big and only question is whether anyone can actually use any of > this stuff without your proprietary bits? And BTW vm-crosst...@vmware.com bounces, take it out of the CC: list on all future emails. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
The big and only question is whether anyone can actually use any of this stuff without your proprietary bits? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
The big and only question is whether anyone can actually use any of this stuff without your proprietary bits? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
From: David Miller da...@davemloft.net Date: Mon, 05 Nov 2012 13:09:17 -0500 (EST) The big and only question is whether anyone can actually use any of this stuff without your proprietary bits? And BTW vm-crosst...@vmware.com bounces, take it out of the CC: list on all future emails. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
Hi George, On Mon, Nov 5, 2012 at 1:00 PM, George Zhang georgezh...@vmware.com wrote: For additional information about the use of VMCI and in particular VMCI Sockets, please refer to the VMCI Socket Programming Guide available at https://www.vmware.com/support/developer/vmci-sdk/. Is there documentation about the protocol itself? I couldn't find it on the link above. Thanks, Sasha -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
David, We will fix this bounces and remove the email: crosst...@vmware.com. Thanks, george zhang - Original Message - From: David Miller da...@davemloft.net To: georgezh...@vmware.com Cc: net...@vger.kernel.org, linux-kernel@vger.kernel.org, virtualizat...@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, gre...@linuxfoundation.org Sent: Monday, November 5, 2012 10:10:37 AM Subject: Re: [PATCH 0/6] VSOCK for Linux upstreaming From: David Miller da...@davemloft.net Date: Mon, 05 Nov 2012 13:09:17 -0500 (EST) The big and only question is whether anyone can actually use any of this stuff without your proprietary bits? And BTW vm-crosst...@vmware.com bounces, take it out of the CC: list on all future emails. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] VSOCK for Linux upstreaming
Sasha, There is a 'brief' implementation notes aboutVSOCK protocol family in af_vsock.c. More about user space layer socket programming is from VMCI Socket Programming Guide. (remove crosst...@vmware.com for email bouncing). thanks, George - Original Message - From: Sasha Levin levinsasha...@gmail.com To: George Zhang georgezh...@vmware.com Cc: net...@vger.kernel.org, linux-kernel@vger.kernel.org, virtualizat...@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, da...@davemloft.net, gre...@linuxfoundation.org Sent: Monday, November 5, 2012 10:23:02 AM Subject: Re: [PATCH 0/6] VSOCK for Linux upstreaming Hi George, On Mon, Nov 5, 2012 at 1:00 PM, George Zhang georgezh...@vmware.com wrote: For additional information about the use of VMCI and in particular VMCI Sockets, please refer to the VMCI Socket Programming Guide available at https://www.vmware.com/support/developer/vmci-sdk/. Is there documentation about the protocol itself? I couldn't find it on the link above. Thanks, Sasha -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
