Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support
On Tue, Feb 09, 2021 at 03:11:41PM +0100, Andrew Lunn wrote: > > Regarding splitting the series up. I don't see a problem in just > > sending the cover-letter patch and actual GPIO-related patches to > > the GPIO-maintainers with no need to have them added to Cc in the rest > > of the series. > > The Linux community has to handle a large number of patches. I don't > particularly want patches which are of no relevance to me landing in > my mailbox. It might take 4 or 5 rounds for the preparation patches to > be accepted. That is 4 or 5 times you are spamming the GPIO > maintainers with stuff which is not relevant to them. I don't really understand what you are arguing with. My suggestion didn't contradict to what you said. I exactly meant to omit sending the patches to GPIO maintainers, which they had no relevance to. So they wouldn't be spammed with unwanted patches. The GPIO maintainers can be Cc/To-ed only to the messages with GPIO-related patches. It's normal to have intermixed patchsets, but to post individual patches to the maintainers they might be interested in or they need to review. So splitting up isn't required in this case. Moreover doing as you suggest would extend the time of the patches review with no really much gain in the emailing activity optimization. > > One of the unfortunately things about the kernel process is, there are > a lot of developers, and not many maintainers. So the processes need > to make the life of maintainers easier, and not spamming them helps. Can't argue with that.) -Sergey > >Andrew
Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support
> Regarding splitting the series up. I don't see a problem in just > sending the cover-letter patch and actual GPIO-related patches to > the GPIO-maintainers with no need to have them added to Cc in the rest > of the series. The Linux community has to handle a large number of patches. I don't particularly want patches which are of no relevance to me landing in my mailbox. It might take 4 or 5 rounds for the preparation patches to be accepted. That is 4 or 5 times you are spamming the GPIO maintainers with stuff which is not relevant to them. One of the unfortunately things about the kernel process is, there are a lot of developers, and not many maintainers. So the processes need to make the life of maintainers easier, and not spamming them helps. Andrew
Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support
On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: > > Hi Serge > > I suggest you split this patchset up. This uses the generic GPIO > framework, which is great. But that also means you should be Cc: the > GPIO subsystem maintainers and list. But you don't want to spam them > with all the preparation work, which has little to do with the GPIO > code. > > So please split the actual GPIO driver and DT binding patches from the > rest. netdev can review the preparation work, with a comment in the > 0/X patch about what the big picture is, and then afterwards review > the GPIO patchset with a wider audience. > > And as Jakub pointed out, nobody is going to review 60 patches all at > once. Please submit one series at a time, get it merged, and then > move onto the next. Hello Andrew Right, with all that preparation work I've forgotten to Cc the GPIO-subsystem maintainers. Thanks for noticing this. Regarding the 60-patches. Please see my response to Jakub' post in the first series. To cut it short let's start working with that patchset: Link: https://lore.kernel.org/netdev/20210208135609.7685-1-sergey.se...@baikalelectronics.ru/ I'll rebase and resubmit the rest of the work when the time comes. Regarding splitting the series up. I don't see a problem in just sending the cover-letter patch and actual GPIO-related patches to the GPIO-maintainers with no need to have them added to Cc in the rest of the series. That's a normal practice. Splitting is not really required. But since I have to split the very first patchset anyway. I'll split this one up too, when it comes to have this part of changes reviewed. -Sergey > >Andrew
Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support
On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: Hi Serge I suggest you split this patchset up. This uses the generic GPIO framework, which is great. But that also means you should be Cc: the GPIO subsystem maintainers and list. But you don't want to spam them with all the preparation work, which has little to do with the GPIO code. So please split the actual GPIO driver and DT binding patches from the rest. netdev can review the preparation work, with a comment in the 0/X patch about what the big picture is, and then afterwards review the GPIO patchset with a wider audience. And as Jakub pointed out, nobody is going to review 60 patches all at once. Please submit one series at a time, get it merged, and then move onto the next. Andrew
