Re: [PATCH 02/26] fscrypto: Constify struct inode pointer
Ted, On 21.10.2016 16:57, Theodore Ts'o wrote: > On Fri, Oct 21, 2016 at 02:48:17PM +0200, Richard Weinberger wrote: >> Some filesystems, such as UBIFS, maintain a const pointer >> for struct inode. >> >> /* fname.c */ >> -extern int fscrypt_setup_filename(struct inode *, const struct qstr *, >> -int lookup, struct fscrypt_name *); >> +extern int fscrypt_setup_filename(struct inode *dir, const struct qstr >> *iname, >> + int lookup, struct fscrypt_name *fname); > > Was it deliberate that you didn't add a const pointer here? Erm, no. Either I forgot or while rebasing my mess to something sane the change got lost. > I take it that ubifs is basically using const in certain places to > essentially promise that those functions don't actually modify the > inode structure? Yes. Thanks, //richard
Re: [PATCH 02/26] fscrypto: Constify struct inode pointer
Ted, On 21.10.2016 16:57, Theodore Ts'o wrote: > On Fri, Oct 21, 2016 at 02:48:17PM +0200, Richard Weinberger wrote: >> Some filesystems, such as UBIFS, maintain a const pointer >> for struct inode. >> >> /* fname.c */ >> -extern int fscrypt_setup_filename(struct inode *, const struct qstr *, >> -int lookup, struct fscrypt_name *); >> +extern int fscrypt_setup_filename(struct inode *dir, const struct qstr >> *iname, >> + int lookup, struct fscrypt_name *fname); > > Was it deliberate that you didn't add a const pointer here? Erm, no. Either I forgot or while rebasing my mess to something sane the change got lost. > I take it that ubifs is basically using const in certain places to > essentially promise that those functions don't actually modify the > inode structure? Yes. Thanks, //richard
Re: [PATCH 02/26] fscrypto: Constify struct inode pointer
On Fri, Oct 21, 2016 at 02:48:17PM +0200, Richard Weinberger wrote: > Some filesystems, such as UBIFS, maintain a const pointer > for struct inode. > > /* fname.c */ > -extern int fscrypt_setup_filename(struct inode *, const struct qstr *, > - int lookup, struct fscrypt_name *); > +extern int fscrypt_setup_filename(struct inode *dir, const struct qstr > *iname, > +int lookup, struct fscrypt_name *fname); Was it deliberate that you didn't add a const pointer here? I take it that ubifs is basically using const in certain places to essentially promise that those functions don't actually modify the inode structure? - Ted
Re: [PATCH 02/26] fscrypto: Constify struct inode pointer
On Fri, Oct 21, 2016 at 02:48:17PM +0200, Richard Weinberger wrote: > Some filesystems, such as UBIFS, maintain a const pointer > for struct inode. > > /* fname.c */ > -extern int fscrypt_setup_filename(struct inode *, const struct qstr *, > - int lookup, struct fscrypt_name *); > +extern int fscrypt_setup_filename(struct inode *dir, const struct qstr > *iname, > +int lookup, struct fscrypt_name *fname); Was it deliberate that you didn't add a const pointer here? I take it that ubifs is basically using const in certain places to essentially promise that those functions don't actually modify the inode structure? - Ted
