Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr
On Thu, Mar 07, 2013 at 10:49:04PM -0800, Yinghai Lu wrote:
> >> @@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void)
> >> arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
> >>
> >> for (no = 0; no < table_nr; no++) {
> >> - size_t size = early_initrd_files[no].size;
> >> + unsigned long size = early_initrd_files[no].size;
> >>
> >> p = early_ioremap(acpi_tables_addr + total_offset, size);
> >> - memcpy(p, early_initrd_files[no].data, size);
> >> + q = early_ioremap((unsigned long)early_initrd_files[no].data,
> >> + size);
> >> + memcpy(p, q, size);
> >> + early_iounmap(q, size);
> >
> > Ah, okay, so the loop change in the previous patch was for this, I
> > suppose? That chunk probably should either be a separate patch or
> > rolled into this one.
>
> merge two patches?
Hmm... probably better to just move the related chunks from the
previous patch to this one with better explanation on what's going on.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr
On Thu, Mar 7, 2013 at 9:36 PM, Tejun Heo wrote:
> On Thu, Mar 07, 2013 at 08:58:29PM -0800, Yinghai Lu wrote:
>> As later 32bit only find table with phys address during 32bit flat mode
>> in head_32.S.
>>
>> To keep 32bit and 64 bit consistent, use phys_addr for all.
>>
>> Use early_ioremap to access during copying.
>>
>> Signed-off-by: Yinghai Lu
>> Cc: Thomas Renninger
>> Cc: Rafael J. Wysocki
>> Cc: linux-a...@vger.kernel.org
>> ---
>> @@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void)
>> arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
>>
>> for (no = 0; no < table_nr; no++) {
>> - size_t size = early_initrd_files[no].size;
>> + unsigned long size = early_initrd_files[no].size;
>>
>> p = early_ioremap(acpi_tables_addr + total_offset, size);
>> - memcpy(p, early_initrd_files[no].data, size);
>> + q = early_ioremap((unsigned long)early_initrd_files[no].data,
>> + size);
>> + memcpy(p, q, size);
>> + early_iounmap(q, size);
>
> Ah, okay, so the loop change in the previous patch was for this, I
> suppose? That chunk probably should either be a separate patch or
> rolled into this one.
merge two patches?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr
On Thu, Mar 07, 2013 at 08:58:29PM -0800, Yinghai Lu wrote:
> As later 32bit only find table with phys address during 32bit flat mode
> in head_32.S.
>
> To keep 32bit and 64 bit consistent, use phys_addr for all.
>
> Use early_ioremap to access during copying.
>
> Signed-off-by: Yinghai Lu
> Cc: Thomas Renninger
> Cc: Rafael J. Wysocki
> Cc: linux-a...@vger.kernel.org
> ---
> @@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void)
> arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
>
> for (no = 0; no < table_nr; no++) {
> - size_t size = early_initrd_files[no].size;
> + unsigned long size = early_initrd_files[no].size;
>
> p = early_ioremap(acpi_tables_addr + total_offset, size);
> - memcpy(p, early_initrd_files[no].data, size);
> + q = early_ioremap((unsigned long)early_initrd_files[no].data,
> + size);
> + memcpy(p, q, size);
> + early_iounmap(q, size);
Ah, okay, so the loop change in the previous patch was for this, I
suppose? That chunk probably should either be a separate patch or
rolled into this one.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr
On Thu, Mar 07, 2013 at 08:58:29PM -0800, Yinghai Lu wrote:
As later 32bit only find table with phys address during 32bit flat mode
in head_32.S.
To keep 32bit and 64 bit consistent, use phys_addr for all.
Use early_ioremap to access during copying.
Signed-off-by: Yinghai Lu ying...@kernel.org
Cc: Thomas Renninger tr...@suse.de
Cc: Rafael J. Wysocki r...@sisk.pl
Cc: linux-a...@vger.kernel.org
---
@@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void)
arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
for (no = 0; no table_nr; no++) {
- size_t size = early_initrd_files[no].size;
+ unsigned long size = early_initrd_files[no].size;
p = early_ioremap(acpi_tables_addr + total_offset, size);
- memcpy(p, early_initrd_files[no].data, size);
+ q = early_ioremap((unsigned long)early_initrd_files[no].data,
+ size);
+ memcpy(p, q, size);
+ early_iounmap(q, size);
Ah, okay, so the loop change in the previous patch was for this, I
suppose? That chunk probably should either be a separate patch or
rolled into this one.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr
On Thu, Mar 7, 2013 at 9:36 PM, Tejun Heo t...@kernel.org wrote:
On Thu, Mar 07, 2013 at 08:58:29PM -0800, Yinghai Lu wrote:
As later 32bit only find table with phys address during 32bit flat mode
in head_32.S.
To keep 32bit and 64 bit consistent, use phys_addr for all.
Use early_ioremap to access during copying.
Signed-off-by: Yinghai Lu ying...@kernel.org
Cc: Thomas Renninger tr...@suse.de
Cc: Rafael J. Wysocki r...@sisk.pl
Cc: linux-a...@vger.kernel.org
---
@@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void)
arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
for (no = 0; no table_nr; no++) {
- size_t size = early_initrd_files[no].size;
+ unsigned long size = early_initrd_files[no].size;
p = early_ioremap(acpi_tables_addr + total_offset, size);
- memcpy(p, early_initrd_files[no].data, size);
+ q = early_ioremap((unsigned long)early_initrd_files[no].data,
+ size);
+ memcpy(p, q, size);
+ early_iounmap(q, size);
Ah, okay, so the loop change in the previous patch was for this, I
suppose? That chunk probably should either be a separate patch or
rolled into this one.
merge two patches?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr
On Thu, Mar 07, 2013 at 10:49:04PM -0800, Yinghai Lu wrote:
@@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void)
arch_reserve_mem_area(acpi_tables_addr, all_tables_size);
for (no = 0; no table_nr; no++) {
- size_t size = early_initrd_files[no].size;
+ unsigned long size = early_initrd_files[no].size;
p = early_ioremap(acpi_tables_addr + total_offset, size);
- memcpy(p, early_initrd_files[no].data, size);
+ q = early_ioremap((unsigned long)early_initrd_files[no].data,
+ size);
+ memcpy(p, q, size);
+ early_iounmap(q, size);
Ah, okay, so the loop change in the previous patch was for this, I
suppose? That chunk probably should either be a separate patch or
rolled into this one.
merge two patches?
Hmm... probably better to just move the related chunks from the
previous patch to this one with better explanation on what's going on.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
