Re: [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for ->set_affinity()
On Fri, Oct 24, 2014 at 01:59:16PM +0200, Thomas Petazzoni wrote: > The ->set_affinity() hook of 'struct irq_chip' is supposed to return > one of IRQ_SET_MASK_OK or IRQ_SET_MASK_OK_NOCOPY. However, the code > currently simply returns 0. This patch fixes that by using > IRQ_SET_MASK_OK, which tells the IRQ core that it is responsible for > updating irq_data.affinity. > > Note that this patch does not cause any change to the compiled code, > as IRQ_SET_MASK_OK has the value 0. This is therefore just a simple > cleanup. > > Signed-off-by: Thomas Petazzoni > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: linux-kernel@vger.kernel.org > --- > drivers/irqchip/irq-armada-370-xp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to irqchip/core with Gregory's Reviewed-by. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for -set_affinity()
On Fri, Oct 24, 2014 at 01:59:16PM +0200, Thomas Petazzoni wrote: The -set_affinity() hook of 'struct irq_chip' is supposed to return one of IRQ_SET_MASK_OK or IRQ_SET_MASK_OK_NOCOPY. However, the code currently simply returns 0. This patch fixes that by using IRQ_SET_MASK_OK, which tells the IRQ core that it is responsible for updating irq_data.affinity. Note that this patch does not cause any change to the compiled code, as IRQ_SET_MASK_OK has the value 0. This is therefore just a simple cleanup. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Thomas Gleixner t...@linutronix.de Cc: Jason Cooper ja...@lakedaemon.net Cc: linux-kernel@vger.kernel.org --- drivers/irqchip/irq-armada-370-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to irqchip/core with Gregory's Reviewed-by. thx, Jason. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for ->set_affinity()
Hi Thomas, On 24/10/2014 13:59, Thomas Petazzoni wrote: > The ->set_affinity() hook of 'struct irq_chip' is supposed to return > one of IRQ_SET_MASK_OK or IRQ_SET_MASK_OK_NOCOPY. However, the code > currently simply returns 0. This patch fixes that by using > IRQ_SET_MASK_OK, which tells the IRQ core that it is responsible for > updating irq_data.affinity. It seems that this driver is not the only one to return 0 instead of IRQ_SET_MASK_OK in the >set_affinity(). I found also irq-xtensa-mx.c, irq-metag.c and irq-metag-ext.c. > > Note that this patch does not cause any change to the compiled code, > as IRQ_SET_MASK_OK has the value 0. This is therefore just a simple > cleanup. > > Signed-off-by: Thomas Petazzoni > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: linux-kernel@vger.kernel.org > --- > drivers/irqchip/irq-armada-370-xp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gregory CLEMENT Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for -set_affinity()
Hi Thomas, On 24/10/2014 13:59, Thomas Petazzoni wrote: The -set_affinity() hook of 'struct irq_chip' is supposed to return one of IRQ_SET_MASK_OK or IRQ_SET_MASK_OK_NOCOPY. However, the code currently simply returns 0. This patch fixes that by using IRQ_SET_MASK_OK, which tells the IRQ core that it is responsible for updating irq_data.affinity. It seems that this driver is not the only one to return 0 instead of IRQ_SET_MASK_OK in the set_affinity(). I found also irq-xtensa-mx.c, irq-metag.c and irq-metag-ext.c. Note that this patch does not cause any change to the compiled code, as IRQ_SET_MASK_OK has the value 0. This is therefore just a simple cleanup. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Thomas Gleixner t...@linutronix.de Cc: Jason Cooper ja...@lakedaemon.net Cc: linux-kernel@vger.kernel.org --- drivers/irqchip/irq-armada-370-xp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gregory CLEMENT gregory.clem...@free-electrons.com Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/