Re: [PATCH 05/16] TTY: add tty_port_tty_wakeup helper
On Fri, Mar 08, 2013 at 08:02:09PM +0100, Jiri Slaby wrote: > On 03/08/2013 04:02 PM, Peter Hurley wrote: > > On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote: > >> It allows for cleaning up on a considerable amount of places. They did > >> port_get, wakeup, kref_put. Now the only thing needed is to call > >> tty_port_tty_wakeup which does exactly that. > >> > >> One exception is ifx6x60 where tty_wakeup was open-coded. We now call > >> tty_wakeup properly there. > >> > >> Signed-off-by: Jiri Slaby > >> --- > >> arch/um/drivers/line.c | 8 +--- > > > > Cc: Jeff Dike > > Cc: Richard Weinberger > > > >> drivers/isdn/capi/capi.c| 7 +-- > > > > Cc: Karsten Keil > > > >> drivers/isdn/gigaset/interface.c| 6 +- > > > > Cc: Hansjoerg Lipp > > Cc: Tilman Schmidt > > Cc: gigaset307x-com...@lists.sourceforge.net > > Cc: net...@vger.kernel.org > > > >> drivers/net/usb/hso.c | 13 ++--- > > > > Cc: Jan Dumon > > Cc: linux-...@vger.kernel.org > > > >> drivers/s390/char/sclp_tty.c| 9 ++--- > >> drivers/s390/char/sclp_vt220.c | 8 +--- > > > > Cc: Martin Schwidefsky > > Cc: Heiko Carstens > > Cc: linux...@de.ibm.com > > Cc: linux-s...@vger.kernel.org > > > >> drivers/staging/fwserial/fwserial.c | 10 ++ > > > > Cc: Me :) > > > >> drivers/staging/serqt_usb2/serqt_usb2.c | 7 +-- > > > > Cc: YAMANE Toshiaki > > Cc: Devendra Naga > > > > and so on... > > > > Same for the other mega-patches. > > I'm not sure whether to CC all the people for such patches. I always > tended not to and instead rely on people reading LKML :P. > > If this is the preferred way, I of course can do it next time. It's nice to at least cc: driver maintainers if you can, you can script get_maintainers.pl to do this for you. But don't worry about it this time. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 05/16] TTY: add tty_port_tty_wakeup helper
On 03/08/2013 04:02 PM, Peter Hurley wrote: > On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote: >> It allows for cleaning up on a considerable amount of places. They did >> port_get, wakeup, kref_put. Now the only thing needed is to call >> tty_port_tty_wakeup which does exactly that. >> >> One exception is ifx6x60 where tty_wakeup was open-coded. We now call >> tty_wakeup properly there. >> >> Signed-off-by: Jiri Slaby >> --- >> arch/um/drivers/line.c | 8 +--- > > Cc: Jeff Dike > Cc: Richard Weinberger > >> drivers/isdn/capi/capi.c| 7 +-- > > Cc: Karsten Keil > >> drivers/isdn/gigaset/interface.c| 6 +- > > Cc: Hansjoerg Lipp > Cc: Tilman Schmidt > Cc: gigaset307x-com...@lists.sourceforge.net > Cc: net...@vger.kernel.org > >> drivers/net/usb/hso.c | 13 ++--- > > Cc: Jan Dumon > Cc: linux-...@vger.kernel.org > >> drivers/s390/char/sclp_tty.c| 9 ++--- >> drivers/s390/char/sclp_vt220.c | 8 +--- > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux...@de.ibm.com > Cc: linux-s...@vger.kernel.org > >> drivers/staging/fwserial/fwserial.c | 10 ++ > > Cc: Me :) > >> drivers/staging/serqt_usb2/serqt_usb2.c | 7 +-- > > Cc: YAMANE Toshiaki > Cc: Devendra Naga > > and so on... > > Same for the other mega-patches. I'm not sure whether to CC all the people for such patches. I always tended not to and instead rely on people reading LKML :P. If this is the preferred way, I of course can do it next time. -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 05/16] TTY: add tty_port_tty_wakeup helper
On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote: > It allows for cleaning up on a considerable amount of places. They did > port_get, wakeup, kref_put. Now the only thing needed is to call > tty_port_tty_wakeup which does exactly that. > > One exception is ifx6x60 where tty_wakeup was open-coded. We now call > tty_wakeup properly there. > > Signed-off-by: Jiri Slaby > --- > arch/um/drivers/line.c | 8 +--- Cc: Jeff Dike Cc: Richard Weinberger > drivers/isdn/capi/capi.c| 7 +-- Cc: Karsten Keil > drivers/isdn/gigaset/interface.c| 6 +- Cc: Hansjoerg Lipp Cc: Tilman Schmidt Cc: gigaset307x-com...@lists.sourceforge.net Cc: net...@vger.kernel.org > drivers/net/usb/hso.c | 13 ++--- Cc: Jan Dumon Cc: linux-...@vger.kernel.org > drivers/s390/char/sclp_tty.c| 9 ++--- > drivers/s390/char/sclp_vt220.c | 8 +--- Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux...@de.ibm.com Cc: linux-s...@vger.kernel.org > drivers/staging/fwserial/fwserial.c | 10 ++ Cc: Me :) > drivers/staging/serqt_usb2/serqt_usb2.c | 7 +-- Cc: YAMANE Toshiaki Cc: Devendra Naga and so on... Same for the other mega-patches. > drivers/tty/ehv_bytechan.c | 6 +- > drivers/tty/hvc/hvsi.c | 7 +-- > drivers/tty/nozomi.c| 6 +- > drivers/tty/serial/ifx6x60.c| 33 > ++--- > drivers/tty/tty_port.c | 16 > drivers/usb/class/cdc-acm.c | 7 +-- > drivers/usb/serial/digi_acceleport.c| 17 +++-- > drivers/usb/serial/io_edgeport.c| 28 +--- > drivers/usb/serial/keyspan_pda.c| 6 ++ > drivers/usb/serial/mos7720.c| 8 ++-- > drivers/usb/serial/mos7840.c| 7 ++- > drivers/usb/serial/ti_usb_3410_5052.c | 7 ++- > drivers/usb/serial/usb-serial.c | 10 +- > include/linux/tty.h | 1 + > 22 files changed, 51 insertions(+), 176 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
