Re: [PATCH 06/16] perf, persistent: Return -EACCES if mapped buffers must be readonly
On Fri, May 31, 2013 at 10:47:26AM +0200, Robert Richter wrote: > From: Robert Richter > > mmap should return EACCES error if fd can not be opened writable. > This error code also helps userland to map buffers readonly on > failure. > > Signed-off-by: Robert Richter > --- > kernel/events/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 0730f36..a9b6470 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -3761,7 +3761,7 @@ static int perf_mmap(struct file *file, struct > vm_area_struct *vma) > return -EINVAL; > > if (event->attr.persistent && (vma->vm_flags & VM_WRITE)) > - return -EINVAL; > + return -EACCES; > > vma_size = vma->vm_end - vma->vm_start; > nr_pages = (vma_size / PAGE_SIZE) - 1; Also merge. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/16] perf, persistent: Return -EACCES if mapped buffers must be readonly
On Fri, May 31, 2013 at 10:47:26AM +0200, Robert Richter wrote: From: Robert Richter robert.rich...@calxeda.com mmap should return EACCES error if fd can not be opened writable. This error code also helps userland to map buffers readonly on failure. Signed-off-by: Robert Richter robert.rich...@calxeda.com --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 0730f36..a9b6470 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -3761,7 +3761,7 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma) return -EINVAL; if (event-attr.persistent (vma-vm_flags VM_WRITE)) - return -EINVAL; + return -EACCES; vma_size = vma-vm_end - vma-vm_start; nr_pages = (vma_size / PAGE_SIZE) - 1; Also merge. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
