Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES
On Wed, 7 Nov 2012 10:55:03 +0100 Lee Jones wrote: > It doesn't make much sense to enable ISDN services if you don't > intend to connect to a network. I would disagree. However what I don't understand and you've not explained is why the current code is a bug or a problem ? This seems to be a make-work inconvenience causing patch that serves no useful purpose ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES
From: Alan Cox Date: Wed, 7 Nov 2012 15:04:36 + > On Wed, 7 Nov 2012 10:55:03 +0100 > Lee Jones wrote: > >> It doesn't make much sense to enable ISDN services if you don't >> intend to connect to a network. > > I would disagree. However what I don't understand and you've not > explained is why the current code is a bug or a problem ? > > This seems to be a make-work inconvenience causing patch that serves no > useful purpose ? The ISDN drivers are peppered with CONFIG_NETDEVICES protection, but there are missing cases in several locations. This is ugly, and causes build problems, so adding the dependency is the cleanest and most correct soluation and I fully intend to apply this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES
From: Lee Jones Date: Wed, 7 Nov 2012 10:55:03 +0100 > It doesn't make much sense to enable ISDN services if you don't > intend to connect to a network. Therefore insisting that ISDN > depends on NETDEVICES seems logical. We can then remove any > guards mentioning NETDEVICES inside all subordinate drivers. > > This also has the nice side-effect of fixing the warning below > when ISDN_I4L && !CONFIG_NETDEVICES at compile time. > > This patch fixes: > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ > [-Wunused-variable] > > Cc: Karsten Keil > Cc: net...@vger.kernel.org > Signed-off-by: Lee Jones Applied, thanks.
Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES
Am 07.11.2012 10:55, schrieb Lee Jones: > It doesn't make much sense to enable ISDN services if you don't > intend to connect to a network. Therefore insisting that ISDN > depends on NETDEVICES seems logical. Well, not quite. ISDN is (was?) also used for telephony applications which could work just fine without network devices. But I guess not many kernels will actually be built with CONFIG_NETDEVICES=n, so the inconvenience is small. -- Tilman SchmidtE-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) signature.asc Description: OpenPGP digital signature
