Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
On 09/20/2012 08:26 PM, Matthew Garrett wrote: On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the device. Does that still work? Yes, the ACPI interpreter is initialised earlier than the IPMI driver discovery. Cool, I'm good with these, then. Thanks, -corey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: > On 09/20/2012 04:46 PM, Matthew Garrett wrote: > >Drivers may make calls that require the ACPI IPMI driver to have been > >initialised already, so make sure that it appears earlier in the build > >order. > > The IPMI driver uses the ACPI namespace as an option to know the > address and characteristics of the device. Does that still work? Yes, the ACPI interpreter is initialised earlier than the IPMI driver discovery. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the device. Does that still work? -corey Signed-off-by: Matthew Garrett --- drivers/acpi/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 47199e2..82422fe 100644 --- a/drivers/acpi/Makefile +++ b/drivers/acpi/Makefile @@ -47,6 +47,10 @@ acpi-y += video_detect.o endif # These are (potentially) separate modules + +# IPMI may be used by other drivers, so it has to initialise before them +obj-$(CONFIG_ACPI_IPMI)+= acpi_ipmi.o + obj-$(CONFIG_ACPI_AC) += ac.o obj-$(CONFIG_ACPI_BUTTON) += button.o obj-$(CONFIG_ACPI_FAN)+= fan.o @@ -70,6 +74,5 @@ processor-y += processor_idle.o processor_thermal.o processor-$(CONFIG_CPU_FREQ) += processor_perflib.o obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o -obj-$(CONFIG_ACPI_IPMI)+= acpi_ipmi.o obj-$(CONFIG_ACPI_APEI) += apei/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the device. Does that still work? -corey Signed-off-by: Matthew Garrett m...@redhat.com --- drivers/acpi/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 47199e2..82422fe 100644 --- a/drivers/acpi/Makefile +++ b/drivers/acpi/Makefile @@ -47,6 +47,10 @@ acpi-y += video_detect.o endif # These are (potentially) separate modules + +# IPMI may be used by other drivers, so it has to initialise before them +obj-$(CONFIG_ACPI_IPMI)+= acpi_ipmi.o + obj-$(CONFIG_ACPI_AC) += ac.o obj-$(CONFIG_ACPI_BUTTON) += button.o obj-$(CONFIG_ACPI_FAN)+= fan.o @@ -70,6 +74,5 @@ processor-y += processor_idle.o processor_thermal.o processor-$(CONFIG_CPU_FREQ) += processor_perflib.o obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o -obj-$(CONFIG_ACPI_IPMI)+= acpi_ipmi.o obj-$(CONFIG_ACPI_APEI) += apei/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the device. Does that still work? Yes, the ACPI interpreter is initialised earlier than the IPMI driver discovery. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ACPI: Reorder IPMI driver before any other ACPI drivers
On 09/20/2012 08:26 PM, Matthew Garrett wrote: On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: On 09/20/2012 04:46 PM, Matthew Garrett wrote: Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the device. Does that still work? Yes, the ACPI interpreter is initialised earlier than the IPMI driver discovery. Cool, I'm good with these, then. Thanks, -corey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
