Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-10 Thread Krzysztof Kozlowski 
On 06/10/2016 08:13 AM, Krzysztof Kozlowski wrote:
> On 06/10/2016 07:35 AM, Chris Lapa wrote:
>> Hi Krzysztof,
>>
>> Thanks for the review. I'm working on those changes now.
>>
>> However just so I know for the future. Why no error checking on
>> devm_kzalloc() result? Looking through the source for devm_kzalloc() it
>> looks like NULL isn't caught anywhere else.
> 
> Error checking is necessary. Just do not print the error message. The
> kernel core will print one with full back trace.
> 
> if (charger == NULL)
>   return -ENOMEM;

... and while at it just convert it to simpler:
if (!charger)
return -ENOMEM;

BR,
Krzysztof

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-10 Thread Krzysztof Kozlowski 
On 06/10/2016 08:13 AM, Krzysztof Kozlowski wrote:
> On 06/10/2016 07:35 AM, Chris Lapa wrote:
>> Hi Krzysztof,
>>
>> Thanks for the review. I'm working on those changes now.
>>
>> However just so I know for the future. Why no error checking on
>> devm_kzalloc() result? Looking through the source for devm_kzalloc() it
>> looks like NULL isn't caught anywhere else.
> 
> Error checking is necessary. Just do not print the error message. The
> kernel core will print one with full back trace.
> 
> if (charger == NULL)
>   return -ENOMEM;

... and while at it just convert it to simpler:
if (!charger)
return -ENOMEM;

BR,
Krzysztof

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-10 Thread Krzysztof Kozlowski 
On 06/10/2016 07:35 AM, Chris Lapa wrote:
> Hi Krzysztof,
> 
> Thanks for the review. I'm working on those changes now.
> 
> However just so I know for the future. Why no error checking on
> devm_kzalloc() result? Looking through the source for devm_kzalloc() it
> looks like NULL isn't caught anywhere else.

Error checking is necessary. Just do not print the error message. The
kernel core will print one with full back trace.

if (charger == NULL)
return -ENOMEM;


Best regards,
Krzysztof

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-10 Thread Krzysztof Kozlowski 
On 06/10/2016 07:35 AM, Chris Lapa wrote:
> Hi Krzysztof,
> 
> Thanks for the review. I'm working on those changes now.
> 
> However just so I know for the future. Why no error checking on
> devm_kzalloc() result? Looking through the source for devm_kzalloc() it
> looks like NULL isn't caught anywhere else.

Error checking is necessary. Just do not print the error message. The
kernel core will print one with full back trace.

if (charger == NULL)
return -ENOMEM;


Best regards,
Krzysztof

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-09 Thread Chris Lapa 

Hi Krzysztof,

Thanks for the review. I'm working on those changes now.

However just so I know for the future. Why no error checking on 
devm_kzalloc() result? Looking through the source for devm_kzalloc() it 
looks like NULL isn't caught anywhere else.


Thanks,
Chris

On 9/06/2016 8:35 PM, Krzysztof Kozlowski wrote:

Hi,

Thanks for your contribution. Few comments below:

On Thu, Jun 2, 2016 at 8:44 AM,   wrote:

From: Chris Lapa 

This commit also adds requesting gpio's via devm_gpio_request() to ensure
the gpio is available for usage by the driver.

Signed-off-by: Chris Lapa 
---
 .../devicetree/bindings/power/max8903-charger.txt  |  28 ++
 drivers/power/max8903_charger.c| 281 -
 2 files changed, 250 insertions(+), 59 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt


Please put the bindings documentation in separate, first patch.



diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
b/Documentation/devicetree/bindings/power/max8903-charger.txt
new file mode 100644
index 000..7207731
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
@@ -0,0 +1,28 @@
+Maxim Semiconductor MAX8903 Battery Charger bindings
+
+Required properties:
+- compatible: "max8903-charger" for MAX8903 Battery Charger


Needs a 'maxim,' prefix.


+- dc_valid:
+   - dok: DC power OK pin
+- usb_valid:
+   - uok: USB power OK pin


I don't understand the explanation of them - dok/uok. What do you want
to say here?


+
+Optional properties:
+- cen: Charge enable pin
+- chg: Charger status pin
+- flt: Fault pin
+- dcm: Current limit mode setting (DC or USB)
+- usus: USB suspend pin


Each gpio should be suffixed with '-gpios' (see
Documentation/devicetree/bindings/gpio/gpio.txt).


+
+
+Example:
+
+   max8903-charger {
+   compatible = "max8903-charger";
+   dok = < 3 GPIO_ACTIVE_LOW>;
+   flt = < 2 GPIO_ACTIVE_LOW>;
+   chg = < 15 GPIO_ACTIVE_LOW>;
+   cen = < 5 GPIO_ACTIVE_LOW>;
+   dc_valid;
+   status = "okay";
+   };
diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c
index 17876ca..1989c10 100644
--- a/drivers/power/max8903_charger.c
+++ b/drivers/power/max8903_charger.c
@@ -23,13 +23,16 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
 #include 

 struct max8903_data {
-   struct max8903_pdata pdata;
+   struct max8903_pdata *pdata;
struct device *dev;
struct power_supply *psy;
struct power_supply_desc psy_desc;
@@ -53,8 +56,8 @@ static int max8903_get_property(struct power_supply *psy,
switch (psp) {
case POWER_SUPPLY_PROP_STATUS:
val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
-   if (data->pdata.chg) {
-   if (gpio_get_value(data->pdata.chg) == 0)
+   if (data->pdata->chg) {
+   if (gpio_get_value(data->pdata->chg) == 0)
val->intval = POWER_SUPPLY_STATUS_CHARGING;
else if (data->usb_in || data->ta_in)
val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
@@ -75,13 +78,14 @@ static int max8903_get_property(struct power_supply *psy,
default:
return -EINVAL;
}
+
return 0;
 }

 static irqreturn_t max8903_dcin(int irq, void *_data)
 {
struct max8903_data *data = _data;
-   struct max8903_pdata *pdata = >pdata;
+   struct max8903_pdata *pdata = data->pdata;
bool ta_in;
enum power_supply_type old_type;

@@ -122,7 +126,7 @@ static irqreturn_t max8903_dcin(int irq, void *_data)
 static irqreturn_t max8903_usbin(int irq, void *_data)
 {
struct max8903_data *data = _data;
-   struct max8903_pdata *pdata = >pdata;
+   struct max8903_pdata *pdata = data->pdata;
bool usb_in;
enum power_supply_type old_type;

@@ -161,7 +165,7 @@ static irqreturn_t max8903_usbin(int irq, void *_data)
 static irqreturn_t max8903_fault(int irq, void *_data)
 {
struct max8903_data *data = _data;
-   struct max8903_pdata *pdata = >pdata;
+   struct max8903_pdata *pdata = data->pdata;
bool fault;

fault = gpio_get_value(pdata->flt) ? false : true;
@@ -179,34 +183,135 @@ static irqreturn_t max8903_fault(int irq, void *_data)
return IRQ_HANDLED;
 }

+static struct max8903_pdata *max8903_parse_dt_data(
+   struct device *dev)
+{
+   struct device_node *of_node = dev->of_node;
+   struct max8903_pdata *pdata = NULL;
+
+   if (!of_node) {
+   return pdata;
+   }


Run a scripts/checkpatch.pl. In general the {} are not needed for
single statements.


+
+   pdata = devm_kzalloc(dev, sizeof(struct max8903_pdata),
+

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-09 Thread Chris Lapa 

Hi Krzysztof,

Thanks for the review. I'm working on those changes now.

However just so I know for the future. Why no error checking on 
devm_kzalloc() result? Looking through the source for devm_kzalloc() it 
looks like NULL isn't caught anywhere else.


Thanks,
Chris

On 9/06/2016 8:35 PM, Krzysztof Kozlowski wrote:

Hi,

Thanks for your contribution. Few comments below:

On Thu, Jun 2, 2016 at 8:44 AM,   wrote:

From: Chris Lapa 

This commit also adds requesting gpio's via devm_gpio_request() to ensure
the gpio is available for usage by the driver.

Signed-off-by: Chris Lapa 
---
 .../devicetree/bindings/power/max8903-charger.txt  |  28 ++
 drivers/power/max8903_charger.c| 281 -
 2 files changed, 250 insertions(+), 59 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt


Please put the bindings documentation in separate, first patch.



diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
b/Documentation/devicetree/bindings/power/max8903-charger.txt
new file mode 100644
index 000..7207731
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
@@ -0,0 +1,28 @@
+Maxim Semiconductor MAX8903 Battery Charger bindings
+
+Required properties:
+- compatible: "max8903-charger" for MAX8903 Battery Charger


Needs a 'maxim,' prefix.


+- dc_valid:
+   - dok: DC power OK pin
+- usb_valid:
+   - uok: USB power OK pin


I don't understand the explanation of them - dok/uok. What do you want
to say here?


+
+Optional properties:
+- cen: Charge enable pin
+- chg: Charger status pin
+- flt: Fault pin
+- dcm: Current limit mode setting (DC or USB)
+- usus: USB suspend pin


Each gpio should be suffixed with '-gpios' (see
Documentation/devicetree/bindings/gpio/gpio.txt).


+
+
+Example:
+
+   max8903-charger {
+   compatible = "max8903-charger";
+   dok = < 3 GPIO_ACTIVE_LOW>;
+   flt = < 2 GPIO_ACTIVE_LOW>;
+   chg = < 15 GPIO_ACTIVE_LOW>;
+   cen = < 5 GPIO_ACTIVE_LOW>;
+   dc_valid;
+   status = "okay";
+   };
diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c
index 17876ca..1989c10 100644
--- a/drivers/power/max8903_charger.c
+++ b/drivers/power/max8903_charger.c
@@ -23,13 +23,16 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
 #include 

 struct max8903_data {
-   struct max8903_pdata pdata;
+   struct max8903_pdata *pdata;
struct device *dev;
struct power_supply *psy;
struct power_supply_desc psy_desc;
@@ -53,8 +56,8 @@ static int max8903_get_property(struct power_supply *psy,
switch (psp) {
case POWER_SUPPLY_PROP_STATUS:
val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
-   if (data->pdata.chg) {
-   if (gpio_get_value(data->pdata.chg) == 0)
+   if (data->pdata->chg) {
+   if (gpio_get_value(data->pdata->chg) == 0)
val->intval = POWER_SUPPLY_STATUS_CHARGING;
else if (data->usb_in || data->ta_in)
val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
@@ -75,13 +78,14 @@ static int max8903_get_property(struct power_supply *psy,
default:
return -EINVAL;
}
+
return 0;
 }

 static irqreturn_t max8903_dcin(int irq, void *_data)
 {
struct max8903_data *data = _data;
-   struct max8903_pdata *pdata = >pdata;
+   struct max8903_pdata *pdata = data->pdata;
bool ta_in;
enum power_supply_type old_type;

@@ -122,7 +126,7 @@ static irqreturn_t max8903_dcin(int irq, void *_data)
 static irqreturn_t max8903_usbin(int irq, void *_data)
 {
struct max8903_data *data = _data;
-   struct max8903_pdata *pdata = >pdata;
+   struct max8903_pdata *pdata = data->pdata;
bool usb_in;
enum power_supply_type old_type;

@@ -161,7 +165,7 @@ static irqreturn_t max8903_usbin(int irq, void *_data)
 static irqreturn_t max8903_fault(int irq, void *_data)
 {
struct max8903_data *data = _data;
-   struct max8903_pdata *pdata = >pdata;
+   struct max8903_pdata *pdata = data->pdata;
bool fault;

fault = gpio_get_value(pdata->flt) ? false : true;
@@ -179,34 +183,135 @@ static irqreturn_t max8903_fault(int irq, void *_data)
return IRQ_HANDLED;
 }

+static struct max8903_pdata *max8903_parse_dt_data(
+   struct device *dev)
+{
+   struct device_node *of_node = dev->of_node;
+   struct max8903_pdata *pdata = NULL;
+
+   if (!of_node) {
+   return pdata;
+   }


Run a scripts/checkpatch.pl. In general the {} are not needed for
single statements.


+
+   pdata = devm_kzalloc(dev, sizeof(struct max8903_pdata),
+   GFP_KERNEL);
+   if

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-09 Thread Krzysztof Kozlowski 
Hi,

Thanks for your contribution. Few comments below:

On Thu, Jun 2, 2016 at 8:44 AM,   wrote:
> From: Chris Lapa 
>
> This commit also adds requesting gpio's via devm_gpio_request() to ensure
> the gpio is available for usage by the driver.
>
> Signed-off-by: Chris Lapa 
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  |  28 ++
>  drivers/power/max8903_charger.c| 281 
> -
>  2 files changed, 250 insertions(+), 59 deletions(-)
>  create mode 100644 
> Documentation/devicetree/bindings/power/max8903-charger.txt

Please put the bindings documentation in separate, first patch.

>
> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
> b/Documentation/devicetree/bindings/power/max8903-charger.txt
> new file mode 100644
> index 000..7207731
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
> @@ -0,0 +1,28 @@
> +Maxim Semiconductor MAX8903 Battery Charger bindings
> +
> +Required properties:
> +- compatible: "max8903-charger" for MAX8903 Battery Charger

Needs a 'maxim,' prefix.

> +- dc_valid:
> +   - dok: DC power OK pin
> +- usb_valid:
> +   - uok: USB power OK pin

I don't understand the explanation of them - dok/uok. What do you want
to say here?

> +
> +Optional properties:
> +- cen: Charge enable pin
> +- chg: Charger status pin
> +- flt: Fault pin
> +- dcm: Current limit mode setting (DC or USB)
> +- usus: USB suspend pin

Each gpio should be suffixed with '-gpios' (see
Documentation/devicetree/bindings/gpio/gpio.txt).

> +
> +
> +Example:
> +
> +   max8903-charger {
> +   compatible = "max8903-charger";
> +   dok = < 3 GPIO_ACTIVE_LOW>;
> +   flt = < 2 GPIO_ACTIVE_LOW>;
> +   chg = < 15 GPIO_ACTIVE_LOW>;
> +   cen = < 5 GPIO_ACTIVE_LOW>;
> +   dc_valid;
> +   status = "okay";
> +   };
> diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c
> index 17876ca..1989c10 100644
> --- a/drivers/power/max8903_charger.c
> +++ b/drivers/power/max8903_charger.c
> @@ -23,13 +23,16 @@
>  #include 
>  #include 
>  #include 
> +#include 
> +#include 
> +#include 
>  #include 
>  #include 
>  #include 
>  #include 
>
>  struct max8903_data {
> -   struct max8903_pdata pdata;
> +   struct max8903_pdata *pdata;
> struct device *dev;
> struct power_supply *psy;
> struct power_supply_desc psy_desc;
> @@ -53,8 +56,8 @@ static int max8903_get_property(struct power_supply *psy,
> switch (psp) {
> case POWER_SUPPLY_PROP_STATUS:
> val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
> -   if (data->pdata.chg) {
> -   if (gpio_get_value(data->pdata.chg) == 0)
> +   if (data->pdata->chg) {
> +   if (gpio_get_value(data->pdata->chg) == 0)
> val->intval = POWER_SUPPLY_STATUS_CHARGING;
> else if (data->usb_in || data->ta_in)
> val->intval = 
> POWER_SUPPLY_STATUS_NOT_CHARGING;
> @@ -75,13 +78,14 @@ static int max8903_get_property(struct power_supply *psy,
> default:
> return -EINVAL;
> }
> +
> return 0;
>  }
>
>  static irqreturn_t max8903_dcin(int irq, void *_data)
>  {
> struct max8903_data *data = _data;
> -   struct max8903_pdata *pdata = >pdata;
> +   struct max8903_pdata *pdata = data->pdata;
> bool ta_in;
> enum power_supply_type old_type;
>
> @@ -122,7 +126,7 @@ static irqreturn_t max8903_dcin(int irq, void *_data)
>  static irqreturn_t max8903_usbin(int irq, void *_data)
>  {
> struct max8903_data *data = _data;
> -   struct max8903_pdata *pdata = >pdata;
> +   struct max8903_pdata *pdata = data->pdata;
> bool usb_in;
> enum power_supply_type old_type;
>
> @@ -161,7 +165,7 @@ static irqreturn_t max8903_usbin(int irq, void *_data)
>  static irqreturn_t max8903_fault(int irq, void *_data)
>  {
> struct max8903_data *data = _data;
> -   struct max8903_pdata *pdata = >pdata;
> +   struct max8903_pdata *pdata = data->pdata;
> bool fault;
>
> fault = gpio_get_value(pdata->flt) ? false : true;
> @@ -179,34 +183,135 @@ static irqreturn_t max8903_fault(int irq, void *_data)
> return IRQ_HANDLED;
>  }
>
> +static struct max8903_pdata *max8903_parse_dt_data(
> +   struct device *dev)
> +{
> +   struct device_node *of_node = dev->of_node;
> +   struct max8903_pdata *pdata = NULL;
> +
> +   if (!of_node) {
> +   return pdata;
> +   }

Run a scripts/checkpatch.pl. In general the {} are not needed for
single statements.

> +
> +   pdata = devm_kzalloc(dev, sizeof(struct max8903_pdata),
> +   GFP_KERNEL);
> +   if (!pdata) {
> +

Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

2016-06-09 Thread Krzysztof Kozlowski 
Hi,

Thanks for your contribution. Few comments below:

On Thu, Jun 2, 2016 at 8:44 AM,   wrote:
> From: Chris Lapa 
>
> This commit also adds requesting gpio's via devm_gpio_request() to ensure
> the gpio is available for usage by the driver.
>
> Signed-off-by: Chris Lapa 
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  |  28 ++
>  drivers/power/max8903_charger.c| 281 
> -
>  2 files changed, 250 insertions(+), 59 deletions(-)
>  create mode 100644 
> Documentation/devicetree/bindings/power/max8903-charger.txt

Please put the bindings documentation in separate, first patch.

>
> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt 
> b/Documentation/devicetree/bindings/power/max8903-charger.txt
> new file mode 100644
> index 000..7207731
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
> @@ -0,0 +1,28 @@
> +Maxim Semiconductor MAX8903 Battery Charger bindings
> +
> +Required properties:
> +- compatible: "max8903-charger" for MAX8903 Battery Charger

Needs a 'maxim,' prefix.

> +- dc_valid:
> +   - dok: DC power OK pin
> +- usb_valid:
> +   - uok: USB power OK pin

I don't understand the explanation of them - dok/uok. What do you want
to say here?

> +
> +Optional properties:
> +- cen: Charge enable pin
> +- chg: Charger status pin
> +- flt: Fault pin
> +- dcm: Current limit mode setting (DC or USB)
> +- usus: USB suspend pin

Each gpio should be suffixed with '-gpios' (see
Documentation/devicetree/bindings/gpio/gpio.txt).

> +
> +
> +Example:
> +
> +   max8903-charger {
> +   compatible = "max8903-charger";
> +   dok = < 3 GPIO_ACTIVE_LOW>;
> +   flt = < 2 GPIO_ACTIVE_LOW>;
> +   chg = < 15 GPIO_ACTIVE_LOW>;
> +   cen = < 5 GPIO_ACTIVE_LOW>;
> +   dc_valid;
> +   status = "okay";
> +   };
> diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c
> index 17876ca..1989c10 100644
> --- a/drivers/power/max8903_charger.c
> +++ b/drivers/power/max8903_charger.c
> @@ -23,13 +23,16 @@
>  #include 
>  #include 
>  #include 
> +#include 
> +#include 
> +#include 
>  #include 
>  #include 
>  #include 
>  #include 
>
>  struct max8903_data {
> -   struct max8903_pdata pdata;
> +   struct max8903_pdata *pdata;
> struct device *dev;
> struct power_supply *psy;
> struct power_supply_desc psy_desc;
> @@ -53,8 +56,8 @@ static int max8903_get_property(struct power_supply *psy,
> switch (psp) {
> case POWER_SUPPLY_PROP_STATUS:
> val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
> -   if (data->pdata.chg) {
> -   if (gpio_get_value(data->pdata.chg) == 0)
> +   if (data->pdata->chg) {
> +   if (gpio_get_value(data->pdata->chg) == 0)
> val->intval = POWER_SUPPLY_STATUS_CHARGING;
> else if (data->usb_in || data->ta_in)
> val->intval = 
> POWER_SUPPLY_STATUS_NOT_CHARGING;
> @@ -75,13 +78,14 @@ static int max8903_get_property(struct power_supply *psy,
> default:
> return -EINVAL;
> }
> +
> return 0;
>  }
>
>  static irqreturn_t max8903_dcin(int irq, void *_data)
>  {
> struct max8903_data *data = _data;
> -   struct max8903_pdata *pdata = >pdata;
> +   struct max8903_pdata *pdata = data->pdata;
> bool ta_in;
> enum power_supply_type old_type;
>
> @@ -122,7 +126,7 @@ static irqreturn_t max8903_dcin(int irq, void *_data)
>  static irqreturn_t max8903_usbin(int irq, void *_data)
>  {
> struct max8903_data *data = _data;
> -   struct max8903_pdata *pdata = >pdata;
> +   struct max8903_pdata *pdata = data->pdata;
> bool usb_in;
> enum power_supply_type old_type;
>
> @@ -161,7 +165,7 @@ static irqreturn_t max8903_usbin(int irq, void *_data)
>  static irqreturn_t max8903_fault(int irq, void *_data)
>  {
> struct max8903_data *data = _data;
> -   struct max8903_pdata *pdata = >pdata;
> +   struct max8903_pdata *pdata = data->pdata;
> bool fault;
>
> fault = gpio_get_value(pdata->flt) ? false : true;
> @@ -179,34 +183,135 @@ static irqreturn_t max8903_fault(int irq, void *_data)
> return IRQ_HANDLED;
>  }
>
> +static struct max8903_pdata *max8903_parse_dt_data(
> +   struct device *dev)
> +{
> +   struct device_node *of_node = dev->of_node;
> +   struct max8903_pdata *pdata = NULL;
> +
> +   if (!of_node) {
> +   return pdata;
> +   }

Run a scripts/checkpatch.pl. In general the {} are not needed for
single statements.

> +
> +   pdata = devm_kzalloc(dev, sizeof(struct max8903_pdata),
> +   GFP_KERNEL);
> +   if (!pdata) {
> +   return pdata;

ditto

> +   }
> +
> +