Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
2018-07-03 5:50 GMT+09:00 Randy Dunlap : > On 07/02/18 13:41, Randy Dunlap wrote: > >> --- linux-next-20180702.orig/init/Kconfig >> +++ linux-next-20180702/init/Kconfig >> @@ -1717,6 +1717,12 @@ config PROFILING >> config TRACEPOINTS >> bool >> >> +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig >> +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS >> +# before the default value is found in arch/Kconfig. >> + >> +source "arch/$(SRCARCH)/Kconfig" >> + >> source "arch/Kconfig" >> >> endmenu # General setup >> > > except that the endmenu should be moved up a few lines so that the > Processor type and features menu is not part of the General setup menu. > > v2 patch is below. > > --- > From: Randy Dunlap > > Present "General setup" before "Processor type and features". > This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig > inside init/Kconfig. > > Signed-off-by: Randy Dunlap > --- > v2: move General setup's endmenu before the $ARCH Kconfigs. > > Kconfig |2 -- > init/Kconfig | 10 -- > 2 files changed, 8 insertions(+), 4 deletions(-) > > --- linux-next-20180702.orig/Kconfig > +++ linux-next-20180702/Kconfig > @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" > > source "scripts/Kconfig.include" > > -source "arch/$(SRCARCH)/Kconfig" > - > source "init/Kconfig" > > source "kernel/Kconfig.freezer" > --- linux-next-20180702.orig/init/Kconfig > +++ linux-next-20180702/init/Kconfig > @@ -1717,10 +1717,16 @@ config PROFILING > config TRACEPOINTS > bool > > -source "arch/Kconfig" > - > endmenu# General setup > > +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig > +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS > +# before the default value is found in arch/Kconfig. Is it possible to explain it in a little more generic way? ... so that arch/$(SRCARCH)/Kconfig can override the default values in arch/Kconfig. I am not a native speaker. Please reword it so that it sounds more natural. Thanks. > +source "arch/$(SRCARCH)/Kconfig" > + > +source "arch/Kconfig" > + > config RT_MUTEXES > bool > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
2018-07-03 5:50 GMT+09:00 Randy Dunlap : > On 07/02/18 13:41, Randy Dunlap wrote: > >> --- linux-next-20180702.orig/init/Kconfig >> +++ linux-next-20180702/init/Kconfig >> @@ -1717,6 +1717,12 @@ config PROFILING >> config TRACEPOINTS >> bool >> >> +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig >> +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS >> +# before the default value is found in arch/Kconfig. >> + >> +source "arch/$(SRCARCH)/Kconfig" >> + >> source "arch/Kconfig" >> >> endmenu # General setup >> > > except that the endmenu should be moved up a few lines so that the > Processor type and features menu is not part of the General setup menu. > > v2 patch is below. > > --- > From: Randy Dunlap > > Present "General setup" before "Processor type and features". > This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig > inside init/Kconfig. > > Signed-off-by: Randy Dunlap > --- > v2: move General setup's endmenu before the $ARCH Kconfigs. > > Kconfig |2 -- > init/Kconfig | 10 -- > 2 files changed, 8 insertions(+), 4 deletions(-) > > --- linux-next-20180702.orig/Kconfig > +++ linux-next-20180702/Kconfig > @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" > > source "scripts/Kconfig.include" > > -source "arch/$(SRCARCH)/Kconfig" > - > source "init/Kconfig" > > source "kernel/Kconfig.freezer" > --- linux-next-20180702.orig/init/Kconfig > +++ linux-next-20180702/init/Kconfig > @@ -1717,10 +1717,16 @@ config PROFILING > config TRACEPOINTS > bool > > -source "arch/Kconfig" > - > endmenu# General setup > > +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig > +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS > +# before the default value is found in arch/Kconfig. Is it possible to explain it in a little more generic way? ... so that arch/$(SRCARCH)/Kconfig can override the default values in arch/Kconfig. I am not a native speaker. Please reword it so that it sounds more natural. Thanks. > +source "arch/$(SRCARCH)/Kconfig" > + > +source "arch/Kconfig" > + > config RT_MUTEXES > bool > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
2018-07-04 1:11 GMT+09:00 Randy Dunlap : > On 07/03/18 06:36, Christoph Hellwig wrote: >> On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >>> >>> Ugh, that won't get this set correctly on x86_64: >>> CONFIG_PGTABLE_LEVELS=2 >> >> Did you try it? As far as I can tell modern kconfig isn't really >> order sensitive any more. >> -- > > Yes, it was wrong. :( > > Once the symbol has a default value, it won't be assigned a different > default value (at least that's how it looks; I haven't read the kconfig > source code). > The order does matter. The 'default' properties are accumulated as they appear. If arch/Kconfig were parsed before arch/x86/Kconfig, it would end up with this: config PGTABLE_LEVELS int default 2<- from arch/Kconfig default 5 if X86_5LEVEL <- from arch/x86/Kconfig default 4 if X86_64 <- from arch/x86/Kconfig default 3 if X86_PAE <- from arch/x86/Kconfig default 2<- from arch/x86/Kconfig So, PGTABLE_LEVELS would be always 2. The last four lines are dead code. The correct order is arch/x86/Kconfig, arch/Kconfig then we can get this: config PGTABLE_LEVELS int default 5 if X86_5LEVEL <- from arch/x86/Kconfig default 4 if X86_64 <- from arch/x86/Kconfig default 3 if X86_PAE <- from arch/x86/Kconfig default 2<- from arch/x86/Kconfig default 2<- from arch/Kconfig -- Best Regards Masahiro Yamada
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
2018-07-04 1:11 GMT+09:00 Randy Dunlap : > On 07/03/18 06:36, Christoph Hellwig wrote: >> On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >>> >>> Ugh, that won't get this set correctly on x86_64: >>> CONFIG_PGTABLE_LEVELS=2 >> >> Did you try it? As far as I can tell modern kconfig isn't really >> order sensitive any more. >> -- > > Yes, it was wrong. :( > > Once the symbol has a default value, it won't be assigned a different > default value (at least that's how it looks; I haven't read the kconfig > source code). > The order does matter. The 'default' properties are accumulated as they appear. If arch/Kconfig were parsed before arch/x86/Kconfig, it would end up with this: config PGTABLE_LEVELS int default 2<- from arch/Kconfig default 5 if X86_5LEVEL <- from arch/x86/Kconfig default 4 if X86_64 <- from arch/x86/Kconfig default 3 if X86_PAE <- from arch/x86/Kconfig default 2<- from arch/x86/Kconfig So, PGTABLE_LEVELS would be always 2. The last four lines are dead code. The correct order is arch/x86/Kconfig, arch/Kconfig then we can get this: config PGTABLE_LEVELS int default 5 if X86_5LEVEL <- from arch/x86/Kconfig default 4 if X86_64 <- from arch/x86/Kconfig default 3 if X86_PAE <- from arch/x86/Kconfig default 2<- from arch/x86/Kconfig default 2<- from arch/Kconfig -- Best Regards Masahiro Yamada
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/03/18 06:36, Christoph Hellwig wrote: > On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: >>> I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >> >> Ugh, that won't get this set correctly on x86_64: >> CONFIG_PGTABLE_LEVELS=2 > > Did you try it? As far as I can tell modern kconfig isn't really > order sensitive any more. > -- Yes, it was wrong. :( Once the symbol has a default value, it won't be assigned a different default value (at least that's how it looks; I haven't read the kconfig source code). -- ~Randy
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/03/18 06:36, Christoph Hellwig wrote: > On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: >>> I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >> >> Ugh, that won't get this set correctly on x86_64: >> CONFIG_PGTABLE_LEVELS=2 > > Did you try it? As far as I can tell modern kconfig isn't really > order sensitive any more. > -- Yes, it was wrong. :( Once the symbol has a default value, it won't be assigned a different default value (at least that's how it looks; I haven't read the kconfig source code). -- ~Randy
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: > > I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. > > Ugh, that won't get this set correctly on x86_64: > CONFIG_PGTABLE_LEVELS=2 Did you try it? As far as I can tell modern kconfig isn't really order sensitive any more.
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: > > I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. > > Ugh, that won't get this set correctly on x86_64: > CONFIG_PGTABLE_LEVELS=2 Did you try it? As far as I can tell modern kconfig isn't really order sensitive any more.
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On Mon, Jul 02, 2018 at 01:03:57PM -0700, Randy Dunlap wrote: > Looks good overall. I'm still doing some testing on it. > > I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. > Is there a reason that you chose the ordering above? > Any known dependencies? I don't think there are and I'll give it a spin. The series needs a resend due to arm and user mode linux issues the builtbot found anyway.
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On Mon, Jul 02, 2018 at 01:03:57PM -0700, Randy Dunlap wrote: > Looks good overall. I'm still doing some testing on it. > > I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. > Is there a reason that you chose the ordering above? > Any known dependencies? I don't think there are and I'll give it a spin. The series needs a resend due to arm and user mode linux issues the builtbot found anyway.
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 13:41, Randy Dunlap wrote: > --- linux-next-20180702.orig/init/Kconfig > +++ linux-next-20180702/init/Kconfig > @@ -1717,6 +1717,12 @@ config PROFILING > config TRACEPOINTS > bool > > +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig > +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS > +# before the default value is found in arch/Kconfig. > + > +source "arch/$(SRCARCH)/Kconfig" > + > source "arch/Kconfig" > > endmenu # General setup > except that the endmenu should be moved up a few lines so that the Processor type and features menu is not part of the General setup menu. v2 patch is below. --- From: Randy Dunlap Present "General setup" before "Processor type and features". This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig inside init/Kconfig. Signed-off-by: Randy Dunlap --- v2: move General setup's endmenu before the $ARCH Kconfigs. Kconfig |2 -- init/Kconfig | 10 -- 2 files changed, 8 insertions(+), 4 deletions(-) --- linux-next-20180702.orig/Kconfig +++ linux-next-20180702/Kconfig @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" source "scripts/Kconfig.include" -source "arch/$(SRCARCH)/Kconfig" - source "init/Kconfig" source "kernel/Kconfig.freezer" --- linux-next-20180702.orig/init/Kconfig +++ linux-next-20180702/init/Kconfig @@ -1717,10 +1717,16 @@ config PROFILING config TRACEPOINTS bool -source "arch/Kconfig" - endmenu# General setup +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS +# before the default value is found in arch/Kconfig. + +source "arch/$(SRCARCH)/Kconfig" + +source "arch/Kconfig" + config RT_MUTEXES bool
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 13:41, Randy Dunlap wrote: > --- linux-next-20180702.orig/init/Kconfig > +++ linux-next-20180702/init/Kconfig > @@ -1717,6 +1717,12 @@ config PROFILING > config TRACEPOINTS > bool > > +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig > +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS > +# before the default value is found in arch/Kconfig. > + > +source "arch/$(SRCARCH)/Kconfig" > + > source "arch/Kconfig" > > endmenu # General setup > except that the endmenu should be moved up a few lines so that the Processor type and features menu is not part of the General setup menu. v2 patch is below. --- From: Randy Dunlap Present "General setup" before "Processor type and features". This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig inside init/Kconfig. Signed-off-by: Randy Dunlap --- v2: move General setup's endmenu before the $ARCH Kconfigs. Kconfig |2 -- init/Kconfig | 10 -- 2 files changed, 8 insertions(+), 4 deletions(-) --- linux-next-20180702.orig/Kconfig +++ linux-next-20180702/Kconfig @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" source "scripts/Kconfig.include" -source "arch/$(SRCARCH)/Kconfig" - source "init/Kconfig" source "kernel/Kconfig.freezer" --- linux-next-20180702.orig/init/Kconfig +++ linux-next-20180702/init/Kconfig @@ -1717,10 +1717,16 @@ config PROFILING config TRACEPOINTS bool -source "arch/Kconfig" - endmenu# General setup +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS +# before the default value is found in arch/Kconfig. + +source "arch/$(SRCARCH)/Kconfig" + +source "arch/Kconfig" + config RT_MUTEXES bool
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 07:47, Christoph Hellwig wrote: > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Signed-off-by: Christoph Hellwig > --- > Kconfig | 22 ++ > arch/alpha/Kconfig | 20 > arch/arc/Kconfig| 16 > arch/arm/Kconfig| 25 - > arch/arm64/Kconfig | 23 --- > arch/c6x/Kconfig| 24 > arch/h8300/Kconfig | 24 > arch/hexagon/Kconfig| 16 > arch/ia64/Kconfig | 20 > arch/m68k/Kconfig | 24 > arch/microblaze/Kconfig | 24 > arch/mips/Kconfig | 24 > arch/nds32/Kconfig | 16 > arch/nios2/Kconfig | 24 > arch/openrisc/Kconfig | 23 --- > arch/parisc/Kconfig | 24 > arch/powerpc/Kconfig| 19 --- > arch/riscv/Kconfig | 24 > arch/s390/Kconfig | 24 > arch/sh/Kconfig | 24 > arch/sparc/Kconfig | 24 > arch/unicore32/Kconfig | 24 > arch/x86/Kconfig| 22 +- > arch/xtensa/Kconfig | 25 - > 24 files changed, 23 insertions(+), 512 deletions(-) > > diff --git a/Kconfig b/Kconfig > index a90d9f9e268b..5499b1273ba5 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -10,3 +10,25 @@ comment "Compiler: $(CC_VERSION_TEXT)" > source "scripts/Kconfig.include" > > source "arch/$(SRCARCH)/Kconfig" > + > +source "init/Kconfig" > + > +source "kernel/Kconfig.freezer" > + > +menu "Executable file formats" > +source "fs/Kconfig.binfmt" > +endmenu > + > +source "mm/Kconfig" > + > +source "net/Kconfig" > + > +source "drivers/Kconfig" > + > +source "fs/Kconfig" > + > +source "security/Kconfig" > + > +source "crypto/Kconfig" > + > +source "lib/Kconfig" FWIW, I prefer this modification, but it's not a deal breaker. --- From: Randy Dunlap Present "General setup" before "Processor type and features". This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig inside init/Kconfig. Signed-off-by: Randy Dunlap --- Kconfig |2 -- init/Kconfig |6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) --- linux-next-20180702.orig/Kconfig +++ linux-next-20180702/Kconfig @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" source "scripts/Kconfig.include" -source "arch/$(SRCARCH)/Kconfig" - source "init/Kconfig" source "kernel/Kconfig.freezer" --- linux-next-20180702.orig/init/Kconfig +++ linux-next-20180702/init/Kconfig @@ -1717,6 +1717,12 @@ config PROFILING config TRACEPOINTS bool +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS +# before the default value is found in arch/Kconfig. + +source "arch/$(SRCARCH)/Kconfig" + source "arch/Kconfig" endmenu# General setup
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 07:47, Christoph Hellwig wrote: > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Signed-off-by: Christoph Hellwig > --- > Kconfig | 22 ++ > arch/alpha/Kconfig | 20 > arch/arc/Kconfig| 16 > arch/arm/Kconfig| 25 - > arch/arm64/Kconfig | 23 --- > arch/c6x/Kconfig| 24 > arch/h8300/Kconfig | 24 > arch/hexagon/Kconfig| 16 > arch/ia64/Kconfig | 20 > arch/m68k/Kconfig | 24 > arch/microblaze/Kconfig | 24 > arch/mips/Kconfig | 24 > arch/nds32/Kconfig | 16 > arch/nios2/Kconfig | 24 > arch/openrisc/Kconfig | 23 --- > arch/parisc/Kconfig | 24 > arch/powerpc/Kconfig| 19 --- > arch/riscv/Kconfig | 24 > arch/s390/Kconfig | 24 > arch/sh/Kconfig | 24 > arch/sparc/Kconfig | 24 > arch/unicore32/Kconfig | 24 > arch/x86/Kconfig| 22 +- > arch/xtensa/Kconfig | 25 - > 24 files changed, 23 insertions(+), 512 deletions(-) > > diff --git a/Kconfig b/Kconfig > index a90d9f9e268b..5499b1273ba5 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -10,3 +10,25 @@ comment "Compiler: $(CC_VERSION_TEXT)" > source "scripts/Kconfig.include" > > source "arch/$(SRCARCH)/Kconfig" > + > +source "init/Kconfig" > + > +source "kernel/Kconfig.freezer" > + > +menu "Executable file formats" > +source "fs/Kconfig.binfmt" > +endmenu > + > +source "mm/Kconfig" > + > +source "net/Kconfig" > + > +source "drivers/Kconfig" > + > +source "fs/Kconfig" > + > +source "security/Kconfig" > + > +source "crypto/Kconfig" > + > +source "lib/Kconfig" FWIW, I prefer this modification, but it's not a deal breaker. --- From: Randy Dunlap Present "General setup" before "Processor type and features". This is done by sourcing arch/$(SRCARCH)/Kconfig before arch/Kconfig inside init/Kconfig. Signed-off-by: Randy Dunlap --- Kconfig |2 -- init/Kconfig |6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) --- linux-next-20180702.orig/Kconfig +++ linux-next-20180702/Kconfig @@ -9,8 +9,6 @@ comment "Compiler: $(CC_VERSION_TEXT)" source "scripts/Kconfig.include" -source "arch/$(SRCARCH)/Kconfig" - source "init/Kconfig" source "kernel/Kconfig.freezer" --- linux-next-20180702.orig/init/Kconfig +++ linux-next-20180702/init/Kconfig @@ -1717,6 +1717,12 @@ config PROFILING config TRACEPOINTS bool +# Note: arch/$(SRCARCH)/Kconfig needs to be before arch/Kconfig +# so that each $ARCH can specify its values for CONFIG_PGTABLE_LEVELS +# before the default value is found in arch/Kconfig. + +source "arch/$(SRCARCH)/Kconfig" + source "arch/Kconfig" endmenu# General setup
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 13:03, Randy Dunlap wrote: > On 07/02/18 07:47, Christoph Hellwig wrote: >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Signed-off-by: Christoph Hellwig >> --- >> Kconfig | 22 ++ >> arch/alpha/Kconfig | 20 >> arch/arc/Kconfig| 16 >> arch/arm/Kconfig| 25 - >> arch/arm64/Kconfig | 23 --- >> arch/c6x/Kconfig| 24 >> arch/h8300/Kconfig | 24 >> arch/hexagon/Kconfig| 16 >> arch/ia64/Kconfig | 20 >> arch/m68k/Kconfig | 24 >> arch/microblaze/Kconfig | 24 >> arch/mips/Kconfig | 24 >> arch/nds32/Kconfig | 16 >> arch/nios2/Kconfig | 24 >> arch/openrisc/Kconfig | 23 --- >> arch/parisc/Kconfig | 24 >> arch/powerpc/Kconfig| 19 --- >> arch/riscv/Kconfig | 24 >> arch/s390/Kconfig | 24 >> arch/sh/Kconfig | 24 >> arch/sparc/Kconfig | 24 >> arch/unicore32/Kconfig | 24 >> arch/x86/Kconfig| 22 +- >> arch/xtensa/Kconfig | 25 - >> 24 files changed, 23 insertions(+), 512 deletions(-) >> >> diff --git a/Kconfig b/Kconfig >> index a90d9f9e268b..5499b1273ba5 100644 >> --- a/Kconfig >> +++ b/Kconfig >> @@ -10,3 +10,25 @@ comment "Compiler: $(CC_VERSION_TEXT)" >> source "scripts/Kconfig.include" >> >> source "arch/$(SRCARCH)/Kconfig" >> + >> +source "init/Kconfig" > > Hi Christoph, > > Looks good overall. I'm still doing some testing on it. > > I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. Ugh, that won't get this set correctly on x86_64: CONFIG_PGTABLE_LEVELS=2 > Is there a reason that you chose the ordering above? > Any known dependencies? > > Thanks. > >> + >> +source "kernel/Kconfig.freezer" >> + >> +menu "Executable file formats" >> +source "fs/Kconfig.binfmt" >> +endmenu >> + >> +source "mm/Kconfig" >> + >> +source "net/Kconfig" >> + >> +source "drivers/Kconfig" >> + >> +source "fs/Kconfig" >> + >> +source "security/Kconfig" >> + >> +source "crypto/Kconfig" >> + >> +source "lib/Kconfig" > > -- ~Randy
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 13:03, Randy Dunlap wrote: > On 07/02/18 07:47, Christoph Hellwig wrote: >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Signed-off-by: Christoph Hellwig >> --- >> Kconfig | 22 ++ >> arch/alpha/Kconfig | 20 >> arch/arc/Kconfig| 16 >> arch/arm/Kconfig| 25 - >> arch/arm64/Kconfig | 23 --- >> arch/c6x/Kconfig| 24 >> arch/h8300/Kconfig | 24 >> arch/hexagon/Kconfig| 16 >> arch/ia64/Kconfig | 20 >> arch/m68k/Kconfig | 24 >> arch/microblaze/Kconfig | 24 >> arch/mips/Kconfig | 24 >> arch/nds32/Kconfig | 16 >> arch/nios2/Kconfig | 24 >> arch/openrisc/Kconfig | 23 --- >> arch/parisc/Kconfig | 24 >> arch/powerpc/Kconfig| 19 --- >> arch/riscv/Kconfig | 24 >> arch/s390/Kconfig | 24 >> arch/sh/Kconfig | 24 >> arch/sparc/Kconfig | 24 >> arch/unicore32/Kconfig | 24 >> arch/x86/Kconfig| 22 +- >> arch/xtensa/Kconfig | 25 - >> 24 files changed, 23 insertions(+), 512 deletions(-) >> >> diff --git a/Kconfig b/Kconfig >> index a90d9f9e268b..5499b1273ba5 100644 >> --- a/Kconfig >> +++ b/Kconfig >> @@ -10,3 +10,25 @@ comment "Compiler: $(CC_VERSION_TEXT)" >> source "scripts/Kconfig.include" >> >> source "arch/$(SRCARCH)/Kconfig" >> + >> +source "init/Kconfig" > > Hi Christoph, > > Looks good overall. I'm still doing some testing on it. > > I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. Ugh, that won't get this set correctly on x86_64: CONFIG_PGTABLE_LEVELS=2 > Is there a reason that you chose the ordering above? > Any known dependencies? > > Thanks. > >> + >> +source "kernel/Kconfig.freezer" >> + >> +menu "Executable file formats" >> +source "fs/Kconfig.binfmt" >> +endmenu >> + >> +source "mm/Kconfig" >> + >> +source "net/Kconfig" >> + >> +source "drivers/Kconfig" >> + >> +source "fs/Kconfig" >> + >> +source "security/Kconfig" >> + >> +source "crypto/Kconfig" >> + >> +source "lib/Kconfig" > > -- ~Randy
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 07:47, Christoph Hellwig wrote: > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Signed-off-by: Christoph Hellwig > --- > Kconfig | 22 ++ > arch/alpha/Kconfig | 20 > arch/arc/Kconfig| 16 > arch/arm/Kconfig| 25 - > arch/arm64/Kconfig | 23 --- > arch/c6x/Kconfig| 24 > arch/h8300/Kconfig | 24 > arch/hexagon/Kconfig| 16 > arch/ia64/Kconfig | 20 > arch/m68k/Kconfig | 24 > arch/microblaze/Kconfig | 24 > arch/mips/Kconfig | 24 > arch/nds32/Kconfig | 16 > arch/nios2/Kconfig | 24 > arch/openrisc/Kconfig | 23 --- > arch/parisc/Kconfig | 24 > arch/powerpc/Kconfig| 19 --- > arch/riscv/Kconfig | 24 > arch/s390/Kconfig | 24 > arch/sh/Kconfig | 24 > arch/sparc/Kconfig | 24 > arch/unicore32/Kconfig | 24 > arch/x86/Kconfig| 22 +- > arch/xtensa/Kconfig | 25 - > 24 files changed, 23 insertions(+), 512 deletions(-) > > diff --git a/Kconfig b/Kconfig > index a90d9f9e268b..5499b1273ba5 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -10,3 +10,25 @@ comment "Compiler: $(CC_VERSION_TEXT)" > source "scripts/Kconfig.include" > > source "arch/$(SRCARCH)/Kconfig" > + > +source "init/Kconfig" Hi Christoph, Looks good overall. I'm still doing some testing on it. I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. Is there a reason that you chose the ordering above? Any known dependencies? Thanks. > + > +source "kernel/Kconfig.freezer" > + > +menu "Executable file formats" > +source "fs/Kconfig.binfmt" > +endmenu > + > +source "mm/Kconfig" > + > +source "net/Kconfig" > + > +source "drivers/Kconfig" > + > +source "fs/Kconfig" > + > +source "security/Kconfig" > + > +source "crypto/Kconfig" > + > +source "lib/Kconfig" -- ~Randy
Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig
On 07/02/18 07:47, Christoph Hellwig wrote: > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Signed-off-by: Christoph Hellwig > --- > Kconfig | 22 ++ > arch/alpha/Kconfig | 20 > arch/arc/Kconfig| 16 > arch/arm/Kconfig| 25 - > arch/arm64/Kconfig | 23 --- > arch/c6x/Kconfig| 24 > arch/h8300/Kconfig | 24 > arch/hexagon/Kconfig| 16 > arch/ia64/Kconfig | 20 > arch/m68k/Kconfig | 24 > arch/microblaze/Kconfig | 24 > arch/mips/Kconfig | 24 > arch/nds32/Kconfig | 16 > arch/nios2/Kconfig | 24 > arch/openrisc/Kconfig | 23 --- > arch/parisc/Kconfig | 24 > arch/powerpc/Kconfig| 19 --- > arch/riscv/Kconfig | 24 > arch/s390/Kconfig | 24 > arch/sh/Kconfig | 24 > arch/sparc/Kconfig | 24 > arch/unicore32/Kconfig | 24 > arch/x86/Kconfig| 22 +- > arch/xtensa/Kconfig | 25 - > 24 files changed, 23 insertions(+), 512 deletions(-) > > diff --git a/Kconfig b/Kconfig > index a90d9f9e268b..5499b1273ba5 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -10,3 +10,25 @@ comment "Compiler: $(CC_VERSION_TEXT)" > source "scripts/Kconfig.include" > > source "arch/$(SRCARCH)/Kconfig" > + > +source "init/Kconfig" Hi Christoph, Looks good overall. I'm still doing some testing on it. I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. Is there a reason that you chose the ordering above? Any known dependencies? Thanks. > + > +source "kernel/Kconfig.freezer" > + > +menu "Executable file formats" > +source "fs/Kconfig.binfmt" > +endmenu > + > +source "mm/Kconfig" > + > +source "net/Kconfig" > + > +source "drivers/Kconfig" > + > +source "fs/Kconfig" > + > +source "security/Kconfig" > + > +source "crypto/Kconfig" > + > +source "lib/Kconfig" -- ~Randy
