Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG_SMP
On Sat, Dec 28, 2013 at 5:48 PM, Kirill Tkhai wrote:
> On Сб, дек 28, 2013 at 05:37:32 +0800, Zhi Yong Wu wrote:
>> On Sat, Dec 28, 2013 at 5:19 PM, Kirill Tkhai wrote:
>> > On Пт, дек 27, 2013 at 07:41:00 +0800, Zhi Yong Wu wrote:
>> >> From: Zhi Yong Wu
>> >>
>> >> .switched_from shouldn't be initialized in the scope of CONFIG_SMP,
>> >> so this patch is trying to move it out.
>> >>
>> >> Signed-off-by: Zhi Yong Wu
>> >> ---
>> >> kernel/sched/rt.c |2 +-
>> >> 1 files changed, 1 insertions(+), 1 deletions(-)
>> >>
>> >> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
>> >> index 1c40655..f34d41b 100644
>> >> --- a/kernel/sched/rt.c
>> >> +++ b/kernel/sched/rt.c
>> >> @@ -2002,9 +2002,9 @@ const struct sched_class rt_sched_class = {
>> >> .pre_schedule = pre_schedule_rt,
>> >> .post_schedule = post_schedule_rt,
>> >> .task_woken = task_woken_rt,
>> >> - .switched_from = switched_from_rt,
>> >> #endif
>> >>
>> >> + .switched_from = switched_from_rt,
>> >> .set_curr_task = set_curr_task_rt,
>> >> .task_tick = task_tick_rt,
>> >
>> > This will not be compilable in !SMP mode because the body of
>> > switched_from_rt()
>> > is still under CONFIG_SMP define.
>> How about also removing its body out?
>
> switched_from_rt() is necessary only in SMP mode, so I think we should
> not change anything connected with it here. It's already initialized
> properly.
pls ignore this patch, thanks.
>
>> >
>> > Kirill
>>
>>
>>
>> --
>> Regards,
>>
>> Zhi Yong Wu
--
Regards,
Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG_SMP
On Сб, дек 28, 2013 at 05:37:32 +0800, Zhi Yong Wu wrote:
> On Sat, Dec 28, 2013 at 5:19 PM, Kirill Tkhai wrote:
> > On Пт, дек 27, 2013 at 07:41:00 +0800, Zhi Yong Wu wrote:
> >> From: Zhi Yong Wu
> >>
> >> .switched_from shouldn't be initialized in the scope of CONFIG_SMP,
> >> so this patch is trying to move it out.
> >>
> >> Signed-off-by: Zhi Yong Wu
> >> ---
> >> kernel/sched/rt.c |2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> >> index 1c40655..f34d41b 100644
> >> --- a/kernel/sched/rt.c
> >> +++ b/kernel/sched/rt.c
> >> @@ -2002,9 +2002,9 @@ const struct sched_class rt_sched_class = {
> >> .pre_schedule = pre_schedule_rt,
> >> .post_schedule = post_schedule_rt,
> >> .task_woken = task_woken_rt,
> >> - .switched_from = switched_from_rt,
> >> #endif
> >>
> >> + .switched_from = switched_from_rt,
> >> .set_curr_task = set_curr_task_rt,
> >> .task_tick = task_tick_rt,
> >
> > This will not be compilable in !SMP mode because the body of
> > switched_from_rt()
> > is still under CONFIG_SMP define.
> How about also removing its body out?
switched_from_rt() is necessary only in SMP mode, so I think we should
not change anything connected with it here. It's already initialized
properly.
> >
> > Kirill
>
>
>
> --
> Regards,
>
> Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG_SMP
On Sat, Dec 28, 2013 at 5:19 PM, Kirill Tkhai wrote:
> On Пт, дек 27, 2013 at 07:41:00 +0800, Zhi Yong Wu wrote:
>> From: Zhi Yong Wu
>>
>> .switched_from shouldn't be initialized in the scope of CONFIG_SMP,
>> so this patch is trying to move it out.
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> kernel/sched/rt.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
>> index 1c40655..f34d41b 100644
>> --- a/kernel/sched/rt.c
>> +++ b/kernel/sched/rt.c
>> @@ -2002,9 +2002,9 @@ const struct sched_class rt_sched_class = {
>> .pre_schedule = pre_schedule_rt,
>> .post_schedule = post_schedule_rt,
>> .task_woken = task_woken_rt,
>> - .switched_from = switched_from_rt,
>> #endif
>>
>> + .switched_from = switched_from_rt,
>> .set_curr_task = set_curr_task_rt,
>> .task_tick = task_tick_rt,
>
> This will not be compilable in !SMP mode because the body of
> switched_from_rt()
> is still under CONFIG_SMP define.
How about also removing its body out?
>
> Kirill
--
Regards,
Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] sched, rt: move .switched_from out of the scope of CONFIG_SMP
On Пт, дек 27, 2013 at 07:41:00 +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu
>
> .switched_from shouldn't be initialized in the scope of CONFIG_SMP,
> so this patch is trying to move it out.
>
> Signed-off-by: Zhi Yong Wu
> ---
> kernel/sched/rt.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 1c40655..f34d41b 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2002,9 +2002,9 @@ const struct sched_class rt_sched_class = {
> .pre_schedule = pre_schedule_rt,
> .post_schedule = post_schedule_rt,
> .task_woken = task_woken_rt,
> - .switched_from = switched_from_rt,
> #endif
>
> + .switched_from = switched_from_rt,
> .set_curr_task = set_curr_task_rt,
> .task_tick = task_tick_rt,
This will not be compilable in !SMP mode because the body of switched_from_rt()
is still under CONFIG_SMP define.
Kirill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
