Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
Hi, > Bart wrote: >> Al wrote: >> So AFAICS the minimal fix for that sucker is dependency on BLK_DEV_IDE=y; >> however, I really wonder if >> * it needs to be linked into ide-core (as opposed to being a normal >> module of its own) > >AFAICS there are no legacy device ordering issues with scc_pata so it doesn't >need to be linked into ide-core but I'll leave the definitive answer to Akira > >> * alternatively, its init should be called explicitly. I don't have the answer why scc_pata is linked into ide-core. Reviewing your comments and codes, I will make the following fixes: * remove link to ide-core and make normal module * move from ide/ppc to ide/pci I will send these patches later. Best regards, Akira Iguchi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
On Thursday 15 March 2007, Al Viro wrote: > On Thu, Mar 15, 2007 at 03:10:20PM +0900, Akira Iguchi wrote: > > Al wrote: > > > > > >Eh... You still need dependency on IDE=y; otherwise you'll get configs > > >with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI > > >is selectable just fine with IDE=m. > > > > > >It's the same problem as with ps3 fb. > > > > > > > I'm sorry I missed this case. > > Using some configurations, I found BLK_DEV_IDE=y was better. > > (I failed to link when IDE=y and BLK_DEV_IDE=m.) > > Umm... Point taken. After looking at the entire thing... well. > > a) BLK_DEV_IDE_PMAC has bogus dependency on IDE=y. If anything, that > should've been BLK_DEV_IDE=y; however, it *does* build with ide modular - > it doesn't generate a separate module and its initialization is called > explicitly from ide one. AFAICS, we can simply drop that dependency. agreed > b) BLK_DEV_IDE_PMAC does *not* build without BLK_DEV_IDEDMA_PMAC. Quoting > benh, "I don't see any reason to keep that dma thingy optional anyway". ditto > c) BLK_DEV_MPC8xx_IDE depends on BLK_DEV_IDE=y *and* IDE=y. The latter is > obviously redundant. The former... No idea, 8xx is currently b0rken in ditto > ARCH=powerpc and I can't be arsed to wade through arch/ppc bitrot. As it > is, driver definitely wants ARCH=ppc stuff (__res, for one thing). > > Now, BLK_DEV_IDE_CELLEB looks interesting. The nature of breakage is not > the same as usual (non-modular driver depends on stuff that might be built > modular); what's going on here is funnier. If you get ide-core modular, > you'll have BLK_DEV_IDE_CELLEB code *linked* *into* ide-core.ko. Unlike > the rest of its ilk, however, it doesn't have its init called directly from > ide init. It uses module_init(), which happens to work when it goes into > the kernel image (ide-core.o has several initcalls, not a problem), but breaks > when it goes into a modular ide-core.ko; there multiple module_init() are > fatal. > > So AFAICS the minimal fix for that sucker is dependency on BLK_DEV_IDE=y; > however, I really wonder if > * it needs to be linked into ide-core (as opposed to being a normal > module of its own) AFAICS there are no legacy device ordering issues with scc_pata so it doesn't need to be linked into ide-core but I'll leave the definitive answer to Akira > * alternatively, its init should be called explicitly. > > Comments? Care to provide patch for non-scc_pata issues that you've discovered? :-) Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
On Thu, Mar 15, 2007 at 03:10:20PM +0900, Akira Iguchi wrote: > Al wrote: > > > >Eh... You still need dependency on IDE=y; otherwise you'll get configs > >with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI > >is selectable just fine with IDE=m. > > > >It's the same problem as with ps3 fb. > > > > I'm sorry I missed this case. > Using some configurations, I found BLK_DEV_IDE=y was better. > (I failed to link when IDE=y and BLK_DEV_IDE=m.) Umm... Point taken. After looking at the entire thing... well. a) BLK_DEV_IDE_PMAC has bogus dependency on IDE=y. If anything, that should've been BLK_DEV_IDE=y; however, it *does* build with ide modular - it doesn't generate a separate module and its initialization is called explicitly from ide one. AFAICS, we can simply drop that dependency. b) BLK_DEV_IDE_PMAC does *not* build without BLK_DEV_IDEDMA_PMAC. Quoting benh, "I don't see any reason to keep that dma thingy optional anyway". c) BLK_DEV_MPC8xx_IDE depends on BLK_DEV_IDE=y *and* IDE=y. The latter is obviously redundant. The former... No idea, 8xx is currently b0rken in ARCH=powerpc and I can't be arsed to wade through arch/ppc bitrot. As it is, driver definitely wants ARCH=ppc stuff (__res, for one thing). Now, BLK_DEV_IDE_CELLEB looks interesting. The nature of breakage is not the same as usual (non-modular driver depends on stuff that might be built modular); what's going on here is funnier. If you get ide-core modular, you'll have BLK_DEV_IDE_CELLEB code *linked* *into* ide-core.ko. Unlike the rest of its ilk, however, it doesn't have its init called directly from ide init. It uses module_init(), which happens to work when it goes into the kernel image (ide-core.o has several initcalls, not a problem), but breaks when it goes into a modular ide-core.ko; there multiple module_init() are fatal. So AFAICS the minimal fix for that sucker is dependency on BLK_DEV_IDE=y; however, I really wonder if * it needs to be linked into ide-core (as opposed to being a normal module of its own) * alternatively, its init should be called explicitly. Comments? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
Al wrote: > >Eh... You still need dependency on IDE=y; otherwise you'll get configs >with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI >is selectable just fine with IDE=m. > >It's the same problem as with ps3 fb. > I'm sorry I missed this case. Using some configurations, I found BLK_DEV_IDE=y was better. (I failed to link when IDE=y and BLK_DEV_IDE=m.) Best regards, Akira Iguchi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
Al wrote: > >It's bool and it depends on IDE => should depend on IDE=y > >Signed-off-by: Al Viro <[EMAIL PROTECTED]> Move to "if BLK_DEV_IDEDMA_PCI" block because it depends on BLK_DEV_IDEDMA_PCI. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Akira Iguchi <[EMAIL PROTECTED]> --- diff -Nrpu -X linux-2.6.21-rc3/Documentation/dontdiff linux-2.6.21-rc3/drivers/ide/Kconfig linux-2.6.21-rc3.mod/drivers/ide/Kconfig --- linux-2.6.21-rc3/drivers/ide/Kconfig2007-03-07 13:41:20.0 +0900 +++ linux-2.6.21-rc3.mod/drivers/ide/Kconfig2007-03-15 22:47:14.0 +0900 @@ -769,6 +769,14 @@ config BLK_DEV_TC86C001 help This driver adds support for Toshiba TC86C001 GOKU-S chip. +config BLK_DEV_IDE_CELLEB + bool "Toshiba's Cell Reference Set IDE support" + depends on PPC_CELLEB + help + This driver provides support for the built-in IDE controller on + Toshiba Cell Reference Board. + If unsure, say Y. + endif config BLK_DEV_IDE_PMAC @@ -800,14 +808,6 @@ config BLK_DEV_IDEDMA_PMAC to transfer data to and from memory. Saying Y is safe and improves performance. -config BLK_DEV_IDE_CELLEB - bool "Toshiba's Cell Reference Set IDE support" - depends on PPC_CELLEB - help - This driver provides support for the built-in IDE controller on - Toshiba Cell Reference Board. - If unsure, say Y. - config BLK_DEV_IDE_SWARM tristate "IDE for Sibyte evaluation boards" depends on SIBYTE_SB1xxx_SOC - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
On Thu, Mar 15, 2007 at 02:25:40PM +0900, Akira Iguchi wrote: > Al wrote: > > > >It's bool and it depends on IDE => should depend on IDE=y > > > >Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > Move to "if BLK_DEV_IDEDMA_PCI" block because it depends on > BLK_DEV_IDEDMA_PCI. > +config BLK_DEV_IDE_CELLEB > + bool "Toshiba's Cell Reference Set IDE support" > + depends on PPC_CELLEB > + help > + This driver provides support for the built-in IDE controller on > + Toshiba Cell Reference Board. > + If unsure, say Y. > + Eh... You still need dependency on IDE=y; otherwise you'll get configs with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI is selectable just fine with IDE=m. It's the same problem as with ps3 fb. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
