Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
On 13 August 2013 00:41, Hans-Christian Egtvedt wrote: > Around Mon 12 Aug 2013 13:09:25 +0530 or thereabout, Viresh Kumar wrote: >> On 12 August 2013 13:00, Hans-Christian Egtvedt wrote: >>> I'll add it on my todo-list and have a look at it in the evening (-: >> >> Thanks. >> >>> How hard can it be™ >> >> Its not about being hard but about knowing your platform well.. > > Turned out to be quite easy, but I couldn't get around to test it on > hardware (excuse: just moved, all HW is still in a box somewhere). I had a quick look at it and yes it is pretty much hadware specific :) Thanks. > I'll submit the patch to cpuf...@vger.kernel.org for a sanity check, perhaps > you'll pull it into your series? Yes, I will. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
Around Mon 12 Aug 2013 13:09:25 +0530 or thereabout, Viresh Kumar wrote: > On 12 August 2013 13:00, Hans-Christian Egtvedt wrote: >> I'll add it on my todo-list and have a look at it in the evening (-: > > Thanks. > >> How hard can it be™ > > Its not about being hard but about knowing your platform well.. Turned out to be quite easy, but I couldn't get around to test it on hardware (excuse: just moved, all HW is still in a box somewhere). I'll submit the patch to cpuf...@vger.kernel.org for a sanity check, perhaps you'll pull it into your series? -- mvh Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
On 12 August 2013 13:00, Hans-Christian Egtvedt wrote: > I'll add it on my todo-list and have a look at it in the evening (-: Thanks. > How hard can it be™ Its not about being hard but about knowing your platform well.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
Around Mon 12 Aug 2013 12:43:37 +0530 or thereabout, Viresh Kumar wrote: > On 12 August 2013 12:40, Hans-Christian Egtvedt wrote: >> Ok, AVR32 driver should expose a frequency table then, which is quite simple. > > It would be really nice if you can provide that patch, that will make > my life simple :) > > I thought I can get a table for it but wasn't able to find out > necessary information > for that. I'll add it on my todo-list and have a look at it in the evening (-: How hard can it be™ -- mvh Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
On 12 August 2013 12:40, Hans-Christian Egtvedt wrote: > Ok, AVR32 driver should expose a frequency table then, which is quite simple. It would be really nice if you can provide that patch, that will make my life simple :) I thought I can get a table for it but wasn't able to find out necessary information for that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
Around Mon 12 Aug 2013 11:37:45 +0530 or thereabout, Viresh Kumar wrote: > On 10 August 2013 13:53, Hans-Christian Egtvedt wrote: >> Around Sat 10 Aug 2013 12:14:07 +0530 or thereabout, Viresh Kumar wrote: >>> Most of the CPUFreq drivers do similar things in .exit() and .verify() >>> routines >>> and .attr. So its better if we have generic routines for them which can be >>> used >>> by cpufreq drivers then. >>> >>> This patch uses these generic routines for this driver. >> >> Nice, thanks for cleaning up (-: >> >>> Cc: Hans-Christian Egtvedt >>> Signed-off-by: Viresh Kumar >> >> Acked-by: Hans-Christian Egtvedt > > Thanks for your Ack but I have to NACK it :) > > My patch was wrong.. It was based on the assumption that everybody who > had implemented a .target() also implements a frequency table and exposes > it.. And the generic routines I have exposed depend on that frequency table. > And this cpufreq driver doesn't expose that freq table... Right, my bad, I just looked at the code flow and saw that the generic path did pretty much the same as the AVR32 implementation. Didn't consider the table part as missing. > And so this patch is dropped :( > Ok, AVR32 driver should expose a frequency table then, which is quite simple. -- mvh Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
On 10 August 2013 13:53, Hans-Christian Egtvedt wrote: > Around Sat 10 Aug 2013 12:14:07 +0530 or thereabout, Viresh Kumar wrote: >> Most of the CPUFreq drivers do similar things in .exit() and .verify() >> routines >> and .attr. So its better if we have generic routines for them which can be >> used >> by cpufreq drivers then. >> >> This patch uses these generic routines for this driver. > > Nice, thanks for cleaning up (-: > >> Cc: Hans-Christian Egtvedt >> Signed-off-by: Viresh Kumar > > Acked-by: Hans-Christian Egtvedt Thanks for your Ack but I have to NACK it :) My patch was wrong.. It was based on the assumption that everybody who had implemented a .target() also implements a frequency table and exposes it.. And the generic routines I have exposed depend on that frequency table. And this cpufreq driver doesn't expose that freq table... And so this patch is dropped :( -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
Around Sat 10 Aug 2013 12:14:07 +0530 or thereabout, Viresh Kumar wrote: > Most of the CPUFreq drivers do similar things in .exit() and .verify() > routines > and .attr. So its better if we have generic routines for them which can be > used > by cpufreq drivers then. > > This patch uses these generic routines for this driver. Nice, thanks for cleaning up (-: > Cc: Hans-Christian Egtvedt > Signed-off-by: Viresh Kumar Acked-by: Hans-Christian Egtvedt > --- > drivers/cpufreq/at32ap-cpufreq.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) -- mvh Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
