Re: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter
On Mon, Nov 24, 2014 at 02:00:18AM +, Ben Hutchings wrote:
> On Sat, 2014-11-22 at 04:39 +, Al Viro wrote:
> [...]
> > - ret = rds_page_copy_from_user(sg_page(sg), sg->offset + sg_off,
> > - iov->iov_base + iov_off,
> > - to_copy);
> [...]
>
> It looks like rds_page_copy{,_from,_to}_user() are all unused after this
> change, so you could delete them.
Maybe. Or maybe add a saner wrapper for rds_page_copy_from_user()... Separate
story, anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter
On Mon, Nov 24, 2014 at 02:00:18AM +, Ben Hutchings wrote:
On Sat, 2014-11-22 at 04:39 +, Al Viro wrote:
[...]
- ret = rds_page_copy_from_user(sg_page(sg), sg-offset + sg_off,
- iov-iov_base + iov_off,
- to_copy);
[...]
It looks like rds_page_copy{,_from,_to}_user() are all unused after this
change, so you could delete them.
Maybe. Or maybe add a saner wrapper for rds_page_copy_from_user()... Separate
story, anyway.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter
On Sat, 2014-11-22 at 04:39 +, Al Viro wrote:
[...]
> - ret = rds_page_copy_from_user(sg_page(sg), sg->offset + sg_off,
> - iov->iov_base + iov_off,
> - to_copy);
[...]
It looks like rds_page_copy{,_from,_to}_user() are all unused after this
change, so you could delete them.
Ben.
--
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
signature.asc
Description: This is a digitally signed message part
Re: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter
On Sat, 2014-11-22 at 04:39 +, Al Viro wrote:
[...]
- ret = rds_page_copy_from_user(sg_page(sg), sg-offset + sg_off,
- iov-iov_base + iov_off,
- to_copy);
[...]
It looks like rds_page_copy{,_from,_to}_user() are all unused after this
change, so you could delete them.
Ben.
--
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
signature.asc
Description: This is a digitally signed message part
