Re: [PATCH 2/2] mtip32xx: mtip32xx: Disable TRIM support
On 4/14/2013 1:55 PM, Jens Axboe wrote: > On Fri, Apr 12 2013, Asai Thambi S P wrote: >> >> Temporarily disabling TRIM support until TRIM related issues >> are addressed in the firmware. > > How serious is this? We do have released kernels out there with the > driver, you might want to consider a stable backport too. > > Anyway, applied for 3.10. > Added TRIM support in 3.9 merge window. If this trivial change could be pushed, it would be good. Otherwise, I can backport to stable 3.9 when released. -- regards, asai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/2] mtip32xx: mtip32xx: Disable TRIM support
> On Fri, Apr 12 2013, Asai Thambi S P wrote: > > > > Temporarily disabling TRIM support until TRIM related issues > > are addressed in the firmware. > > How serious is this? We do have released kernels out there with the > driver, you might want to consider a stable backport too. It's a performance issue, not data integrity. Since the ATA trim command is non-queueable, IO traffic must halt while the trim is outstanding. A filesystem that is actively trimming sectors is effectively duty cycling the IO path on this part. We are working to shrink the trim command latency while also investigating whether some sort of offline trim is more appropriate. Given the incremental endurance gain for trim on 34nm SLC vs the severe throughput degradation under some workloads, it seemed prudent to disable the feature. If you think that warrants a stable backport, just let me or Asai know. -Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/2] mtip32xx: mtip32xx: Disable TRIM support
On Fri, Apr 12 2013, Asai Thambi S P wrote: Temporarily disabling TRIM support until TRIM related issues are addressed in the firmware. How serious is this? We do have released kernels out there with the driver, you might want to consider a stable backport too. It's a performance issue, not data integrity. Since the ATA trim command is non-queueable, IO traffic must halt while the trim is outstanding. A filesystem that is actively trimming sectors is effectively duty cycling the IO path on this part. We are working to shrink the trim command latency while also investigating whether some sort of offline trim is more appropriate. Given the incremental endurance gain for trim on 34nm SLC vs the severe throughput degradation under some workloads, it seemed prudent to disable the feature. If you think that warrants a stable backport, just let me or Asai know. -Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] mtip32xx: mtip32xx: Disable TRIM support
On 4/14/2013 1:55 PM, Jens Axboe wrote: On Fri, Apr 12 2013, Asai Thambi S P wrote: Temporarily disabling TRIM support until TRIM related issues are addressed in the firmware. How serious is this? We do have released kernels out there with the driver, you might want to consider a stable backport too. Anyway, applied for 3.10. Added TRIM support in 3.9 merge window. If this trivial change could be pushed, it would be good. Otherwise, I can backport to stable 3.9 when released. -- regards, asai -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] mtip32xx: mtip32xx: Disable TRIM support
On Fri, Apr 12 2013, Asai Thambi S P wrote: > > Temporarily disabling TRIM support until TRIM related issues > are addressed in the firmware. How serious is this? We do have released kernels out there with the driver, you might want to consider a stable backport too. Anyway, applied for 3.10. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] mtip32xx: mtip32xx: Disable TRIM support
On Fri, Apr 12 2013, Asai Thambi S P wrote: Temporarily disabling TRIM support until TRIM related issues are addressed in the firmware. How serious is this? We do have released kernels out there with the driver, you might want to consider a stable backport too. Anyway, applied for 3.10. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
